Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread git
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly File Documentation/snippets/subdividing-beams.ly (right): https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread tdanielsmusic
On 2015/12/22 18:34:43, git wrote: https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly File Documentation/snippets/subdividing-beams.ly (right):

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread Urs Liska
Am 22.12.2015 um 20:51 schrieb Carl Sorensen: > Copy the snippet to Documentation/snippets/new. > > Remove the machine-generated header. > > Make your changes. > > Submit the patch. OK, that is more or less what I did (in patch set 2). The only thing that is left for me to update is *not* to

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread Carl Sorensen
On 12/22/15 1:31 PM, "lilypond-devel-bounces+c_sorensen=byu@gnu.org on behalf of Urs Liska" wrote: > >So basically I can simply remove the changes to that file from my patch >and upload it again, isn't it?

Re: Store accidental styles in an alist (issue 280510043 by simon.albre...@mail.de)

2015-12-22 Thread Simon Albrecht
On 22.12.2015 15:39, d...@gnu.org wrote: https://codereview.appspot.com/280510043/diff/20001/scm/music-functions.scm#newcode1702 scm/music-functions.scm:1702: (define-public accidental-styles The only rationale for making this a public variable is if the user is expected to be able to change

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread Carl Sorensen
Copy the snippet to Documentation/snippets/new. Remove the machine-generated header. Make your changes. Submit the patch. Carl On 12/22/15 11:34 AM, "g...@ursliska.de" wrote: > >https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets

Re: Where to edit "selected snippets"

2015-12-22 Thread Phil Holmes
- Original Message - From: "Urs Liska" To: Sent: Monday, December 21, 2015 9:50 PM Subject: Re: Where to edit "selected snippets" Am 21.12.2015 um 22:19 schrieb Urs Liska: Hi all, for a patch I'm currently finishing I have to update

PATCHES: Countdown for December the 25th

2015-12-22 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on December the 25th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ __ Push: 4700 Add scheme procedure

Re: lilypond-auto doesn't work correctly

2015-12-22 Thread Trevor Daniels
Werner, you wrote Tuesday, December 22, 2015 4:11 AM > Is it possible to resurrect correct functionality of the > `lilypond-auto' list? Currently, no mails from allura are sent to > it, which makes it sort of useless... There is a comparable list, Testlilyissues-auto, at SourceForge. I've

Re: Issue 2314 - workaround and patch

2015-12-22 Thread James Lowe
Hello Knut, On 21/12/15 13:50, Knut Petersen wrote: > Hi everybody! > > Werner: You reported in 2012 that lilypond emits a space glyph > referencing > the century schoolbook font at the top of every page. > > David: At that time you were not sure if this is a bug. > > The problem is still

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread pkx166h
https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly File Documentation/snippets/subdividing-beams.ly (right): https://codereview.appspot.com/276560043/diff/20001/Documentation/snippets/subdividing-beams.ly#newcode7

Re: git cl wording issue

2015-12-22 Thread Phil Holmes
- Original Message - From: "Urs Liska" To: "lilypond-devel" Sent: Monday, December 21, 2015 11:16 PM Subject: git cl wording issue Just used the current git-cl for the first time and noticed a *minor* glitch. This link in the console

Doc: CG minor corrections to 2.1 LilyDev (issue 277450043 by pkx1...@gmail.com)

2015-12-22 Thread pkx166h
Reviewers: , Message: passes make, make check and a full make doc. Description: Doc: CG minor corrections to 2.1 LilyDev Minor corrections to CG 2.1 Please review this at https://codereview.appspot.com/277450043/ Affected files (+4, -4 lines): M Documentation/contributor/quick-start.itexi

Dont emit \space glyph as empty page number (issue 276570043 by pkx1...@gmail.com)

2015-12-22 Thread pkx166h
Reviewers: , Message: Passes make, make check and a full make doc. Description: Dont emit \space glyph as empty page number Werner L reported in 2012 that LP emits a space glyph referencing the century schoolbook font at the top of every page. If you use gs (old and current) or pdfcrop to

Re: Improve beam count handling with subdivided beams (issue 276560043 by g...@ursliska.de)

2015-12-22 Thread git
Thanks for the comments, changes uploaded. https://codereview.appspot.com/276560043/diff/1/Documentation/snippets/new/subdividing-beams.ly File Documentation/snippets/new/subdividing-beams.ly (right):

Re: Store accidental styles in an alist (issue 280510043 by simon.albre...@mail.de)

2015-12-22 Thread dak
https://codereview.appspot.com/280510043/diff/20001/scm/music-functions.scm File scm/music-functions.scm (right): https://codereview.appspot.com/280510043/diff/20001/scm/music-functions.scm#newcode1702 scm/music-functions.scm:1702: (define-public accidental-styles The only rationale for making