Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Graham Percival
On Mon, Jan 09, 2017 at 03:17:38AM +0100, Simon Albrecht wrote: > I get a feeling we’re very good at producing misunderstandings right now… > :-) Yes. :) I have pushed the attached patch to staging. Cheers, - Graham ___ lilypond-devel mailing list

Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Simon Albrecht
On 09.01.2017 01:28, Thomas Morley wrote: Well, James set it to Patch:push, so push it, unless you think the review wasn’t sound and it should get another one. OTOH, regardless of what you think of { 8 8~ 2 4 }, the version of this latest patch is uncontroversial as far as I see. So why not

Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Thomas Morley
2017-01-09 1:15 GMT+01:00 Simon Albrecht : > On 09.01.2017 01:05, Thomas Morley wrote: >> >> I'm not sure what I should do. >> >> Push the counted down patch or do you want to have your new patch >> uploaded or ...? > > > Well, James set it to Patch:push, so push it, unless

Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Simon Albrecht
On 09.01.2017 01:05, Thomas Morley wrote: I'm not sure what I should do. Push the counted down patch or do you want to have your new patch uploaded or ...? Well, James set it to Patch:push, so push it, unless you think the review wasn’t sound and it should get another one. OTOH, regardless

Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Thomas Morley
2017-01-08 17:36 GMT+01:00 Simon Albrecht : > On 08.01.2017 16:23, James wrote: >> >> 5027 NR 1.2.1.d: Split note correctly - Simon Albrecht >> https://sourceforge.net/p/testlilyissues/issues/5027 >> http://codereview.appspot.com/319940043 > > > I do not think the Hindemith

Re: patch for git-cl

2017-01-08 Thread Thomas Morley
2017-01-09 0:09 GMT+01:00 Graham Percival : > On Sun, Jan 08, 2017 at 09:02:51PM +, Thomas Morley wrote: >> attached a little patch for git-cl to replace googlecodeissue by >> trackerissue in cl_settings.py, which will result in correct info in >> .git/config >> >>

Re: patch for git-cl

2017-01-08 Thread Graham Percival
On Sun, Jan 08, 2017 at 09:02:51PM +, Thomas Morley wrote: > attached a little patch for git-cl to replace googlecodeissue by > trackerissue in cl_settings.py, which will result in correct info in > .git/config > > How do we handle patches to git-cl? In general, I'd recommend a PR, but I've

Re: patch for git-cl

2017-01-08 Thread Graham Percival
On Sun, Jan 08, 2017 at 10:15:24PM +, James wrote: > On Sun, 8 Jan 2017 21:02:51 + > Thomas Morley wrote: > > > attached a little patch for git-cl to replace googlecodeissue by > > trackerissue in cl_settings.py, which will result in correct info in > >

Re: patch for git-cl

2017-01-08 Thread James
On Sun, 8 Jan 2017 21:02:51 + Thomas Morley wrote: > Hi, > > attached a little patch for git-cl to replace googlecodeissue by > trackerissue in cl_settings.py, which will result in correct info in > .git/config > > How do we handle patches to git-cl? I imagine

patch for git-cl

2017-01-08 Thread Thomas Morley
Hi, attached a little patch for git-cl to replace googlecodeissue by trackerissue in cl_settings.py, which will result in correct info in .git/config How do we handle patches to git-cl? Cheers, Harm From b8364652a91f3e07bef7719da71f56994c69e7b3 Mon Sep 17 00:00:00 2001 From: Thomas Morley

Re: NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

2017-01-08 Thread Simon Albrecht
On 08.01.2017 17:48, thomasmorle...@gmail.com wrote: Not sure you can upload to _this_ Rietveld issue. Probably best you try and if not a new will be opened (and I close this one). Since the review is finished (James set it to Patch:push) just close it – that’s what I couldn’t do. Best,

New Danish PO file for 'lilypond' (version 2.19.54)

2017-01-08 Thread Translation Project Robot
Hello, gentle maintainer. This is a message from the Translation Project robot. A revised PO file for textual domain 'lilypond' has been submitted by the Danish team of translators. The file is available at: http://translationproject.org/latest/lilypond/da.po (We can arrange things so

Re: NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

2017-01-08 Thread thomasmorley65
On 2017/01/08 16:42:58, simon.albrecht wrote: On 04.01.2017 00:14, mailto:thomasmorle...@gmail.com wrote: > (I shepherd this for Simon, as long as he has problems with his google > account) For the record: Google prevented the login despite that I accessed the internet with the same

Re: NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

2017-01-08 Thread Simon Albrecht
On 04.01.2017 00:14, thomasmorle...@gmail.com wrote: (I shepherd this for Simon, as long as he has problems with his google account) For the record: Google prevented the login despite that I accessed the internet with the same machine as always, and only because I did so through a different

Re: PATCHES - Countdown for January 8th

2017-01-08 Thread Simon Albrecht
On 08.01.2017 16:23, James wrote: 5027 NR 1.2.1.d: Split note correctly - Simon Albrecht https://sourceforge.net/p/testlilyissues/issues/5027 http://codereview.appspot.com/319940043 I do not think the Hindemith quote brought up by Hans Aberg is representative of common notational convention,

PATCHES - Countdown for January 8th

2017-01-08 Thread James
Hello, Here is the current patch countdown list. The next countdown will be on January 11th A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5027 NR 1.2.1.d: Split note correctly - Simon Albrecht

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

2017-01-08 Thread david . nalesnik
On 2017/01/08 11:37:18, thomasmorley651 wrote: On 2017/01/07 17:12:57, david.nalesnik wrote: > Please review. Thanks! Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } {

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

2017-01-08 Thread thomasmorley65
On 2017/01/07 17:12:57, david.nalesnik wrote: Please review. Thanks! Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } { \override Hairpin.minimum-length = 40 \override