Re: Rational

2018-05-22 Thread metachromatic
To get back to practicalities, here is an absolutely minimal example of the alleged problems with using rationals as internal representations of durations/positions in Lilypond. Please note that I use the term "alleged problems" because it might not be clear to everyone that this internal

Re: Rational

2018-05-22 Thread David Kastrup
Hans Åberg writes: >> On 22 May 2018, at 23:28, David Kastrup wrote: >> >> Hans Åberg writes: >> On 22 May 2018, at 22:53, David Kastrup wrote: >> This was somewhat complicated by some Midi classes being

Re: Rational

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 23:28, David Kastrup wrote: > > Hans Åberg writes: > >>> On 22 May 2018, at 22:53, David Kastrup wrote: >>> > This was somewhat complicated by some Midi classes being heap-allocated > and containing Rational/Moment

Re: Allow Scheme/identifiers for duration multipliers (issue 346810043 by d...@gnu.org)

2018-05-22 Thread dak
Reviewers: thomasmorley651, carl.d.sorensen_gmail.com, Message: On 2018/05/22 21:05:59, thomasmorley651 wrote: From description and regtest: very nice. Will it work for below as well? #(define frac (inexact->exact (/ 3.0 4.0))) { r1*/frac } As written no, but it depends on what you

Re: Rational

2018-05-22 Thread David Kastrup
Hans Åberg writes: >> On 22 May 2018, at 22:53, David Kastrup wrote: >> This was somewhat complicated by some Midi classes being heap-allocated and containing Rational/Moment members: those Midi classes would have to become SCM-connected. I did

Re: Allow Scheme/identifiers for duration multipliers (issue 346810043 by d...@gnu.org)

2018-05-22 Thread Carl . D . Sorensen
LGreatTM! You have a way af making changes to the parser seem obvious, when they wouldn't have even crossed my mind. Thank you for all your hard work to rationalize the parser so that things like this can be done. https://codereview.appspot.com/346810043/

Re: Rational

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 22:53, David Kastrup wrote: > >>> This was somewhat complicated by some Midi classes being heap-allocated >>> and containing Rational/Moment members: those Midi classes would have to >>> become SCM-connected. I did some work on that, don't remember how >>>

Allow Scheme/identifiers for duration multipliers (issue 346810043 by d...@gnu.org)

2018-05-22 Thread thomasmorley65
From description and regtest: very nice. Will it work for below as well? #(define frac (inexact->exact (/ 3.0 4.0))) { r1*/frac } https://codereview.appspot.com/346810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Rational

2018-05-22 Thread David Kastrup
Hans Åberg writes: >> On 22 May 2018, at 22:07, David Kastrup wrote: >> >> Hans Åberg writes: >> On 22 May 2018, at 20:45, David Kastrup wrote: LilyPond's "rational" type should indeed get replaced by

Re: Rational

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 22:07, David Kastrup wrote: > > Hans Åberg writes: > >>> On 22 May 2018, at 20:45, David Kastrup wrote: >>> >>> LilyPond's "rational" type should indeed get replaced >>> by Guile's rational types which would seriously

Re: Rational

2018-05-22 Thread David Kastrup
Hans Åberg writes: >> On 22 May 2018, at 20:45, David Kastrup wrote: >> >> LilyPond's "rational" type should indeed get replaced >> by Guile's rational types which would seriously shift the threshold >> where things start breaking apart at the cost of

Re: Rational

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 21:10, Hans Åberg wrote: > > >> On 22 May 2018, at 20:45, David Kastrup wrote: >> >> LilyPond's "rational" type should indeed get replaced >> by Guile's rational types which would seriously shift the threshold >> where things start

Rational

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 20:45, David Kastrup wrote: > > LilyPond's "rational" type should indeed get replaced > by Guile's rational types which would seriously shift the threshold > where things start breaking apart at the cost of efficiency. > > That's quite a lot of tedious work

Re: Microrhythm

2018-05-22 Thread David Kastrup
Carl Sorensen writes: > On 5/21/18, 10:02 PM, "lilypond-devel on behalf of metachromatic" > metachroma...@gmail.com> wrote: > >BTW, it's trivial in Lilypond to get the program to print out >

Re: Microrhythm

2018-05-22 Thread Hans Åberg
[Adding reference that dropped out.] I used continued fractions; see [1], which gives some useful algorithms. They converge very quickly, and one can refine to a suitable degree. In music, one does not need very large denominators, as the timing quickly becomes fine enough. 1.

Re: Microrhythm

2018-05-22 Thread Carl Sorensen
On 5/21/18, 10:02 PM, "lilypond-devel on behalf of metachromatic" wrote: = Different percentages of microrhythm will require correspondingly larger tuplets, and, due to the

Issue 5326: Generalize the special case of creating a Timing context (issue 344910043 by nine.fierce.ball...@gmail.com)

2018-05-22 Thread Carl . D . Sorensen
LGTM https://codereview.appspot.com/344910043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Microrhythm

2018-05-22 Thread Hans Åberg
> On 22 May 2018, at 06:01, metachromatic wrote: > Different percentages of microrhythm will require correspondingly > larger tuplets, and, due to the bad design decision to represent > rhythms internally in Lilypond as integers, you'll soon run out of > integers to