Fix bad rotation center from issue 5346 (issue 341380043 by d...@gnu.org)

2018-06-16 Thread torsten . haemmerle
Yup, that's it! Now it behaves exactly identical to Stencil::rotate_degrees and the PNG regtests are successfull, too. Thanks! Torsten https://codereview.appspot.com/341380043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: make doc bombs out in MusicXML

2018-06-16 Thread James Lowe
Hello On Sat, 16 Jun 2018 14:20:43 +0100 (BST), "James Lowe" wrote: > Hello > > On Sat, 16 Jun 2018 09:10:10 -0400, Dan Eble wrote: > > > On Jun 16, 2018, at 08:46, James Lowe wrote: > > > > > > Well before I applied those patches on behalf of Alexander's patches I > > > did a full patch

Re: Fix GC issue in skyline rotations (issue 344960043 by d...@gnu.org)

2018-06-16 Thread dak
Reviewers: Be-3, Message: On 2018/06/16 12:33:50, Be-3 wrote: First of all: thanks for taking care of this issue! But the resulting skylines don't quite work as expected yet (see attached image in the issue tracker). Seems to be a problem with the centre of rotation co-ordinates.

Re: make doc bombs out in MusicXML

2018-06-16 Thread James Lowe
Hello On Sat, 16 Jun 2018 09:10:10 -0400, Dan Eble wrote: > On Jun 16, 2018, at 08:46, James Lowe wrote: > > > > Well before I applied those patches on behalf of Alexander's patches I did > > a full patch test with the patches applied and had no problems. > > > > However ... I know that

Re: make doc bombs out in MusicXML

2018-06-16 Thread Dan Eble
On Jun 16, 2018, at 08:46, James Lowe wrote: > > Well before I applied those patches on behalf of Alexander's patches I did a > full patch test with the patches applied and had no problems. > > However ... I know that there are some 'prgramming errors' reported that do > not break patch

Re: make doc bombs out in MusicXML

2018-06-16 Thread James Lowe
Hello, On Sat, 16 Jun 2018 14:21:28 +0200, David Kastrup wrote: > > I get the following: > > lilypond-book.py: error: `musicxml2ly --out=- - ' failed (0) > lilypond-book.py: error: The error log is as follows: > musicxml2ly: Reading MusicXML from Standard input ... > musicxml2ly: Converting

Fix GC issue in skyline rotations (issue 344960043 by d...@gnu.org)

2018-06-16 Thread torsten . haemmerle
First of all: thanks for taking care of this issue! But the resulting skylines don't quite work as expected yet (see attached image in the issue tracker). Seems to be a problem with the centre of rotation co-ordinates. Greetings, Torsten https://codereview.appspot.com/344960043/

Re: Issue 5344: Avoid repeated calculation of accepted contexts (issue 346080043 by nine.fierce.ball...@gmail.com)

2018-06-16 Thread nine . fierce . ballads
https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc File lily/acceptance-set.cc (right): https://codereview.appspot.com/346080043/diff/1/lily/acceptance-set.cc#newcode50 lily/acceptance-set.cc:50: accepted_ = scm_cons(item, scm_delete_x (item, accepted_)); On 2018/06/15

Re: make doc bombs out in MusicXML

2018-06-16 Thread David Kastrup
David Kastrup writes: > I get the following: > > lilypond-book.py: error: `musicxml2ly --out=- - ' failed (0) > lilypond-book.py: error: The error log is as follows: > musicxml2ly: Reading MusicXML from Standard input ... > musicxml2ly: Converting to LilyPond expressions... > Traceback (most

make doc bombs out in MusicXML

2018-06-16 Thread David Kastrup
I get the following: lilypond-book.py: error: `musicxml2ly --out=- - ' failed (0) lilypond-book.py: error: The error log is as follows: musicxml2ly: Reading MusicXML from Standard input ... musicxml2ly: Converting to LilyPond expressions... Traceback (most recent call last): File

Re: musicxml2ly: handle hidden time signatures; support text+bpm \tempo marks. (issue 344000043 by a.mylt...@gmail.com)

2018-06-16 Thread pkxgnugitcl
On 2018/06/13 14:38:23, lilypond-pkx wrote: On 2018/06/04 10:51:25, a.myltsev wrote: > Removed the 'test' commits, leaving only changes to Python files. Patch counted down - please push. Alex if you do not have commit access can you attach a git-formatted patch (re-based against current

PATCHES - Countdown for June 16th

2018-06-16 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on June 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5340 Simplify Spacing_spanner::get_columns - Dan Eble