LGTM.
https://codereview.appspot.com/343270043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2018/06/17 18:13:20, dak wrote:
I must be getting senile. I didn't spot where you make the copy.
In fairness, the copy was not as obvious in patch set 1, though that's
not proof you're not getting senile. :D
https://codereview.appspot.com/346080043/
On 2018/06/17 17:56:06, Dan Eble wrote:
On 2018/06/17 17:51:34, Dan Eble wrote:
> test that \with \denies ... has local effect
Thanks for the clue. The new test passes with the code I've submitted
and fails
if Acceptance_set::assign_copy is modified not to make a copy.
I must be getting
On 2018/06/17 17:51:34, Dan Eble wrote:
test that \with \denies ... has local effect
Thanks for the clue. The new test passes with the code I've submitted
and fails if Acceptance_set::assign_copy is modified not to make a copy.
https://codereview.appspot.com/346080043/
On 2018/06/17 13:27:39, Dan Eble wrote:
On 2018/06/17 12:52:01, Dan Eble wrote:
> Stop uniquifying \accepts; clarify copying
I also spent time trying to find input that would "let \with blocks
destructively change global context defs." I was surprised that I
couldn't make
it happen even
On 2018/06/17 12:52:01, Dan Eble wrote:
Stop uniquifying \accepts; clarify copying
I also spent time trying to find input that would "let \with blocks
destructively change global context defs." I was surprised that I
couldn't make it happen even after temporarily changing the
Acceptance_set
On 2018/06/17 10:54:38, dak wrote:
Right. I haven't rebased this patch yet, but I naturally will have to
load up
another version for review now that the fix is in master.
I actually lean towards doing this in a manner similar to your original
approach, namely just using the stencil rotation
Reviewers: Be-3,
https://codereview.appspot.com/344970043/diff/1/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/344970043/diff/1/lily/stencil-integral.cc#newcode1099
lily/stencil-integral.cc:1099: Offset center (robust_scm2double
(scm_cadr (rot),
https://codereview.appspot.com/344970043/diff/1/lily/stencil-integral.cc
File lily/stencil-integral.cc (right):
https://codereview.appspot.com/344970043/diff/1/lily/stencil-integral.cc#newcode1099
lily/stencil-integral.cc:1099: Offset center (robust_scm2double
(scm_cadr (rot), 0.0),
