Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-13 Thread nine . fierce . ballads
On 2018/08/13 12:55:39, dak wrote: Apropos: what have you done about the warnings regarding SCM_UNPACK ? Those use something like (0 ? *(SCM*)0 : ...) for type coercion/checking and the resulting warnings clutter everything for me. I'll likely change my local Guile-1.8 source for quieting

Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread torsten . haemmerle
On 2018/08/13 16:56:51, dak wrote: […] Hi David, Thanks for the hints, I'll look into issues 4065 and 677. As far as layout staff sizes, \magnifyStaff, fontSize/staff-space and all the others are concerned (I've tested many variations back and forth) the results were (surprisingly) stable.

Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread dak
On 2018/08/13 16:46:59, Be-3 wrote: On 2018/08/13 16:21:10, lemzwerg wrote: > LGTM, thanks! > > https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly > File input/regression/book-change-global-staffsize-abs-fonts.ly (right): > >

Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread torsten . haemmerle
On 2018/08/13 16:21:10, lemzwerg wrote: LGTM, thanks! https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly File input/regression/book-change-global-staffsize-abs-fonts.ly (right):

Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread lemzwerg
LGTM, thanks! https://codereview.appspot.com/341450043/diff/1/input/regression/book-change-global-staffsize-abs-fonts.ly File input/regression/book-change-global-staffsize-abs-fonts.ly (right):

Re: Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread torsten . haemmerle
Reviewers: dak, Message: On 2018/08/13 12:17:29, dak wrote: Does not help with the other problems we had with fontsize mismatches (out of multiple calls of set-global-staff-size), right? What would a correct solution look like? Hmmm, what were the other fontsize mismatch problems? The

Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-13 Thread dak
On 2018/08/13 12:29:46, Dan Eble wrote: On 2018/08/13 07:11:38, dak wrote: > I'd use scm_func_cast (actual_func) I'll do that. > Any chance that an implementation via a double cast (with something like void * > in between) will work? Strictly speaking that's worse than casting from one

Re: Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-13 Thread nine . fierce . ballads
Reviewers: dak, Message: On 2018/08/13 07:11:38, dak wrote: I'd use scm_func_cast (actual_func) I'll do that. Any chance that an implementation via a double cast (with something like void * in between) will work? Strictly speaking that's worse than casting from one function pointer to

Issue 5324: \abs-fontsize and set-global-staff-size in books (issue 341450043 by torsten.haemme...@web.de)

2018-08-13 Thread dak
Does not help with the other problems we had with fontsize mismatches (out of multiple calls of set-global-staff-size), right? What would a correct solution look like? https://codereview.appspot.com/341450043/ ___ lilypond-devel mailing list

PATCHES - Countdown for August 13th

2018-08-13 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on 16th August. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5384 Various fixes to GUB: - update broken download links -

Selectively suppress -Wcast-function-type (issue 357770043 by nine.fierce.ball...@gmail.com)

2018-08-13 Thread dak
I'd use scm_func_cast (actual_func) in order to mimic what reinterpret_cast does, but the implementation looks awfully heavy-handed and GCC-8 specific. Any chance that an implementation via a double cast (with something like void * in between) will work? Strictly speaking that's worse than