Re: guilev2 problem (user-markup-command sometimes not accepted)

2018-11-11 Thread David Kastrup
David Kastrup writes: > Thomas Morley writes: > >> Hi, >> >> the following works fine with current master (and every tested lily-version): >> #(begin >> (define-markup-command (dummy layout props arg) (markup?) >>(interpret-markup layout props arg)) >> (display-scheme-music (markup

Re: guilev2 problem (user-markup-command sometimes not accepted)

2018-11-11 Thread David Kastrup
Thomas Morley writes: > Hi, > > the following works fine with current master (and every tested lily-version): > #(begin > (define-markup-command (dummy layout props arg) (markup?) >(interpret-markup layout props arg)) > (display-scheme-music (markup #:dummy "foo"))) > #(display "whatever")

guilev2 problem (user-markup-command sometimes not accepted)

2018-11-11 Thread Thomas Morley
Hi, the following works fine with current master (and every tested lily-version): #(begin (define-markup-command (dummy layout props arg) (markup?) (interpret-markup layout props arg)) (display-scheme-music (markup #:dummy "foo"))) #(display "whatever") With guilev2 I get: $

Re: 2.20 plans.

2018-11-11 Thread Thomas Morley
Am So., 11. Nov. 2018 um 16:37 Uhr schrieb Phil Holmes : > > I've just set up a new user on my build machine and tried to build GUB. > make bootstrap was fine (except missing xelatex which I installed). Make > lilypond fell over when trying to make guile: > > building package: tools::guile > ***

git cl 404 error

2018-11-11 Thread Thomas Morley
Hi, trying to upload a revised patch-set for Issue 5437 via $ git cl upload origin/master I get a 404 error Full terminal-output: $ git cl upload origin/master scm/markup.scm | 66 +- 1 file changed, 41 insertions(+), 25

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread thomasmorley65
Hi Paul, thanks for review https://codereview.appspot.com/34743/diff/40001/scm/markup.scm File scm/markup.scm (right): https://codereview.appspot.com/34743/diff/40001/scm/markup.scm#newcode141 scm/markup.scm:141: ;; The string is split at line-breaks, emty strings removed and finally

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread thomasmorley65
On 2018/11/11 15:08:57, thomasmorley651 wrote: simplify, catch string-markups patch-set 3 reflects my musing in comment #5 https://codereview.appspot.com/34743/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread paulwmorris
Hi Harm, I took a quick look and it LGTM at a quick read. I have a couple nit-level suggestions. -Paul https://codereview.appspot.com/34743/diff/40001/scm/markup.scm File scm/markup.scm (right): https://codereview.appspot.com/34743/diff/40001/scm/markup.scm#newcode141

Re: 2.20 plans.

2018-11-11 Thread Phil Holmes
I've just set up a new user on my build machine and tried to build GUB. make bootstrap was fine (except missing xelatex which I installed). Make lilypond fell over when trying to make guile: building package: tools::guile *** Stage: download (guile, tools) *** Stage: untar (guile, tools) ***

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread thomasmorley65
On 2018/11/11 11:07:35, dak wrote: On 2018/11/11 10:57:31, thomasmorley651 wrote: > 'all-relevant-markup-commands' tries to get all markup-(list-)commands where > 'markup->string' may return reasonable output. I have to get used to the thought of not having the monopoly on good ideas.

PATCHES - Countdown for Nov 11th

2018-11-11 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on 14th November, A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: No patches to Push at this time. Countdown:

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread dak
On 2018/11/11 10:57:31, thomasmorley651 wrote: On 2018/11/10 12:53:18, dak wrote: > I wonder whether it might be reasonable to just have all markup commands with a > last argument of markup? produce their last (recursively treated) argument as > default, and possibly all markup list commands

Re: Improve markup->string (issue 347000043 by thomasmorle...@gmail.com)

2018-11-11 Thread thomasmorley65
On 2018/11/10 12:53:18, dak wrote: I wonder whether it might be reasonable to just have all markup commands with a last argument of markup? produce their last (recursively treated) argument as default, and possibly all markup list commands with a last argument of markup-list? similarly