Re: add very short and Henze fermatas (issue 347080043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lilypond
Thanks for the review, I’ll use the correct indentation when pushing. https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122 mf/feta-scripts.mf:122: .. z6{up} On

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lemzwerg
The mf code looks fine, thanks! https://codereview.appspot.com/341560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: add very short and Henze fermatas (issue 347080043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lemzwerg
LGTM, thanks! https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf File mf/feta-scripts.mf (right): https://codereview.appspot.com/347080043/diff/1/mf/feta-scripts.mf#newcode122 mf/feta-scripts.mf:122: .. z6{up} Indentation https://codereview.appspot.com/347080043/

Re: add fermata markup commands (issue 344160043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lemzwerg
Hm … Would this apply to the already existing script commands \shortfermata etc.? Then we would need a convert-ly rule. Good question. I see arguments for both directions, i.e., whether to stay with the commands, or to remove them. https://codereview.appspot.com/344160043/

PATCHES - Countdown for March 3rd

2019-03-03 Thread James Lowe
Hello, Here is the current patch countdown list. The next countdown will be on March 6th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5477 Broken links in website pages - john-mandereau

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread David Kastrup
lilyp...@maltemeyn.de writes: > On 2019/03/03 12:20:41, dak wrote: >> More like >>str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', > str) > >> Sort of ironic to use raw strings here for the sake of easier >> backslash-quoting and then not even backslash-quote the necessary

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lilypond
On 2019/03/03 12:20:41, dak wrote: More like str = re.sub (r'"scripts\.trilelement"', r'"scripts\.trillelement"', str) Sort of ironic to use raw strings here for the sake of easier backslash-quoting and then not even backslash-quote the necessary parts. I don’t know anything about python

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread David Kastrup
lilyp...@maltemeyn.de writes: > On 2019/03/03 09:37:01, thomasmorley651 wrote: >> Thanks for correcting the imho wrong spelling of "trilelement". >> Please add a conversion rule for it. Sometimes I used "trilelement" > and maybe >> I'm not the only one. > > Is it as easy as adding > > str =

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lilypond
On 2019/03/03 09:37:01, thomasmorley651 wrote: Thanks for correcting the imho wrong spelling of "trilelement". Please add a conversion rule for it. Sometimes I used "trilelement" and maybe I'm not the only one. Is it as easy as adding str = re.sub (r'"scripts.trilelement"',

Issue 5490: fix for wrong clefs.varC_change (issue 361800043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lilypond
Reviewers: , Message: To see the difference between 2.19.82, master and the proposed fix, try \markup \box \musicglyph #"clefs.varC" \markup \box \musicglyph #"clefs.varC_change" Description: Issue 5490: fix for wrong clefs.varC_change For solving Issue 5278 I changed the bounding box of the

Re: Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread thomasmorley65
Thanks for correcting the imho wrong spelling of "trilelement". Please add a conversion rule for it. Sometimes I used "trilelement" and maybe I'm not the only one. https://codereview.appspot.com/341560043/ ___ lilypond-devel mailing list

Issue 5489: improve prall glyphs (issue 341560043 by lilyp...@maltemeyn.de)

2019-03-03 Thread lilypond
Reviewers: , https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf File mf/feta-trills.mf (right): https://codereview.appspot.com/341560043/diff/1/mf/feta-trills.mf#newcode265 mf/feta-trills.mf:265: .. tension 0.95 I’ll fix this indentation error before pushing, I don’t think this