Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-01 Thread Carl . D . Sorensen
On 2018/11/10 05:44:23, pwm wrote: https://codereview.appspot.com/337870043/diff/40001/Documentation/notation/chords.itely#newcode679 Documentation/notation/chords.itely:679: represent the structure of the chord. When entered in node mode, typo: "note mode" Done.

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-01 Thread Carl . D . Sorensen
On 2018/11/10 19:44:47, pwm wrote: Hi Charles, Today I built and ran 'make check' with your patch applied to current master. I was able to get it to pass 'make check' by making the following two changes. 1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`. 2. In that

Re: NR: Add many function index entries. (issue 564590043 by lemzw...@googlemail.com)

2019-04-01 Thread lemzwerg
Reviewers: Valentin Villenave, Message: \addInstrumentDefinition is deprecated; see commit a7c014b60702e96bbc376892249b495bc10b8662. I've just removed the last documentation remnants. Description: NR: Add many function index entries. Also clean up some minor typos. Also add minor

Documentation: no \layout in markup-nested scores (issue 548590043 by v.villen...@gmail.com)

2019-04-01 Thread lemzwerg
LGTM https://codereview.appspot.com/548590043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: GSoC in contemporary notations

2019-04-01 Thread Tsz Kiu Pang
On Mon, 1 Apr 2019 at 18:04, Urs Liska wrote: > This is directed at the other devs, to (please) join the conversation > Am 01.04.19 um 08:30 schrieb Tsz Kiu Pang: > > I just have some concerns. >> Sorry I might have overestimated myself in the past week, but I realised >> I might not be able to

NR: Add many function index entries. (issue 564590043 by lemzw...@googlemail.com)

2019-04-01 Thread v . villenave
Hi Werner, that’s a very nice patch done in a quite methodical way. I just have a question: https://codereview.appspot.com/564590043/diff/546570043/Documentation/notation/staff.itely File Documentation/notation/staff.itely (left):

Re: GSoC in contemporary notations

2019-04-01 Thread Urs Liska
This is directed at the other devs, to (please) join the conversation Am 01.04.19 um 08:30 schrieb Tsz Kiu Pang: I just have some concerns. Sorry I might have overestimated myself in the past week, but I realised I might not be able to commit for 30+ hours per week during May

Re: GSoC in contemporary notations

2019-04-01 Thread Tsz Kiu Pang
Hi Urs, Thank you for your kind advice. On Fri, 29 Mar 2019 at 00:03, Urs Liska wrote: > Hi Tsz Kiu, > > I don't know if you intentionally replied personally instead of to the > list, and in general as much communication as possible should be kept > public. But since the nature of what you're