Re: What is holding up 2.20 release?

2019-12-17 Thread Jonas Hahnfeld via Discussions on LilyPond development
Answering to myself: Am Dienstag, den 17.12.2019, 19:58 +0100 schrieb Jonas Hahnfeld: > Am Samstag, den 16.11.2019, 21:52 +0100 schrieb David Kastrup: > > a77f387207 Fix musicxml2ly.py / Python 2.4.5 incompatibility > > I think it would be good to take this, but it requires > 78225bc1b3 Chord

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by nine.fierce.ball...@gmail.com)

2019-12-17 Thread rietveldpkx
This patch passes make, make check and a full make doc. diffs as follows Dan's suggested Patch - https://codereview.appspot.com/547340043 Dan's Patch #1: https://cloud-u8zj2dc4b.yourownnet.eu/s/JxCkPH4NKsGDkbg Dan's Patch #3: https://cloud-u8zj2dc4b.yourownnet.eu/s/QXJB753MRD8xNnk Dan's Patch

Re: What is holding up 2.20 release?

2019-12-17 Thread Dan Eble
On Dec 17, 2019, at 13:58, Jonas Hahnfeld wrote: > I would also propose to pick the following, more recent commits: > […] > 86de0f8f38 Use a stable sort when ordering MIDI items > 152a281031 Issue 5217: Fix sorting order without outside-staff-priority Pretty please, pick these. I support not

Re: What is holding up 2.20 release?

2019-12-17 Thread Malte Meyn
Am 17.12.19 um 19:58 schrieb Jonas Hahnfeld: 3300acdd8d Issue 5532/1: \ottava doesn’t confuse ambitus 04a0052411 Issue 5532/2: add regtest I think this is a fix for a1bde20430 Issue 2575/1: Ambitus respects staffLineLayoutFunction not yet in stable/2.20? Not really. It fixes a bug I

Re: What is holding up 2.20 release?

2019-12-17 Thread Jonas Hahnfeld
Am Samstag, den 16.11.2019, 21:52 +0100 schrieb David Kastrup: > Carl Sorensen < > c_soren...@byu.edu > > writes: > > > Dear Team, > > > > It seems to me like we are pretty much in shape such that we should > > release 2.20. I'd be fine if we called 2.19.83-1 the 2.20 release, > > even if there

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by nine.fierce.ball...@gmail.com)

2019-12-17 Thread dak
On 2019/12/17 17:57:52, Dan Eble wrote: This is ready for a full review now. I don't think any new test cases are required. I haven't looked very deeply into the potential use of an unpure-pure container. It looks like unpure-pure containers are used for vertical placement, They are

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by nine.fierce.ball...@gmail.com)

2019-12-17 Thread nine . fierce . ballads
This is ready for a full review now. I don't think any new test cases are required. I haven't looked very deeply into the potential use of an unpure-pure container. It looks like unpure-pure containers are used for vertical placement, and this is horizontal. If that answer is not

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by nine.fierce.ball...@gmail.com)

2019-12-17 Thread nine . fierce . ballads
let MAKE_SCHEME_CALLBACK... handle overloading This change lets me use both of these functions in Break_alignable_interface: SCM find_parent (SCM); Grob* find_parent (Grob*); An alternative is to mangle one of the names manually, e.g. internal_find_parent. clean up names, division

Re: Problems building current stable/2.20 - new python.h requirements (?)

2019-12-17 Thread Jonas Hahnfeld
Am Dienstag, den 17.12.2019, 14:06 +0100 schrieb Jonas Hahnfeld: > Am Dienstag, den 17.12.2019, 12:29 + schrieb > pkx1...@posteo.net > : > > Hello, > > > > If I checkout current stable/2.20 and then try to build LilyPond I fail > > during the 'configure' check with this > > > > --snip-- >

Re: Problems building current stable/2.20 - new python.h requirements (?)

2019-12-17 Thread Jonas Hahnfeld
Am Dienstag, den 17.12.2019, 12:29 + schrieb pkx1...@posteo.net: > Hello, > > If I checkout current stable/2.20 and then try to build LilyPond I fail > during the 'configure' check with this > > --snip-- > > ... > > config.status: creating config.make > config.status: creating config.hh >

Problems building current stable/2.20 - new python.h requirements (?)

2019-12-17 Thread pkx166h
Hello, If I checkout current stable/2.20 and then try to build LilyPond I fail during the 'configure' check with this --snip-- ... config.status: creating config.make config.status: creating config.hh ERROR: Please install required programs:  Python.h (python-devel, python-dev or

Re: Perception of LilyPond development status

2019-12-17 Thread David Kastrup
Jacques Menu writes: > Hello David, > > Maybe this is totally stupid, but would it be meaningful to pick a > Guile 2 version, fix the issues in string > implementation and design, and freeze that fixed version for Lily’s > own use, without depending on Andy Wingo’s work for some time? By the

Re: Perception of LilyPond development status

2019-12-17 Thread David Kastrup
Jacques Menu writes: > Hello David, > > Maybe this is totally stupid, but would it be meaningful to pick a > Guile 2 version, fix the issues in string > implementation and design, and freeze that fixed version for Lily’s > own use, without depending on Andy Wingo’s work for some time? That

Re: Perception of LilyPond development status

2019-12-17 Thread Jacques Menu
Hello David, Maybe this is totally stupid, but would it be meaningful to pick a Guile 2 version, fix the issues in string implementation and design, and freeze that fixed version for Lily’s own use, without depending on Andy Wingo’s work for some time? JM > Le 14 déc. 2019 à 22:58, David

Re: Issue 5621: Improve rehearsal mark position at beginning of staff (issue 547340043 by nine.fierce.ball...@gmail.com)

2019-12-17 Thread rietveldpkx
This patch passes make, make check and a full make doc. Dan's 17th Dec (2nd) patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/QXJB753MRD8xNnk older: Dan's 15th Dec (1st) patch's reg test diffs are here: https://cloud-u8zj2dc4b.yourownnet.eu/s/JxCkPH4NKsGDkbg Werner's

Re: Introduce breakingRehearsalMarks for line-breaking RehearsalMarks (issue 577180043 by thomasmorle...@gmail.com)

2019-12-17 Thread thomasmorley65
Dan, I've set it to needs_work for now. https://codereview.appspot.com/577180043/

PATCHES - Countdown for December 17th

2019-12-17 Thread pkx166h
Hello, Here is the current patch countdown list. The next countdown will be on December 19th. A quick synopsis of all patches currently in the review process can be found here: http://philholmes.net/lilypond/allura/ Push: 5637 Port lilysong to subprocess module - Jonas