Re: python error running make doc

Il giorno sab 11 apr 2020 alle 14:44, Jonas Hahnfeld ha scritto: This is odd, this "syntax" works fine for Python 3. However I see the mentioned error when pasting the line into Python 2. Could you double- check that your build indeed uses Python 3 (as is required for master)? I have python3

Re: Shortcut Rational addition if either operand is zero (issue 551690046 by hanw...@gmail.com)

https://codereview.appspot.com/551690046/diff/573690043/flower/rational.cc File flower/rational.cc (right): https://codereview.appspot.com/551690046/diff/573690043/flower/rational.cc#newcode257 flower/rational.cc:257: if (is_infinity ()) On 2020/04/12 16:55:05, Dan Eble wrote: > The hazard of

Reduce number of calls to Bezier::dir_at_point by 2x (issue 583750044 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/583750044/

Re: Shortcut Rational addition if either operand is zero (issue 551690046 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/551690046/diff/573690043/flower/rational.cc File flower/rational.cc (right): https://codereview.appspot.com/551690046/diff/573690043/flower/rational.cc#newcode257 flower/rational.cc:257: if (is_infinity ()) The hazard of reviewing this class is that there's

Re: What's up with the broken web pages?

I simply remove the output directory. I think we should do this always, because the full build is cheap, and the incremental build looks iffy. On Sun, Apr 12, 2020 at 4:50 PM Phil Holmes wrote: > > I've updated the scripts on the website, but it looks like make website is > not sensitive to a

Re: What's up with the broken web pages?

There you go. Fixed :-) -- Phil Holmes - Original Message - From: "Jonas Hahnfeld" To: "Phil Holmes" ; "Han-Wen Nienhuys" ; "David Kastrup" Cc: "lilypond-devel" Sent: Sunday, April 12, 2020 3:57 PM Subject: Re: What's up with the broken web pages?

Re: What's up with the broken web pages?

Am Sonntag, den 12.04.2020, 15:50 +0100 schrieb Phil Holmes: > I've updated the scripts on the website, but it looks like make website is > not sensitive to a changed Python file and so does not rebuild the web > pages. A possibility to force a rebuild would be to touch VERSION, but that >

Re: What's up with the broken web pages?

I've updated the scripts on the website, but it looks like make website is not sensitive to a changed Python file and so does not rebuild the web pages. A possibility to force a rebuild would be to touch VERSION, but that would make the website out of step with master. -- Phil Holmes -

Re: What's up with the broken web pages?

Joram Noeck writes: > Definitely a python2/3 issue. While python2 uses byte strings by > default, strings are Unicode strings in python3 and byte strings need to > be decoded first. > > Surely, you know that Uh, no? While I certainly am a natural at embodying a know-it-all, my expertise is not

Re: weblinks: Fix encoding of link texts (issue 563860043 by jonas.hahnf...@gmail.com)

Reviewers: hanwenn, Message: On 2020/04/12 12:36:22, hanwenn wrote: > LGTM > > shortcut push? I can update the scripts afterwards. commit 23dbc2090b1f45ae26c7f88af6945bde00cb2ddd Author: Jonas Hahnfeld Date: Sun Apr 12 14:11:37 2020 +0200 weblinks: Fix encoding of link texts in

Shortcut Rational addition if either operand is zero (issue 551690046 by hanw...@gmail.com)

LGTM. Maybe you can add a comment w.r.t. speed improvement. https://codereview.appspot.com/551690046/

weblinks: Fix encoding of link texts (issue 563860043 by jonas.hahnf...@gmail.com)

LGTM shortcut push? I can update the scripts afterwards. https://codereview.appspot.com/563860043/

Re: What's up with the broken web pages?

Apparently it's also broken in a local 'make doc'. I think I chose the wrong strategy to fix the build with Python 3.5, see https://codereview.appspot.com/563860043 for a proposed fix. As far as I understand, the website build of lilypond.org doesn't use the scripts from git directly, but

Re: Use python3 in website.make (issue 581880043 by hanw...@gmail.com)

On 2020/04/12 11:46:47, lemzwerg wrote: > Maybe this can be short-tracked to quickly get rid of the faulty webpage? This already is in master, see the commit Han-Wen noted above. The problem is somewhere else, and I think I know how to solve it (correctly)...

Re: Use python3 in website.make (issue 581880043 by hanw...@gmail.com)

Maybe this can be short-tracked to quickly get rid of the faulty webpage? https://codereview.appspot.com/581880043/

Re: Simplify mf-to-table (issue 549840043 by hanw...@gmail.com)

LGTM (without testing) https://codereview.appspot.com/549840043/

slur-configuration: fix size_t conversion warning (issue 545860043 by hanw...@gmail.com)

LGTM https://codereview.appspot.com/545860043/

Re: Define Scheme markups using define-public (issue 577720043 by hanw...@gmail.com)

On 2020/04/12 10:59:21, hanwenn wrote: > On 2020/03/30 12:20:17, dak wrote: > > > > Ugly and a maintenance burden since the code is used twice. Anything > > > > wrong with my proposal? > > > > > > I didn't understand your proposal. > > > > > > > It does not have duplicate code, makes > > > >

Re: Reimplement Scheme_hash_table using linear probing. (issue 559790043 by hanw...@gmail.com)

this should probably not be merged, given the inability to demonstrate speed savings. But I'm uploading the latest version to not leave bugs in the public record. https://codereview.appspot.com/559790043/

Re: Define Scheme markups using define-public (issue 577720043 by hanw...@gmail.com)

On 2020/03/30 12:20:17, dak wrote: > > > Ugly and a maintenance burden since the code is used twice. Anything > > > wrong with my proposal? > > > > I didn't understand your proposal. > > > > > It does not have duplicate code, makes > > > define-markup-command compilable (while requiring its

Re: scripts/build/scan-mf-deps: script to generate MF dependencies (issue 553700043 by hanw...@gmail.com)

commit c2eb8beac769a1bf30de357781601322d70095a6 Author: Han-Wen Nienhuys Date: Sun Mar 15 22:35:28 2020 +0100 mf/GNUmakefile: move logic to scripts This simplifies the build, and removes some GNU Make specific idioms. * The mf2pt invocation is intricate. Use a shell

Re: Refactor get/set_property to take the item as first argument (issue 573670043 by d...@gnu.org)

On 2020/04/12 10:35:24, hanwenn wrote: > On Sat, Apr 11, 2020 at 3:55 PM David Kastrup wrote: > > >> You haven't understood the scheme. A grob only contains the properties > > >> seminal to its type. That's why there is a double indirection. A full > > >> array of 416

Re: Remove input/regression/test-output-distance.ly (issue 575850043 by hanw...@gmail.com)

commit 8a74a0eb329d17154499441396e15811dca1e639 Author: Han-Wen Nienhuys Date: Fri Mar 20 13:28:03 2020 +0100 Remove input/regression/test-output-distance.ly The self-test for the output-distance.py script fulfills the same role in a more automated fashion.

Use python3 in website.make (issue 581880043 by hanw...@gmail.com)

Reviewers: , Message: commit a17fd9412aa927203ea2cbdda01dd37b03178796 Author: Han-Wen Nienhuys Date: Tue Mar 24 21:19:26 2020 +0100 Use python3 in website.make https://sourceforge.net/p/testlilyissues/issues/5863 http://codereview.appspot.com/581880043 Description: Use

Re: Simplify mf-to-table (issue 549840043 by hanw...@gmail.com)

updated description https://codereview.appspot.com/549840043/

Re: Simplify mf-to-table (issue 549840043 by hanw...@gmail.com)

https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py File scripts/build/mf-to-table.py (right): https://codereview.appspot.com/549840043/diff/553830043/scripts/build/mf-to-table.py#newcode22 scripts/build/mf-to-table.py:22: import getopt On 2020/04/11 16:12:52,

Re: What's up with the broken web pages?

Definitely a python2/3 issue. While python2 uses byte strings by default, strings are Unicode strings in python3 and byte strings need to be decoded first. Surely, you know that and the question is: which part of the website creation is not fully ported to python3. python2 [2.7.17] >>> 'abc',

Re: What's up with the broken web pages?

If you build the website locally, does it not have the 'b' all over the place? On Sun, Apr 12, 2020 at 12:29 PM David Kastrup wrote: > > > We currently have web pages looking like > > > > > There are lots of text of the b'...' variety and obviously the

Re: Refactor get/set_property to take the item as first argument (issue 573670043 by d...@gnu.org)

On Sat, Apr 11, 2020 at 3:55 PM David Kastrup wrote: > >> You haven't understood the scheme. A grob only contains the properties > >> seminal to its type. That's why there is a double indirection. A full > >> array of 416 entries is needed per grob _type_, not per grob. > > > > I still don't