Re: volunteers for commit-finding for a regression

2011-01-14 Thread Neil Puttock
On 13 January 2011 18:56, Graham Percival gra...@percival-music.ca wrote: Are there any other know regressions that aren't on the tracker? There's the memory problem reported here, http://lists.gnu.org/archive/html/lilypond-devel/2011-01/msg00184.html which seems to be affecting larger

Re: why chords with notes of different duration is not supported?

2011-01-14 Thread Neil Puttock
On 14 January 2011 21:04, David Kastrup d...@gnu.org wrote: No comment this time round, either. Sometimes I am inclined to just commit and be done.  After all, this would just omit a warning in working cases, and would fix the totally broken warning message when breves and longas get into

Re: volunteers for commit-finding for a regression

2011-01-14 Thread Neil Puttock
On 14 January 2011 21:55, Graham Percival gra...@percival-music.ca wrote: I thought that was a problem related to the mensural patch? So did I, but Pál reported crashes on larger scores unrelated to that patch. The mensural patch works fine with 2.13.44, so there's definitely something nasty

Re: volunteers for commit-finding for a regression

2011-01-14 Thread Neil Puttock
On 14 January 2011 22:06, Neil Puttock n.putt...@gmail.com wrote: So did I, but Pál reported crashes on larger scores unrelated to that patch. I've just confirmed the same crash on Valentin's opera. Cheers, Neil ___ lilypond-devel mailing list

Re: CueVoice issue fixed

2011-01-11 Thread Neil Puttock
On 9 January 2011 19:48, Mike Solomon mike...@ufl.edu wrote: The patch set now fixes Issue 400 as well.  It also fixes an unreported issue of time signature collisions. Any chance of making the clef avoidance automatic? I'm not too concerned about automating the time signature case since it

Re: OK test results for issue 37 patches

2011-01-09 Thread Neil Puttock
On 9 January 2011 02:21, Mike Solomon mike...@ufl.edu wrote: Yeehaw! Hmm, they look a bit fishy to me. A sure sign is if you're missing a comparison for test-output-distance.ly, since that should always change. This looks nasty: -spacing-knee.ly:17:8: warning: weird stem size, check for

Re: Correct convert-ly of page spacing (issue3793046)

2011-01-08 Thread Neil Puttock
On 8 January 2011 05:47, percival.music...@gmail.com wrote: Looks fine, although I haven't actually tested it, but since it's not in the core program I'm less concerned.  Could you email me the git patch and I'll push it? Do you mind holding fire until I've had chance to look at it? Cheers,

Re: Fixing issue 37 with extra position callback (issue3928041)

2011-01-08 Thread Neil Puttock
On 8 January 2011 19:48, Mike Solomon mike...@ufl.edu wrote: I ran all of the regtests and nothing breaks. This is not good enough. You *must* do a proper regression test comparison. Withough doing make check, I can already see it will fail since you haven't documented covering-note-heads in

Re: Correct convert-ly of page spacing (issue3793046)

2011-01-08 Thread Neil Puttock
On 8 January 2011 21:55, k-ohara5...@oco.net wrote: Testing might require a (trivial) merge with Carl's Change stringTunings ... commit. I have a merged patch but hesitate to upload because I haven't yet seen how Rietveld displays such patches.  If I get bold, but make a mess with Set 3,

Re: Potential fix for issue 37

2011-01-07 Thread Neil Puttock
On 7 January 2011 16:14, m...@apollinemike.com wrote: I'm not exactly sure what the desired output would be for issue 37, but my code assumes that if there are collision problems, flat beams look best. Lemme know what you think! Looks interesting, though you need to do a regression test

Re: Black mensural notation

2011-01-07 Thread Neil Puttock
On 7 January 2011 02:50, Andrew Hawryluk ahawry...@gmail.com wrote: I tried running it on a current development snapshot this week, but it didn't have enough memory to run nicely and bogged down my computer with swap traffic (I've got 2 MB here). I gave up on it before it finished. Does it

Re: Black mensural notation

2011-01-07 Thread Neil Puttock
On 7 January 2011 18:40, James Lowe james.l...@datacore.com wrote: I ran it on Windows 2.13.44 (not 45 as I first said) and it took a few seconds to complile and roughly 150Mb. Windows 2.13.44 also works fine here, though I can't say the same for 2.13.45: Preprocessing graphical objects...

stringTunings documentation

2011-01-07 Thread Neil Puttock
Hi Carl, The docstring for stringTunings is incorrect following the changes you've made: The tablature strings tuning. It is a list of the pitch (in semitones) of each string (starting with the lower one. Cheers, Neil ___ lilypond-devel mailing list

Re: Black mensural notation

2011-01-07 Thread Neil Puttock
On 7 January 2011 20:33, Neil Puttock n.putt...@gmail.com wrote: On 7 January 2011 20:27, Benkő Pál benko@gmail.com wrote: it may be related to Joe's recent patch 777066 about page breaking. I can't compile my larger scores, it stops at the same message and memory usage goes to the skies

Re: [PATCH] Allow \markuplines to be assigned to a variable

2011-01-07 Thread Neil Puttock
On 4 January 2011 14:33, Reinhold Kainhofer reinh...@kainhofer.com wrote: mmm = \markup blah \markup \mmm     % works \mmm             % doesn't work This is a special case since \markup blah returns a string rather than a markup (using simple_string ()). It works if you wrap the string in

Re: issue 1464 (was: a plea to new contributors)

2011-01-02 Thread Neil Puttock
On 1 January 2011 13:10, Matthias Kilian k...@outback.escape.de wrote: It could be possible to check the result of get_column() in Item::spanned_rank_interval(), but I'm not sure wether this is the *proper* bug fix (nor what interval should be returned in this case). The issue is that the

Re: regression test checking

2010-12-19 Thread Neil Puttock
On 19 December 2010 13:50, Phil Holmes m...@philholmes.net wrote: Looks nonsense.  Think the description should be A staff should die if there is _no_ reference to it.. Definitely. The original test had the following description: a staff should really die, if no one's referencing it. And

Re: sorry about the missing regtests

2010-12-15 Thread Neil Puttock
On 14 December 2010 23:18, Carl Sorensen c_soren...@byu.edu wrote: On 12/14/10 4:15 PM, Graham Percival gra...@percival-music.ca wrote: I only just realized that I should have done   git add input/regression/*.ly after apply Neil's patches with patch -p1 foo.diff Sorry about that.

Re: Fix 1336 (issue3594041)

2010-12-11 Thread Neil Puttock
On 11 December 2010 17:40, carl.d.soren...@gmail.com wrote: Here's a patch for issue 1336 that combine's Neil's idea of not creating the paper columns with Graham's idea of erroring out when there are less than 2 columns. I think it would be better to create the missing column rather than

Re: Fix 1336 (issue3594041)

2010-12-11 Thread Neil Puttock
On 11 December 2010 20:38, Graham Percival gra...@percival-music.ca wrote: What about: \markup{foo} ?  how many paper columns does that create? None: toplevel markup doesn't create any grobs. Cheers, Neil ___ lilypond-devel mailing list

Re: [Pseudo-patch] Add support for HairpinText indications. (issue3509041)

2010-12-11 Thread Neil Puttock
On 8 December 2010 08:09, v.villen...@gmail.com wrote: [I should probably subscribe the codereview mail address to Frogs- and move the discussion there.] Sounds sensible to me. Thanks Neil! I've now tried to make a proper Spanner, which raises more questions of course (namely, how to

Re: Problems making doc after commit by Mark P

2010-12-07 Thread Neil Puttock
On 6 December 2010 17:58, Carl Sorensen c_soren...@byu.edu wrote: For clarification, the following patch may help: Nope, I was thinking more along the lines of the following, since it's the postscript definition of output-scale which needs changing: diff --git a/scm/framework-ps.scm

Re: Problems making doc after commit by Mark P

2010-12-06 Thread Neil Puttock
On 6 December 2010 09:26, Mark Polesky markpole...@yahoo.com wrote: Some of the error messages:  error: failed files: d7/lily-75221729.ly  error: Children (4 3 2 1 0) exited with errors.  [...]  Child returned 1  make[3]: *** [out-www/collated-files.texi] Error 1  rm

Re: Regtest comparison for 2.13.41

2010-12-04 Thread Neil Puttock
On 4 December 2010 15:58, Phil Holmes m...@philholmes.net wrote: stem-length-estimation.log: there's much less text in the logfile - don't understand why, though. It's due to the addition of \book { } around the snippet (which ensures the page layout is preserved rather than relying on

Re: Add tab-tie-follow-engraver (issue2723043)

2010-12-04 Thread Neil Puttock
On 5 December 2010 00:35, Carl Sorensen c_soren...@byu.edu wrote: How's this?  To my eye it appears that the tab heads are centered on the regular notes now. I don't know, but they're consistently shifted to the right unless there are double-digit notes present. Cheers, Neil attachment:

Re: volleyball issue 1336

2010-12-01 Thread Neil Puttock
On 30 November 2010 11:24, Graham Percival gra...@percival-music.ca wrote: There is a theory about why this happens, from Neil: It looks to me like the MultiMeasureRest has invalid bounds when cloned, so the cloned object is NULL when the MultiMeasureRestNumber is aligned (the parent object

Re: Git history, Savannah

2010-12-01 Thread Neil Puttock
On 1 December 2010 10:00, Valentin Villenave valen...@villenave.net wrote: I've now pushed my master branch (with one additional commit wrt the tempo-range feature that Neil will now dismember in order to rebase his own patch :-) Please let me know if I should also push my translations

Re: GUB target_cpu error

2010-11-28 Thread Neil Puttock
___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel From d6ae7303cdb00839d63a1f347cdbb7f8b8e3f229 Mon Sep 17 00:00:00 2001 From: Neil Puttock n.putt...@gmail.com Date: Sun, 28 Nov 2010 20:50:55 + Subject: [PATCH] Fix

Re: Where to change the begin of a broken spanner after a line break?

2010-11-26 Thread Neil Puttock
On 26 November 2010 20:22, Reinhold Kainhofer reinh...@kainhofer.com wrote: BTW, the same problem also happens with ottava brackets, volta brackets, etc. but NOT with text cresc spanners, trill spanners, normal text spanners or tuplet brackets. DynamicTextSpanner uses the

Re: 2.13.40 regtests

2010-11-25 Thread Neil Puttock
On 25 November 2010 17:45, Phil Holmes m...@philholmes.net wrote: It wouldn't take me long to write a C# program (less than a day, I'd guess) that reproduced quite a lot of the regtest checker functionality and did a pixel-by-pixel check for image changes.  I've done the latter bit in about

Re: 2.13.40 regtests

2010-11-25 Thread Neil Puttock
On 26 November 2010 00:00, Graham Percival gra...@percival-music.ca wrote: Hmm.  It shouldn't take a huge amount of time to compare each pair of regtest images -- they're named, so you'd be comparing something like 500 pairs of .png images.  (Neil: were you thinking of something else?) I

Re: 2.13.40 regtests

2010-11-24 Thread Neil Puttock
On 24 November 2010 15:47, Phil Holmes m...@philholmes.net wrote: So if a completely new bit of graphics appears, the regtest checker wouldn't spot it?  Not sure that's too good. It might not, depending on whether the new grob influences bounding boxes for other grobs. What's the checker

Re: [Patch:] Tablature: provide custom fret labels

2010-11-24 Thread Neil Puttock
On 24 November 2010 07:40, Marc Hohl m...@hohlart.de wrote: I attached a patch to remove the unnecessary markup definition. Thanks, applied. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

[PATCH] Fix #1427 (segfault with \markup inside \book(part) identifier)

2010-11-24 Thread Neil Puttock
Hi everybody, Please review this patch: http://codereview.appspot.com/3319041 Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: 2.13.40 regtests

2010-11-23 Thread Neil Puttock
On 21 November 2010 23:16, Graham Percival gra...@percival-music.ca wrote: Huh.  So evidently there's some other reason behind the fix for this break not being detected?  It might be related to the imagemagick's syntax change: http://code.google.com/p/lilypond/issues/detail?id=908 I don't

Re: [Patch:] Tablature: provide custom fret labels

2010-11-23 Thread Neil Puttock
On 23 November 2010 23:30, Carl Sorensen c_soren...@byu.edu wrote: Pushed, thanks. I'm sorry I'm a bit late, but this +(define-markup-command (customFretLabel +layout props fret-label) (string?) seems unncessary; it's just an inferior version of vcenter.

Re: Simplification of live-elements-list, why not?

2010-11-16 Thread Neil Puttock
On 15 November 2010 07:07, Boris Shingarov b...@shingarov.com wrote: The reason I am asking, is because even after spending 10 minutes looking at the procedural-style code in the current live-elements-list, I am still not sure what the answer is to the question, what does this function do? 

Re: Simplification of live-elements-list, why not?

2010-11-16 Thread Neil Puttock
On 16 November 2010 00:37, Han-Wen Nienhuys hanw...@gmail.com wrote: I had a brief look, and it looks like 4b7d9566 by Neil is to blame. I'm not sure what I'm guilty of here; in the absence of an exported function which turns grob-arrays into lists (which I did contemplate adding at the time),

Re: locations of interface descriptions

2010-11-12 Thread Neil Puttock
On 12 November 2010 17:03, Mark Polesky markpole...@yahoo.com wrote: I see that interfaces come to the IR from at least three different types of places: 1) lily/[grobname].cc              (e.g. accidental) 2) lily/[grobname]-interface.cc    (e.g. align) 3) scm/define-grob-interfaces.scm  

Re: Add tab-tie-follow-engraver (issue2723043)

2010-11-03 Thread Neil Puttock
On 3 November 2010 16:15, Marc Hohl m...@hohlart.de wrote: Am 03.11.2010 15:10, schrieb Carl Sorensen: On 11/3/10 6:50 AM, Marc Hohlm...@hohlart.de  wrote: Am 02.11.2010 04:04, schrieb carl.d.soren...@gmail.com: Updated to only acknowledge tab-note-head, not note-head. Makes perfect

Re: Add tab-tie-follow-engraver (issue2723043)

2010-11-03 Thread Neil Puttock
On 3 November 2010 19:33, Carl Sorensen c_soren...@byu.edu wrote: But the tie callback *should* make the notehead transparent if there's no slur or gliss (or bend, in the future).  In the absence of slur, gliss, or split tie the notehead is transparent.  In the presence of one of these, it's

Re: (tuplet . around) causes regtests to fail to compile

2010-11-03 Thread Neil Puttock
On 2 November 2010 07:41, Werner LEMBERG w...@gnu.org wrote: Have you meanwhile found some time to ponder?  I'm quite curious... Yes. :) Here's the short answer: chain_callback () returns SCM_UNDEFINED if the property data being chained isn't a procedure or closure. (grob-closure.cc) 78

Re: lilymidi and lilysong

2010-10-30 Thread Neil Puttock
On 30 October 2010 13:05, Valentin Villenave valen...@villenave.net wrote: Do we still want to ship the lilysong and lilymidi scripts? I'm not sure if these still work, and there's hardly any documentation whatsoever. They both worked when I tested them last month (following the instructions

Re: (tuplet . around) causes regtests to fail to compile

2010-10-30 Thread Neil Puttock
On 30 October 2010 08:39, Werner LEMBERG w...@gnu.org wrote: Would it be sufficient to handle SCM_UNDEFINED in type_check_assignment? I don't think so. Unlike SCM_EOL or SCM_BOOL_F it doesn't have an analogue in Scheme code. Or is there a deeper problem? I think so. Perhaps there's a

Re: lilymidi and lilysong

2010-10-30 Thread Neil Puttock
On 30 October 2010 13:44, Valentin Villenave valen...@villenave.net wrote: Neil: sorry, I have searched the -devel archives but not -user :-) However, if these do work (which I'm glad they do btw!), then it would be nice to have them mentioned somewhere in the docs... And, perhaps, make the

Re: (tuplet . around) causes regtests to fail to compile

2010-10-30 Thread Neil Puttock
On 30 October 2010 15:48, Werner LEMBERG w...@gnu.org wrote: OK.  To debug this is beyond my capabilities, sorry.  Hopefully, I find time to dive into lilypond's Scheme details, but currently I have no time to do that; right now I'm pretending to be Joe User. No problem. I've done a bit more

Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)

2010-10-30 Thread Neil Puttock
On 30 October 2010 22:40, Marc Hohl m...@hohlart.de wrote:  File /home/marc/git/lilypond/python/out/book_snippets.py, line 561, in compose_ly    if self.global_options.safe_mode: AttributeError: Values instance has no attribute 'safe_mode' I don't think this has anything to do with your

Re: (tuplet . around) causes regtests to fail to compile

2010-10-29 Thread Neil Puttock
On 29 October 2010 09:18, Werner LEMBERG w...@gnu.org wrote: in file lily-guile.cc; for the above lilypond call it gets passed a value of 0x204 for `val'.[1] This is obviously a special constant, however, I haven't found out what guile symbol this corresponds to due to the extremely cryptic

Re: Tablature: proper support for tie/slur- and tie/glissando-constellations (issue2191042)

2010-10-29 Thread Neil Puttock
On 28 October 2010 23:55, Carl Sorensen c_soren...@byu.edu wrote: Well, as far as I can see, Scheme engravers are really engravers, so they ought to be documented in the IR along with the C++ engravers, not in an appendix of the NR along with Scheme functions. Although the approach you

Re: problematic commit 02fe038744e634b42f1a3377c4f0dc3d25e80344

2010-10-24 Thread Neil Puttock
On 24 October 2010 12:32, Valentin Villenave valen...@villenave.net wrote: On Sun, Oct 24, 2010 at 3:43 AM, Graham Percival Feel free to revert it. TBH, I'm sorely tempted to myself. There's a memory leak from `make-void-music', which suggests you haven't done a regression test check or run

Re: problematic commit 02fe038744e634b42f1a3377c4f0dc3d25e80344

2010-10-24 Thread Neil Puttock
On 24 October 2010 13:17, Valentin Villenave valen...@villenave.net wrote: On Sun, Oct 24, 2010 at 1:40 PM, Neil Puttock n.putt...@gmail.com wrote: On 24 October 2010 12:32, Valentin Villenave valen...@villenave.net wrote: Feel free to revert it. TBH, I'm sorely tempted to myself

[PATCH] Fix 888: Add ly:stencil-scale

2010-10-03 Thread Neil Puttock
HI everybody, This patch implements an exported function, ly:stencil-scale, which can be used to stretch/flip/mirror etc. stencils. Please review here: http://codereview.appspot.com/2275042/ Cheers, Neil attachment: stencil-scale.png___

Re: Passing the result of an ApplyOutputEvent to a music-function

2010-10-03 Thread Neil Puttock
On 28 September 2010 20:07, Valentin Villenave valen...@villenave.net wrote: I've asked this question on -user but I suspect it got lost in the flow. (Besides, it *might* belong on -devel since I'm actually trying to implement a missing feature, see for instance

Re: Regression test analysis - 2.13.35

2010-10-03 Thread Neil Puttock
On 30 September 2010 09:57, Phil Holmes m...@philholmes.net wrote: 1) In harp-pedals-sanity-checks.ly we get: +warning: Harp pedal diagram contains dividers at positions (4). Normally, there is only one divider after the third pedal. +warning: Harp pedal diagram contains dividers at

Re: Regression test analysis - 2.13.35

2010-10-03 Thread Neil Puttock
On 4 October 2010 00:19, Carl Sorensen c_soren...@byu.edu wrote: Is it a bug, or just different ordering of the output?  The warnings are proper, aren't they? Can't we just say the warnings have reversed order, so that the changes in the regtest output can be ignored? I think users will

Re: Regression test analysis - 2.13.35

2010-10-03 Thread Neil Puttock
On 4 October 2010 00:46, Carl Sorensen c_soren...@byu.edu wrote: I agree that it would be better to have warning messages show up in parsing order, rather than translation order.  But if the error occurs in translation, there's no way to make the warning messages show up in parsing order,

Re: MetronomeMark #'break-align-symbols sometimes fails

2010-09-26 Thread Neil Puttock
On 26 September 2010 12:09, Xavier Scheuer x.sche...@gmail.com wrote: MetronomeMark #'break-align-symbols seems to fail with everything (clef, left-edge, staff-bar, ...) except key-signature and time-signature I'm afraid this is partly due to the way I fixed the bad alignment when key

Re: Help understanding how code works (or doesn't)

2010-09-18 Thread Neil Puttock
On 18 September 2010 20:38, Carl Sorensen c_soren...@byu.edu wrote: How would one go about trying to verify this with the debugger? You could try following the ApplyContext path, to check it leads up to a set_property () call. TBH, I'm now not so sure what I said earlier is really happening:

Re: Help understanding how code works (or doesn't)

2010-09-16 Thread Neil Puttock
fe26d8b7ddce8fb00a072853d938e6a612a20979 Mon Sep 17 00:00:00 2001 From: Neil Puttock n.putt...@gmail.com Date: Thu, 16 Sep 2010 23:54:10 +0100 Subject: [PATCH] Possible fix for #372. --- lily/partial-iterator.cc | 27 +++ scm/define-music-types.scm |6 ++ scm/ly-syntax

Re: potential 2.14 alpha, website switch

2010-09-12 Thread Neil Puttock
On 12 September 2010 15:46, Graham Percival gra...@percival-music.ca wrote: Unless I hear otherwise in the next 18 hours, I'm going to declare 2.13.33 the first alpha release of 2.14, and invite users to try it out.  I'll also switch to the new website. Do you mind postponing it until 2.13.34?

Re: potential 2.14 alpha, website switch

2010-09-12 Thread Neil Puttock
On 12 September 2010 19:52, Graham Percival gra...@percival-music.ca wrote: No problem; done. Thanks. Since Carl's given the OK for #818, I'll push that later. Ok.  No rush; if anybody has anything else to say about 818, then by all means we can spend more time thinking/investigating it.

Does LaissezVibrerTie need a 'cross-staff callback?

2010-09-06 Thread Neil Puttock
'sHi everybody, I'm getting cyclic dependency problems with laissez vibrer ties attached to cross-staff notes which seems harmless in a minimal snippet, but more serious in a real music example. It appears to have been introduced following the fix for issue #881, which made the LaissezVibrerTie

Re: 13.32 regtests comparisons

2010-09-04 Thread Neil Puttock
On 4 September 2010 14:42, Phil Holmes m...@philholmes.net wrote: automatic-polyphony-drumstaff.ly: addition of 2 lines Unbound variable: open-file This has been happening for a while in different files, but only appears in the GUB build (I've never seen it in a local regtest comparison). The

Re: 13.32 regtests comparisons

2010-09-04 Thread Neil Puttock
On 4 September 2010 16:05, Phil Holmes m...@philholmes.net wrote: Graham Percival gra...@percival-music.ca wrote in message news:aanlktino+cusnqt1gx3k_rrpr81m7t0owwyxw9fp5...@mail.gmail.com... A number tests, but including metronome-parenthesized.ly : the initial markup (a tempo marking in

Re: 13.32 regtests comparisons

2010-09-04 Thread Neil Puttock
On 4 September 2010 16:35, Phil Holmes m...@philholmes.net wrote: Report these when I see them or ignore them? It's probably best just to note similar changes in the issue you've just added. Spotted this but didn't understand what it meant (other than it's splitting the words apart). TBH,

Re: backslash-newline in lily/include/staff-symbol-referencer.hh

2010-09-04 Thread Neil Puttock
On 4 September 2010 21:43, Graham Percival gra...@percival-music.ca wrote: If it's just a typo, could we remove it? Looks like Joe's finger slipped. :) Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: [Patch:] MultiMeasureRest markups in tablature

2010-09-02 Thread Neil Puttock
On 2 September 2010 12:53, Marc Hohl m...@hohlart.de wrote: Oh yes, of course ... Done. Thanks, LGTM. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: [Patch:] MultiMeasureRest markups in tablature

2010-09-01 Thread Neil Puttock
On 1 September 2010 16:36, Marc Hohl m...@hohlart.de wrote: I prepared a patch, see attachment; can somebody push it? \tabFullNotation ? Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Bug - point and click

2010-08-28 Thread Neil Puttock
On 28 August 2010 15:36, Wols Lists antli...@youngman.org.uk wrote: When you add chords using chordmode, clicking on the resulting chord in the pdf doesn't take you to the relevant place in the source file. In fact, it fails pretty badly ...

Re: Bug - point and click

2010-08-28 Thread Neil Puttock
On 28 August 2010 16:31, Wols Lists antli...@youngman.org.uk wrote:  On 28/08/10 16:17, Neil Puttock wrote: On 28 August 2010 15:36, Wols Lists antli...@youngman.org.uk wrote: When you add chords using chordmode, clicking on the resulting chord in the pdf doesn't take you to the relevant

Re: [frogs] chord-name-engraver plus capo - schemeing away ...

2010-08-27 Thread Neil Puttock
On 27 August 2010 21:49, Wols Lists antli...@youngman.org.uk wrote: There's a function called parenthesize in define-markup-commands.scm that looks like it does what I want (line 3154), but ly_lily_module_constant can't find it, and I don't know whether I've got the call to it in the line

Re: Regtest comparison issues for 2.13.31

2010-08-26 Thread Neil Puttock
On 26 August 2010 13:55, Phil Holmes m...@philholmes.net wrote: display-lily-tests.ly The following output is new to .31: Test 93 unequal: . in = \time 2/4 out = \context Score \context Timing \applyContext #make-time-settings Test 94 unequal: . in = #(set-time-signature 5 8 '(3 2)) out

Re: whitespace in lsr update (again)

2010-08-18 Thread Neil Puttock
On 18 August 2010 18:58, Graham Percival gra...@percival-music.ca wrote: I just tried to update LSR in git, but found a whole bunch of added whitespace above the  %% Translation line. You have to run a local update after doing a full one to strip the extra spaces (see issue 1115). I recall

Re: Reference checking py script [was Re: Suggestion for CG - make targets section]

2010-08-18 Thread Neil Puttock
On 18 August 2010 13:13, Trevor Daniels t.dani...@treda.co.uk wrote: I've done this now.  See scripts/auxiliar/ref_check.py. Its action is driven by scripts/auxiliar/ref_check.tely Just run it at the top level in the git repository to check (most of) the cross-references in the doc tree.

Re: Extra check in define-event-class patch

2010-08-18 Thread Neil Puttock
Hi Mike, Here are the comments I made copied from Rietveld: +#(ly:define-event-class 'scheme-text-span-event +'(scheme-text-span-event + span-event It would be great if the hierarchy could be completed automatically rather than having to specify

Re: Extra check in define-event-class patch

2010-08-18 Thread Neil Puttock
On 18 August 2010 23:12, Mike Solomon mike...@ufl.edu wrote: Should be good to go! ~Mike (issue 1867050) Thank, that seems to have fixed it. Cheers, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Extra check in define-event-class patch

2010-08-14 Thread Neil Puttock
On 13 August 2010 23:31, Neil Puttock n.putt...@gmail.com wrote: I'll see if it works tomorrow, otherwise I'll copy them here. Still no joy. It looks like the base file for the regtest didn't get uploaded properly (according to this bug report: http://code.google.com/p/rietveld/issues/detail

Re: Extra check in define-event-class patch

2010-08-13 Thread Neil Puttock
On 13 August 2010 09:12, Mike Solomon mike...@ufl.edu wrote: Done - thank you for the suggestion.  Attached is the patch series, which can also be found on http://codereview.appspot.com/1867050 .  Thank you! Looks good. I've added quite a few comments, but just got a sever error trying to

Re: [PATCH] Adds ly:engraver-property to engraver-scheme.cc

2010-08-05 Thread Neil Puttock
On 5 August 2010 13:04, Mike Solomon mike...@ufl.edu wrote: Sorry for the slew of patches in this vein - as I run into problems while trying to create a real engraver in scheme, I'm sending these patches along. http://codereview.appspot.com/1878048 What's wrong with using ly:context-property?

Re: Need some pointers for engravers.

2010-08-05 Thread Neil Puttock
On 5 August 2010 19:20, David Kastrup d...@gnu.org wrote: now that we have accordion pushpull symbols in Lilypond, I want to use them.  Tracking things up and down other articulation code I found that its not possible to make the accordion symbols regular articulations (the script engraver

Re: Need some pointers for engravers.

2010-08-05 Thread Neil Puttock
On 5 August 2010 20:24, David Kastrup d...@gnu.org wrote: That could be considered slightly unintuitive since the bellows changes direction at a time less than or equal to note onset.  Nothing that would worry me all too much. You could work round this via music functions (which would give

Re: [PATCH] Scheme binding for announce_end_grob

2010-08-04 Thread Neil Puttock
On 2 August 2010 13:35, Mike Solomon mike...@ufl.edu wrote: http://codereview.appspot.com/1914043 Applied: http://git.savannah.gnu.org/gitweb/?p=lilypond.git;a=commit;h=4ed35e481389eaddd6e07002f0b5ccad31994169 ___ lilypond-devel mailing list

Re: [PATCH] fix to issue 1173

2010-08-01 Thread Neil Puttock
On 1 August 2010 08:18, Mike Solomon mike...@ufl.edu wrote: Done :) Please let me know what you think. Great! I'll put it up on Rietveld and take a closer look later. Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: [PATCH] fix to issue 1173

2010-08-01 Thread Neil Puttock
On 1 August 2010 13:25, Neil Puttock n.putt...@gmail.com wrote: Great!  I'll put it up on Rietveld and take a closer look later. http://codereview.appspot.com/1741060/show ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org

Re: T1055: Avoid using deprecated %module-public-interface in guile initialisation. (issue1160044)

2010-08-01 Thread Neil Puttock
On 1 August 2010 21:49, Patrick McCarty pnor...@gmail.com wrote: I think I found the problem. With Guile 1.9, `module-public-interface' doesn't return an interface for `the-scm-module', which we rely on:  scheme@(guile-user) (module-public-interface the-scm-module)  $1 = #f  

Re: Typos in English manual

2010-07-31 Thread Neil Puttock
On 31 July 2010 14:15, Werner LEMBERG w...@gnu.org wrote: Well, `i.e.' is a shorthand for the Latin `id est' which translates to `that is', and for the latter, you always need a comma after the `is' if you continue with a sentence, right?  So I think `i.e.' needs a comma. I had a vague

Re: [PATCH] fix to issue 1116

2010-07-30 Thread Neil Puttock
On 30 July 2010 15:11, Mike Solomon mike...@ufl.edu wrote: This solution works for the minimal example given with the issue, and it works in general if one accepts the assumption that there is no reason that anything fed through stack-lines (in scm/stencil.scm) should have an X extent whose

Re: [PATCH] fix to issue 1173

2010-07-30 Thread Neil Puttock
On 30 July 2010 14:19, Mike Solomon mike...@ufl.edu wrote: This raises an error message if showLastLength is not used to show full measures. Ouch. :) We should always try to continue compilation (leaving aside syntax errors, of course) so I think it would be better to `round' the value if

Re: [PATCH] ly-engraver-make-spanner (to compliment ly-engraver-make-grob)

2010-07-29 Thread Neil Puttock
On 29 July 2010 19:22, Mike Solomon mike...@ufl.edu wrote: Name says it all. Why do you need this? Since a Spanner's parent class is Grob, ly:engraver-make-grob should have no problem creating spanners. Cheers, Neil ___ lilypond-devel mailing list

Re: [PATCH] ly-engraver-make-spanner (to compliment ly-engraver-make-grob)

2010-07-29 Thread Neil Puttock
On 29 July 2010 20:34, Mike Solomon mike...@ufl.edu wrote: I think that this patch is the easiest way to assure that the break processing will happen when do_break_processing is called (although I could be wrong), whereas creating a grob doesn't get you a spanner's break processing. Have you

RemoveEmptyStaves and \with

2010-07-27 Thread Neil Puttock
Hi, Context modifications inside an identifier are great, but in the case of \RemoveEmptyStaves, there's a nasty surprise waiting for you: since it's defined inside a layout block (as part of engraver-init.ly), it's unusable within a music block. \new Staff \with { \RemoveEmptyStaves } { c4 }

Re: Setting the value of a music property

2010-07-25 Thread Neil Puttock
On 25 July 2010 13:22, Joseph Wakeling joseph.wakel...@webdrake.net wrote:    naturalizeMusic =    #(define-music-function (parser location m)       (ly:music?)       (naturalize m (ly:music-property music 'naturalize-style))) This function has an arg called `m', but you're trying to access

Re: Setting the value of a music property

2010-07-25 Thread Neil Puttock
On 25 July 2010 20:49, Joseph Wakeling joseph.wakel...@webdrake.net wrote: I don't know how that typo got into my email, but it is _not_ what I have in my Lilypond input file.  This is:   naturalizeMusic =   #(define-music-function (parser location m)      (ly:music?)      (naturalize m

[PATCH] Fix #1192 - System separator positioning

2010-07-21 Thread Neil Puttock
Hi everybody, Please review this patch here: http://codereview.appspot.com/1665053/show Thanks, Neil ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: scheme night-mare...

2010-07-13 Thread Neil Puttock
Hi Joe, On 13 July 2010 02:18, Joe Neeman joenee...@gmail.com wrote: Does the attached patch help? For me, it reduces dramatically the number of times that combine_pure_heights (and also ly_scm2interval) is called, but it has very little effect on lilypond's overall running time (for the

Broken stem tremolos

2010-07-13 Thread Neil Puttock
:00 2001 From: Neil Puttock n.putt...@gmail.com Date: Tue, 13 Jul 2010 23:17:26 +0100 Subject: [PATCH] Fix bare stem tremolos. * scm/music-functions.scm (make-repeat): don't use length of 'elements for non-sequential repeat tremolos --- scm/music-functions.scm | 10 +++--- 1 files changed

Re: Chromatic transposition -- a very small starting step

2010-07-11 Thread Neil Puttock
On 9 July 2010 22:35, Carl Sorensen c_soren...@byu.edu wrote: Yes, but it's only in LilyPond miscellany, so it's really not important ;) Heh, not important enough to deserve a separate menu node. ;) BTW, are you OK with me pushing the auto-beaming stuff? Sorry, I was expecting another patch

Re: scheme night-mare...

2010-07-11 Thread Neil Puttock
On 11 July 2010 23:08, Arno Waschk hamama...@gmx.de wrote: Anyway, i came to a point where it seems very helpful to provide an easy option to print somehow the actual content of e. g. a grob at a certain point in the c++ code, or easily do some other voodoo to it, which i do not know yet...

Re: Chromatic transposition -- a very small starting step

2010-07-09 Thread Neil Puttock
On 9 July 2010 21:02, Joseph Wakeling joseph.wakel...@webdrake.net wrote: Neil -- thanks ever so much for the detailed explanations. You're welcome. I hope what I've said is correct, since Carl's pinched my post and added it to the Contributor's Guide. :) The transpose_mutable() function

Re: Comma in snippet filename

2010-07-08 Thread Neil Puttock
On 8 July 2010 18:43, Graham Percival gra...@percival-music.ca wrote: Then please rename it.  Patch to Trevor... no, wait, we'll need to regnerate the *.snippet-list files. Arrgh, please no! :) It shadows the snippet in LSR, which has the same filename: LSR doesn't strip commas. The LSR

<    1   2   3   4   5   6   7   8   9   10   >