Fixes all duplicate declarations of Flag #'transparent (issue 5312056)

remove the version number change to 2.15.11, then please push. http://codereview.appspot.com/5312056/diff/1/Documentation/snippets/new/guitar-slides.ly File Documentation/snippets/new/guitar-slides.ly (right):

Re: Sketch for in-notes. (issue 5293053)

http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc File lily/page-breaking.cc (right): http://codereview.appspot.com/5293053/diff/12001/lily/page-breaking.cc#newcode189 lily/page-breaking.cc:189: old.in_note_heights_.begin (), old.in_note_heights_.end ()); Why are we talking

Centralize the css files and fix the links to css files (issue 983). (issue 5285053)

LGTM http://codereview.appspot.com/5285053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG: clarify git-cl and contributor quick start (issue 5240054)

Reviewers: , Message: Patchy the autobot will ok this in an hour or so, but please take a quick look. Not because I think there's any problems, but because it could bring you up to speed on the new git-cl if you're feeling confused. Description: CG: clarify git-cl and contributor quick start

Re: CG: clarify git-cl and contributor quick start (issue 5240054)

http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/5240054/diff/1/Documentation/contributor/source-code.itexi#newcode953 Documentation/contributor/source-code.itexi:953:

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

yes, fine, LGTM, push it. http://codereview.appspot.com/5155045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Makeify the website build. (issue 5244045)

LGTM, thanks so much for cleaning this up! http://codereview.appspot.com/5244045/diff/1/make/website.make File make/website.make (right): http://codereview.appspot.com/5244045/diff/1/make/website.make#newcode73 make/website.make:73: CREATE_VERSION=python $(script-dir)/create-version-itexi.py

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

LGTM http://codereview.appspot.com/5155045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

LGTM http://codereview.appspot.com/5131045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

tested and looks great. I'd like to re-iterate the request to move the rietveld comments into actual comments in the makefiles; they were extremely helpful for me in reading the patch, so I'd like them to be stored in git.

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

I agree with everything Trevor said, including pushing after you've changed it and it compiles. http://codereview.appspot.com/4839061/diff/11001/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right):

Re: Doc: NR 1.2.6 added slashedGrace function (issue 5133043)

LGTM http://codereview.appspot.com/5133043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

http://codereview.appspot.com/5155045/diff/1/Documentation/snippets/new/positioning-multi-measure-rests.ly File Documentation/snippets/new/positioning-multi-measure-rests.ly (right):

Re: LSR: Updated snippet for MMR Positions (1931) (issue 5155045)

wait a moment, why are you adding a snippet to git at all? Just fix it in LSR. Talk to Phil if you don't know how. Patch rejected, sorry. (wow, what a disaster the whole LSR thing is!) http://codereview.appspot.com/5155045/ ___ lilypond-devel

Re: Build dependencies for .texi files (issue 1852). (issue 5169041)

the GNUmakefile and texinfo-rules.make look good http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi File Documentation/topdocs/AUTHORS.texi (right): http://codereview.appspot.com/5169041/diff/1/Documentation/topdocs/AUTHORS.texi#newcode13

Re: Fixes to projecthosting_upload.py (issue 5144045)

I'll need a github account name from you to enable random pushing to my git-cl repo. https://github.com/ I'm not going to picky about applying changes to this repo... although maybe it's good for me to take a quick peek at whatever you do, given some of the problems below. :)

Re: Build dependencies for .texi files (issue 1852). (issue 5131045)

the email came through without trouble; the problem is the uploading. Wait for Janek to do it. I've made issue 1491 release-critical. http://codereview.appspot.com/5131045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Creates convert-ly rules for flag syntax changes (issue 5050046)

LGTM http://codereview.appspot.com/5050046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1477: Add (ly:expect-warning msg args) to suppress expected warnings (issue 5037046)

Looks mostly good. I would have preferred to have the code changes in a separate patch from the regtest .ly editing, but that's not a major issue. http://codereview.appspot.com/5037046/diff/15001/input/regression/stem-tremolo.ly File input/regression/stem-tremolo.ly (right):

Re: NR Context Layout Order rewrite (5.1.7) - tracker 1812 (issue 4839061)

http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): http://codereview.appspot.com/4839061/diff/7002/Documentation/notation/changing-defaults.itely#newcode961

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

LGTM, go ahead and push http://codereview.appspot.com/5081048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: FiguredBass: Rewrite of the engraver to fix vertical position (issue 224052)

any chance of rebasing this patch? http://codereview.appspot.com/224052/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lily-guile updates and CG: Scheme-C interface section. (issue 4917044)

Since it has C changes as well, I'd prefer it to go through a countdown. http://codereview.appspot.com/4917044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Causes lily to fail during regtests if binary is unoptimized. (issue 5067042)

Not acceptable in current form because it would cause GUB to fail a build. I suggest an alternate make target for this type of build. http://codereview.appspot.com/5067042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Doc: Added note to CG about disable-optimizing (issue 5081048)

http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi File Documentation/contributor/regressions.itexi (right): http://codereview.appspot.com/5081048/diff/1/Documentation/contributor/regressions.itexi#newcode143 Documentation/contributor/regressions.itexi:143:

Re: Doc: add a note about \relative f to notation (issue 1909) (issue 5096046)

http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): http://codereview.appspot.com/5096046/diff/1/Documentation/notation/pitches.itely#newcode258 Documentation/notation/pitches.itely:258: If you carefully consider

Re: Doc: NR Clarify finer point of repeat unfold (issue 5075047)

LGTM. http://codereview.appspot.com/5075047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: lilypond-book-preamble: Automatically set the eps backend, since we require it anyway (issue 5038045)

LGTM http://codereview.appspot.com/5038045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New alist to replace special characters. (issue 4553056)

http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely File Documentation/notation/notation-appendices.itely (right): http://codereview.appspot.com/4553056/diff/103001/Documentation/notation/notation-appendices.itely#newcode909

Re: Lilypond-book: Improve options handling by processing everything in one place (issue 5030044)

LGTM http://codereview.appspot.com/5030044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fixes missing images in big website page (issue 4963046)

LGTM. A quick test showed no problems in make doc. I didn't get pictures in make website, but then I tried make website without the patch applied, and I still didn't get pictures... evidently I don't have my desktop set up to create the full website any more. So that's not a reason to distrust

Re: Gets first stem-info of a kneed-beam right (issue 5043047)

sounds reasonable to me http://codereview.appspot.com/5043047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

doc build: Use all includes for texinfo also for the xref-map generation (issue 5038044)

LGTM http://codereview.appspot.com/5038044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: adding doc strings for \...DashPattern and \harmonicBy... (1887) (issue 5019042)

LGTM http://codereview.appspot.com/5019042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

LGTM, go ahead and push. http://codereview.appspot.com/4951047/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: MusicXML: fix case when some elements have a staff number, while others don't (issue 4991044)

LGTM. I think this could have been pushed directly. http://codereview.appspot.com/4991044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: replace DIGIT token class with UNSIGNED (issue 4311041)

sorry, it's a bit unclear if this is a real patch or not, due to Reitveld screwed-up-ness. The top of this page states this: Do _not_, I repeat, do _not_ merge. I think that's left-over from your previous patch, but I don't know how to force Rietveld to only display the commit message from

Re: Doc: Added \compoundMeter function to NR (issue 4837050)

LGTM, not tested compile but I trust James. http://codereview.appspot.com/4837050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix issue #1852: manuals needs more explicit dependencies. (issue 4996044)

http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py File scripts/lilypond-book.py (right): http://codereview.appspot.com/4996044/diff/1/scripts/lilypond-book.py#newcode677 scripts/lilypond-book.py:677: relative_output_dir = global_options.output_dir did you want an

Re: Flush all ports after each file, flush stdout after displaying all options (issue 4956062)

LGTM http://codereview.appspot.com/4956062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

LTGM, not tested, but I'm willing to put it up and just see if anything breaks. My only qualm is that this takes lang.LANGAUGES, instead of defining a WEB_LANGUAGES. At the moment they're the same, but somebody might come in to do a new translation, and we don't want to enable that on the

Re: Added glyphs for Kievan Notation (issue 4951062)

Good job! I'm not very familiar with the fetafont stuff, but this looks like exactly the right thing to do. :) http://codereview.appspot.com/4951062/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: update the address of git-cl source files (issue 4967054)

LGTM, please push. http://codereview.appspot.com/4967054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

On 2011/09/02 06:25:59, jan.nieuwenhuizen wrote: If that works, then why not have +import langdefs +langs = [i.code if i.code != 'en' else '' for i in langdefs.LANGUAGES] I agree. Phil, why did you push this patch without implementing this, or at least responding to Jan to say why you

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

Looks plausible, but I haven't tested it quite yet. Could we get: 1) update to the make-website.sh portion of the CG, line 249 of website-work.itexi ? 2) define WEB_LANGS (or something similar) in langdefs.py, then use those in create-weblinks.itexi.py ? Once that's done, I'll give it a whirl,

Fix 1821: Write pathes for ly-to-tely to a separate file rather than passing as cmd line args (issue 4950053)

sweet mao that's disgusting. I love it. :) If you can make doc from scratch, then push. http://codereview.appspot.com/4950053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Uses langdefs.py to create language list for create-weblinks-itexi.py (issue 4951047)

http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-itexi.py File scripts/build/create-weblinks-itexi.py (right): http://codereview.appspot.com/4951047/diff/1/scripts/build/create-weblinks-itexi.py#newcode31 scripts/build/create-weblinks-itexi.py:31: # Unable to find

Re: Fixes missing images in big website page (issue 4963046)

I see images, but not ly-examples. Are you sure you see ly-examples on your system? http://codereview.appspot.com/4963046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Gets rid of length in the docs. (issue 4965053)

amusingly, I have no trouble compiling the docs without this patch, but it fails with this patch applied: /main/src/lilypond/build/out/lybook-db/b5/lily-2dcca534.ly:1097:9: warning: no viable initial configuration found: may not find good beam slope c ees8 f g Segmentation

Re: Fixes missing images in big website page (issue 4964041)

http://codereview.appspot.com/4964041/diff/3001/make/website.make File make/website.make (right): http://codereview.appspot.com/4964041/diff/3001/make/website.make#newcode57 make/website.make:57: ### only update this when the language compiles correctly! On 2011/08/27 09:55:25, PhilEHolmes

Re: Fixes missing images in big website page (issue 4964041)

I'm a bit confused about what you're trying to do here (the git-cl confusion doesn't help). I am also concerned that you're trying to do complicated build stuff without being able to test it with the **full** website-only build. I really, really suggest that you get the full website-only build

Re: Enhancement: Internal ledger lines. (issue 1855056)

Hi Neil, Are you still working on this? It's been a year. http://codereview.appspot.com/1855056/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix 1816: Lilypond-Book: don't clear the auto-detected line-with, rather modify it (issue 4888046)

countdown over, please please push so that we can get a better idea of how many outstanding patches there are. http://codereview.appspot.com/4888046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

depending on how smart git is, it might be good to rebase and upload a new draft of this patch after http://codereview.appspot.com/4888046/ is pushed (currently on a 48-hour countdown) http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (right):

Re: Fix 1816: Lilypond-Book: don't clear the auto-detected line-with, rather modify it (issue 4888046)

LGTM http://codereview.appspot.com/4888046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

LGTM, please push. http://codereview.appspot.com/4938044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Adds a site search to website and improves doc search (issue 4894053)

I have grave doubts about adding a second search box. 1) it makes the top bar uncomfortably squashed in my default web browser window 2) it requires users to choose which type of search they want to do. #1 isn't about me forcing my desktop browser preferences on anybody, but rather I'm making

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

Yes, definitely do the pushing stuff in a separate patch. But here's an outline: 1. update with git pull -r 2. check you only have 1 patch ready with git status 3. upload your changes with git push http://codereview.appspot.com/4898058/ ___

Re: Lilypond-book: Auto-detect linewidth and exampleindent in texinfo mode (issue 4938044)

On 2011/08/22 12:30:15, Reinhold wrote: Now, it's clear that lilypond produces .pdf files that are about 0.5-1 mm too wide. So we now have the proper way to fix #1816 What does 0.5-1mm mean? Is it 0.5 for top/bottom, 1.0 for left/right? Or does it depend on some random factor? (i.e.

Re: Fix 1816: Lilypond-book: Give images 1mm less linewidth (issue 4940043)

http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4940043/diff/1/python/book_snippets.py#oldcode411 python/book_snippets.py:411: if not has_line_width: This change change be pushed now; it's gone through the

Re: Corrects image size in web.pdf - issue 982 (issue 4916041)

LGTM, but do we still use the -small images for anything else now? I mean, go ahead and push this, but then please investigate if we still need the -small images, and if we don't need them, then please remove them from the build system. http://codereview.appspot.com/4916041/

Re: lily-guile updates and CG: Scheme-C interface section. (issue 4917044)

Doc part LGTM. I can't speak about the scm / C++ stuff. http://codereview.appspot.com/4917044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: DOC: Revise CG 3.4 Commit Access (issue 4898058)

On 2011/08/18 11:42:13, Reinhold wrote: Documentation/contributor/source-code.itexi:1425: Generate an SSH @q{rsa} key pair. Enter the following at the Why did you change all dsa to rsa? RSA is the older encryption technology, which is known not to be as secure as DSA... Really?! this

DOC: Revise CG 3.4 Commit Access (issue 4898058)

LGTM, one suggestion. http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi File Documentation/contributor/source-code.itexi (right): http://codereview.appspot.com/4898058/diff/1/Documentation/contributor/source-code.itexi#newcode1574

Fix 1816: Lilypond-Book: don't clear the auto-detected line-with, rather modify it (issue 4888046)

Thanks so much for looking into this! http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py File python/book_snippets.py (left): http://codereview.appspot.com/4888046/diff/1/python/book_snippets.py#oldcode424 python/book_snippets.py:424: if type == 'lilypond': This part is only

Re: Texi2HTML: don't wrap p around the contents of table cells. (issue 4891044)

LGTM; please push after fixing Neil's whitespace concerns. http://codereview.appspot.com/4891044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Get rid of some compiler warnings (issue4854049)

http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly File input/regression/completion-heads-factor.ly (right): http://codereview.appspot.com/4854049/diff/5001/input/regression/completion-heads-factor.ly#newcode12

Re: Get rid of some compiler warnings (issue4854049)

On 2011/08/10 05:19:42, Graham Percival wrote: input/regression/completion-heads-factor.ly:12: \paper { #(set-paper-size a6) } is this part of the compiler warnings patch? sorry, ignore that, I only just looked at the changelog message. http://codereview.appspot.com/4854049/

Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)

LGTM. My comment is a tiny nitpick; I don't think it needs to hold up pushing this. http://codereview.appspot.com/4811066/diff/8003/input/regression/mozart-hrn-3.ly File input/regression/mozart-hrn-3.ly (right):

Re: Doc: Added \compoundMeter function to NR (issue4837050)

LGTM http://codereview.appspot.com/4837050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix for Issue 620. (issue4814041)

cannot apply to master due to fixcc. http://codereview.appspot.com/4814041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: modifying default behaviour of tremolo slashes (issue4636081)

cannot apply to master due to fixcc. http://codereview.appspot.com/4636081/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: New engraver for braces (issue4807053)

sorry, unforutnately this patch cannot be applied to git master due to fixcc. http://codereview.appspot.com/4807053/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Proper loglevels: cmd-line option --loglevel=NONE/ERROR/WARN/PROGRESS/INFO/DEBUG (issue4822055)

awesome work, I really love this. Unfortunately it cannot apply directly to git master due to fixcc. http://codereview.appspot.com/4822055/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: print transposed guitar chords on piano sheets (issue4626094)

patch fails due to fixcc. http://codereview.appspot.com/4626094/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Add Notation appendix for context mod identifiers. (issue4794057)

LGTM, fantastic work as always. http://codereview.appspot.com/4794057/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Rewrite regtest mozart-hrn-3.ly (issue4811066)

LGTM, although I initially misread the commit message as saying that the *new* version uses tabs for indents. Maybe change that to the old version used tabs, just for extra clarity ? http://codereview.appspot.com/4811066/ ___ lilypond-devel mailing

Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)

LGTM http://codereview.appspot.com/4808051/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: Usage - new option for lilypond-book (issue4806050)

LGTM http://codereview.appspot.com/4806050/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: DOC: fix NR 1.6.3 Formatting Cue Notes (Issue 1762) (issue4808051)

http://codereview.appspot.com/4808051/diff/1/Documentation/notation/staff.itely File Documentation/notation/staff.itely (right): http://codereview.appspot.com/4808051/diff/1/Documentation/notation/staff.itely#newcode1319 Documentation/notation/staff.itely:1319: In the above example, the

Do not issue rectstroke if blot diameter is 0.0. (issue4819041)

I can't see the diff. Please read: http://code.google.com/p/lilypond/issues/detail?id=1491 http://codereview.appspot.com/4819041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Fix #1695: Clef change placed outside score. (issue4683043)

Hi Neil, Please push this; we'd like to get back to 0 Critical issues. Cheers, - Graham http://codereview.appspot.com/4683043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

CG: describe new C++ formatting (GOP-PROP 3) (issue4760056)

Reviewers: , Message: here's a series of patches for the C++ formatting. - final (?) set of changes to fixcc.py - changes to CG Description: CG: describe new C++ formatting (GOP-PROP 3) Adapt fixcc.py to use Astyle Please review this at http://codereview.appspot.com/4760056/ Affected files:

Re: Doc: NR Added new Node for Footnotes (issue4751045)

LGTM. Maybe wait a day for Trevor to comment, then push. http://codereview.appspot.com/4751045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Doc: NR Added new Node for Footnotes (issue4751045)

could you do a git pull, and then make a new commit for this? I've run makelsr.py locally. http://codereview.appspot.com/4751045/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Doc: NR Added new Node for Footnotes (issue4751045)

you need to do git add Documentation/snippets/new/*.ly git commit Documentation/snippets/new/ to get your new files included in this commit. http://codereview.appspot.com/4751045/diff/2001/Documentation/notation/input.itely File Documentation/notation/input.itely (right):

Re: Doc: NR Added new Node for Footnotes (issue4751045)

On 2011/07/16 21:06:34, Graham Percival wrote: you need to do git add Documentation/snippets/new/*.ly git commit Documentation/snippets/new/ to get your new files included in this commit. no wait, sorry, ignore that. My eyes (and the sorting order in rietveld) mislead me.

Re: Adds redirect-lilypond-output option to lilypond-book (issue4664060)

in light of the growing consensus for combined logfiles for the build system -- and given that lilypond only produces stuff on stderr and apparently this isn't going to change -- I wonder if it might be better to redirect both stdout and sterr to a single .log file. I'm happy with pushing this

Re: correcting note about rerunning regtests (issue4675048)

LGTM http://codereview.appspot.com/4675048/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

LGTM http://codereview.appspot.com/4636082/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/13003/Documentation/web/community.itexi#newcode320 Documentation/web/community.itexi:320: or @code{%@{ @dots{} %@}})}

Web: Added Link to LSR (issue4668058)

http://codereview.appspot.com/4668058/diff/1/Documentation/web/manuals.itexi File Documentation/web/manuals.itexi (right): http://codereview.appspot.com/4668058/diff/1/Documentation/web/manuals.itexi#newcode129 Documentation/web/manuals.itexi:129: (LSR). User-created snippets that show a

Re: an example of minimal example (issue4636082)

http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311: Specify which release of LilyPond

Re: Web: Added Link to LSR (issue4668058)

LGTM, please push. (under my seal as Documentation Meister) http://codereview.appspot.com/4668058/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: an example of minimal example (issue4636082)

I'm in a boring presentation. http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi File Documentation/web/community.itexi (right): http://codereview.appspot.com/4636082/diff/4002/Documentation/web/community.itexi#newcode311 Documentation/web/community.itexi:311:

Re: Adapt fixcc.py to use Astyle and/or emacs (issue4662074)

On 2011/07/06 16:33:12, jan.nieuwenhuizen wrote: On 2011/07/06 14:40:56, Graham Percival wrote: wait, WTF just happened? We're no longer using astyle, and instead we'll be requiring everybody to install emacs?! Yay! And while everyone has it installed, why not give it a second (or third)

Re: an example of minimal example (issue4636082)

We need to be careful about adding stuff to the webpage; perfection is when there's nothing left to remove, not when there's nothing left to add. I'm glad that you're working on it! I'm just warning you that there will be many nitpicks.

Re: an example of minimal example (issue4636082)

On 2011/07/04 21:01:44, Janek Warchol wrote: 2011/7/4 percival.music...@gmail.com: this won't compile; it would have to be @example instead, and that will require @{ @} escapes. Umm.. is it right now? why the mao are you asking me? Cutpaste this and tell me yourself: cd build/

Re: Adapt fixcc.py to use Astyle instead of emacs (issue4662074)

On 2011/07/03 02:41:15, Carl wrote: Can you make it possible for us to see the diff caused by applying this script to the files you've mentioned? I'll make a separate git branch showing the output once a few minor issues are done. Keith: 1. all // comments are now hard-left (i.e. in column

Re: Adds redirect-lilypond-output option to lilypond-book (issue4664060)

could you check the permissions or directory of http://www.holmessoft.co.uk/homepage/private/lilypond/lilygood.lytex I can't download any of the .lytex files. I can get the .txt files just fine. http://codereview.appspot.com/4664060/ ___

  1   2   3   4   5   >