Re: Add lilypond version predicates/operators (issue 317270043 by g...@ursliska.de)

To throw in my own 2cts. Why not compare strings, looks more straight forward to me. (define (calculate-version-harm ref-version) (cond ((string? ref-version) ref-version) ((number-list? ref-version) (string-concatenate (list-join (map number->string ref-version) ".")))

Re: Issue 3830: Document \offset command (issue 319150043 by david.nales...@gmail.com)

Two thoughts, otherwise LGTM https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely File Documentation/notation/changing-defaults.itely (right): https://codereview.appspot.com/319150043/diff/1/Documentation/notation/changing-defaults.itely#newcode2522

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

On 2017/01/15 17:07:57, david.nalesnik wrote: https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly File Documentation/snippets/new/moving-the-ends-of-hairpins.ly (right):

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

Again limited to the scm/ly-files: LGTM One nit: https://codereview.appspot.com/315350043/diff/20001/Documentation/snippets/new/moving-the-ends-of-hairpins.ly File Documentation/snippets/new/moving-the-ends-of-hairpins.ly (right):

Re: NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

On 2017/01/08 16:42:58, simon.albrecht wrote: On 04.01.2017 00:14, mailto:thomasmorle...@gmail.com wrote: > (I shepherd this for Simon, as long as he has problems with his google > account) For the record: Google prevented the login despite that I accessed the internet with the same

Re: Implement shorten-pair for Hairpin (issue 315350043 by david.nales...@gmail.com)

On 2017/01/07 17:12:57, david.nalesnik wrote: Please review. Thanks! Hi David, very nice. I can't review C++-code, but applied the patch and tested with: \layout { \override Hairpin.layer = 200 \override Hairpin.color = #red } { \override Hairpin.minimum-length = 40 \override

NR 1.2.1.d: Split note correctly (issue 319940043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review (I shepherd this for Simon, as long as he has problems with his google account) Description: NR 1.2.1.d: Split note correctly In 4/4 time, a note crossing the middle of the bar should be split at the middle of the bar. The current example displays bad

Issue 4983 Let crossStaff hide non-default-style flags (issue 315330043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: Issue 4983 Let crossStaff hide non-default-style flags Return empty-stencil for all flags using the code provided in flag-styles.scm, if the style property is 'no-flag as set by the crossStaff-function. Please review this at

Let the distance of strings and frets in fret-diagrams be settable (issue 319030043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: Let the distance of strings and frets in fret-diagrams be settable - Two new sub-properties of fret-diagram-details are introduced: fret-distance and string-distance - regtest fret-diagrams-size.ly is extended - entry in changes.tely Please

Re: Point to \resetRelativeOctave in NR 1.1.1.b (issue 312210043 by simon.albre...@mail.de)

Some nitpicks, otherwise LGTM https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right): https://codereview.appspot.com/312210043/diff/20001/Documentation/notation/pitches.itely#newcode302

Re: add choral and choral-cautionary accidental style (issue 311430043 by perpeduumimmob...@gmail.com)

Worth an entry in changes? Some wording-nitpicks, otherwise LGTM https://codereview.appspot.com/311430043/diff/1/Documentation/notation/pitches.itely File Documentation/notation/pitches.itely (right):

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/03 11:33:15, dak wrote: David Kastrup writes: > As a user interface, that sounds very much desirable. I don't like > converting symbols to strings, putting stuff on them, and converting > them back again. > > But it's probably the lesser evil. Actually,

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/03 11:34:48, dak wrote: mailto:thomasmorle...@gmail.com writes: > On 2016/12/03 11:28:24, dak wrote: >> mailto:thomasmorle...@gmail.com writes: > >> > On 2016/12/02 19:45:02, dak wrote: >> >> However, people might get surprised by >> > >> >> #(unfoldRepeats 'tremolo m) >> > >> >>

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/03 11:33:15, dak wrote: David Kastrup writes: > As a user interface, that sounds very much desirable. I don't like > converting symbols to strings, putting stuff on them, and converting > them back again. > > But it's probably the lesser evil. Actually,

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/03 11:28:24, dak wrote: mailto:thomasmorle...@gmail.com writes: > On 2016/12/02 19:45:02, dak wrote: >> However, people might get surprised by > >> #(unfoldRepeats 'tremolo m) > >> not working. > > Btw, it turned out the previous unfold-repeats destructively changed the >

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/02 19:45:02, dak wrote: However, people might get surprised by #(unfoldRepeats 'tremolo m) not working. Btw, it turned out the previous unfold-repeats destructively changed the music-argument, if called directly. See: \version "2.19.51" m = \repeat volta 2 {

Re: unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

On 2016/12/01 22:42:38, simon.albrecht wrote: Hi Harm, thanks for the patch. As for the user-interface, I’d prefer something like \unfoldRepeats tremolo \m \unfoldRepeats volta,tremolo \m Done. Thanks for review. https://codereview.appspot.com/318890043/

unfoldRepeats can be restricted to certain repeat-types (issue 318890043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: unfoldRepeats can be restricted to certain repeat-types It now takes an additional, optional argument. It's a list of symbols representing the repeat-types which should be unfolded. Possible settings are percent-repeated-music,

Issue 4988 straight-flags partly wrong claculated (issue 307600043 by thomasmorle...@gmail.com)

Reviewers: , Description: Issue 4988 straight-flags partly wrong claculated The angles for straight-flags at down- and up-pointing stems are now accurately respected. This will cause some slight changes in the reg-tests. Please review this at https://codereview.appspot.com/307600043/ Affected

Re: Don't merge non-overlapping ledger lines (issue 308560043 by paulwmor...@gmail.com)

On 2016/10/02 20:46:47, pwm wrote: Please review, fixes issue 4979. -Paul I can't review C++, but I applied your patch and tested it with my code from http://lists.gnu.org/archive/html/lilypond-user/2012-07/msg00336.html (A far more extreme example than your regtest) Works nicely. So far:

Convert a bunch of C++ internals to degrees rather than radians (issue 305380043 by d...@gnu.org)

As always, can't judge C++ -code. Though, I've gone through the doc-strings, from that and from patch-description: very nice! Thanks tackling this problem. I'd love to play around with ly:length, ly:directed and ly:angle. Regrettable I'll not have enough time to do tests before next weekend.

Fix micro-tones assigned to strings in TabStaff (issue 308230043 by thomasmorle...@gmail.com)

Reviewers: , Description: Fix micro-tones assigned to strings in TabStaff This is an oversight from issue 4643 Also extending input/regression/tablature-micro-tone.ly to cover this case. Please review this at https://codereview.appspot.com/308230043/ Affected files (+28, -11 lines): M

Re: Change \retrograde to deal with ties and repeat chords/notes (issue 302470043 by d...@gnu.org)

On 2016/08/16 14:24:50, dak wrote: Regtest and fixes for glissandi, \<, \> and docs Wow. You've put up another load of work. Some of the limitations you've mentioned yourself here: http://lists.gnu.org/archive/html/lilypond-user/2016-08/msg00247.html still persist. Though, tackling them would

Re: Change \retrograde to deal with ties and repeat chords/notes (issue 302470043 by d...@gnu.org)

On 2016/08/16 07:54:50, dak wrote: On 2016/08/16 06:23:17, thomasmorley651 wrote: > Didn't dive into the code in depth. From my (limited) testings, I'd say it's > very nice, thus: I'm really bad at creating test cases. Do you have any spares left over from your (limited) testings that

Change \retrograde to deal with ties and repeat chords/notes (issue 302470043 by d...@gnu.org)

Didn't dive into the code in depth. From my (limited) testings, I'd say it's very nice, thus: LGTM A nitpick: https://codereview.appspot.com/302470043/diff/1/scm/modal-transforms.scm File scm/modal-transforms.scm (right):

Fix SchemeTextSpanEvent in scheme-text-spanner.ly (issue 301560043 by thomasmorle...@gmail.com)

Reviewers: , Description: Fix SchemeTextSpanEvent in scheme-text-spanner.ly Adding 'post-event to the types of SchemeTextSpanEvent in (define scheme-event-spanner-types ...) Please review this at https://codereview.appspot.com/301560043/ Affected files (+1, -1 lines): M

Clearify ending of hairpins at bar line in NR (issue 301550043 by thomasmorle...@gmail.com)

Reviewers: , Description: Clearify ending of hairpins at bar line in NR Please review this at https://codereview.appspot.com/301550043/ Affected files (+4, -1 lines): M Documentation/notation/expressive.itely Index: Documentation/notation/expressive.itely diff --git

Re: Issue 4931 make deadNote work with other font-settings (issue 309780043 by thomasmorle...@gmail.com)

On 2016/07/27 17:16:25, thomasmorley651 wrote: Bad I have no other music-font to test installed on my system, will ask on the list. Abraham provided some special fonts for me, many, many thanks again! So far the font has cross-style notehead-glyphs all works as expected. But if they are

Re: Issue 4931 make deadNote work with other font-settings (issue 309780043 by thomasmorle...@gmail.com)

On 2016/07/27 14:12:12, dak wrote: On 2016/07/27 13:32:04, thomasmorley651 wrote: > regtest-version corrected If we have the meanings to spit out a warning when the character is not in the font, shouldn't we be able to selectively fall back to Emmentaler for symbols not in the current

Re: Issue 4931 make deadNote work with other font-settings (issue 309780043 by thomasmorle...@gmail.com)

On 2016/07/27 14:12:12, dak wrote: On 2016/07/27 13:32:04, thomasmorley651 wrote: > regtest-version corrected This here seems like making it impossible to use non-standard music fonts even when they would be able to support the noteheads in question. Ofcourse its possible to use another

Issue 4931 make deadNote work with other font-settings (issue 309780043 by thomasmorle...@gmail.com)

Reviewers: , Description: Issue 4931 make deadNote work with other font-settings This is done by temporarily setting font-name to '(), causing the default-font (usually Feta) to take over, reverting this later. The regtest dead-notes.ly is altered accordingly. Also, ly-syntax is used where

Fix output definition use in \book and \bookpart (issue 299490043 by d...@gnu.org)

From description I'd vote for it https://codereview.appspot.com/299490043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Make \header blocks tangible in Scheme (issue 296600043 by d...@gnu.org)

LGTM https://codereview.appspot.com/296600043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Don't treat context modification identifiers special (issue 299460043 by d...@gnu.org)

As always, I can't review parser-code. Though, after discussion here http://lilypond.1069038.n5.nabble.com/tiny-function-td192058.html I vote for it. A nitpick: https://codereview.appspot.com/299460043/diff/1/input/regression/context-mod-with.ly File input/regression/context-mod-with.ly

Re: Make \header blocks tangible in Scheme (issue 296600043 by d...@gnu.org)

regtest and changes LGTM From experimenting with it, changes in parser are great. A remark, unrelated to current patch: https://codereview.appspot.com/296600043/diff/20001/input/regression/identifiers.ly File input/regression/identifiers.ly (right):

Re: Make \header blocks tangible in Scheme (issue 296600043 by d...@gnu.org)

On 2016/06/28 17:29:19, dak wrote: On 2016/06/28 17:09:04, thomasmorley651 wrote: > Can't review the code. > From description: very nice. > > Though, I'm not sure to which grade coding (with) header-expressions will be > extended. Complete? Try finding something that doesn't work.

Make \header blocks tangible in Scheme (issue 296600043 by d...@gnu.org)

Can't review the code. From description: very nice. Though, I'm not sure to which grade coding (with) header-expressions will be extended. Meaning, how about an entry in changes and/or snippets? https://codereview.appspot.com/296600043/ ___

Give SystemStartSquare a default of 5.0 for collapse-height (issue 303760043 by thomasmorle...@gmail.com)

Reviewers: , Description: Give SystemStartSquare a default of 5.0 for collapse-height This ensures same behaviour of SystemStartSquare while using RemoveEmptyStaves as SystemStartBar, SystemStartBrace and SystemStartBracket. The latter ones already have this default. Please review this at

Re: make calc-blot from bar-line.scm public (issue 299250044 by thomasmorle...@gmail.com)

On 2016/06/05 17:39:35, dak wrote: On 2016/06/05 17:27:15, thomasmorley651 wrote: > On 2016/06/05 15:51:25, dak wrote: > > https://codereview.appspot.com/299250044/diff/1/scm/bar-line.scm > > File scm/bar-line.scm (right): > > > >

Re: make calc-blot from bar-line.scm public (issue 299250044 by thomasmorle...@gmail.com)

I expected this one to be a real nobrainer... Anyway, On 2016/06/05 15:51:25, dak wrote: https://codereview.appspot.com/299250044/diff/1/scm/bar-line.scm File scm/bar-line.scm (right): https://codereview.appspot.com/299250044/diff/1/scm/bar-line.scm#newcode30 scm/bar-line.scm:30:

make calc-blot from bar-line.scm public (issue 299250044 by thomasmorle...@gmail.com)

Reviewers: , Description: make calc-blot from bar-line.scm public To facilitate defining custom-bar-lines using ly:round-filled-box Please review this at https://codereview.appspot.com/299250044/ Affected files (+1, -1 lines): M scm/bar-line.scm Index: scm/bar-line.scm diff --git

Re: Update texinfo.tex from upstream (issue 300820043 by truer...@gmail.com)

I can't review your code (out of my depth), but while applying your patch for testing whether Ì can `make doc' again I noticed: https://codereview.appspot.com/300820043/diff/20001/tex/texinfo.tex File tex/texinfo.tex (right):

Keep "\""-signs for graphviz (issue 292110043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Not sure, whether it's the best way to do it. Description: Keep "\""-signs for graphviz Transform them to "\\\"" Please review this at https://codereview.appspot.com/292110043/ Affected files (+8, -2 lines): M ly/graphviz-init.ly Index:

Make chord-naming robust against unsetting majorSevenSymbol (issue 288700043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review Description: Make chord-naming robust against unsetting majorSevenSymbol This will likely be changed anyway as soon as rewriting chord-names is seriously tackled. At least it might be a reminder to take care of the possibility a user wants to unset

Let the parser interpret alist variables (issue 290560043 by d...@gnu.org)

Even from description the consequences are not clear to me. Can you give a little verbose example? https://codereview.appspot.com/290560043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Require path separators in assignments/overrides (issue 286680043 by d...@gnu.org)

Can't review parser-code, but from description: This is the logical consequence of your previous work. I vote for it. Offtopic: time for v2.20 ? https://codereview.appspot.com/286680043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Let Stockhausen example use current override syntax (issue 293860043 by d...@gnu.org)

LGTM https://codereview.appspot.com/293860043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Let graphiz-init.ly use grob::name, delete grob-name (issue 289480043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review. Though, this does not tackle my bug-report here: http://lilypond.1069038.n5.nabble.com/error-while-using-graphviz-td187830.html Description: Let graphiz-init.ly use grob::name, delete grob-name Please review this at

Re: Let ', ' separate symbol lists like '.' does (issue 290490043 by d...@gnu.org)

On 2016/03/09 09:10:42, dak wrote: On 2016/03/08 23:28:37, thomasmorley651 wrote: > > I firstly had some concerns about problems arising from people being tempted to > write additional spaces after the comma, though with: > > blub = #(define-void-function (arg)(list?) (write (map

Re: Let ', ' separate symbol lists like '.' does (issue 290490043 by d...@gnu.org)

On 2016/03/08 22:55:51, dak wrote: On 2016/03/08 22:42:55, dan_faithful.be wrote: > On Mar 8, 2016, at 13:17 , mailto:d...@gnu.org wrote: > > > > Description: > > Let ',' separate symbol lists like '.' does > > > > While the dotted list syntax is natural for hierarchical paths like for > >

Support additional bass strings in TabStaff (issue 286210043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: Support additional bass strings in TabStaff - new context-property: additionalBassStrings - new regtest - new entries in NR, Changes Pitches on those additional bass strings will be printed as: a, /a, //a, ///a, 4, 5 ... as common for baroque

Re: Introduce markup-list-command table (issue 289980043 by thomasmorle...@gmail.com)

On 2016/01/30 23:32:17, dak wrote: https://codereview.appspot.com/289980043/diff/1/scm/define-markup-commands.scm#newcode4783 scm/define-markup-commands.scm:4783: (split-lst lst columns '( We've had this a few times. A markup-list? argument is not necessarily a list of markups. It can

Re: Introduce markup-list-command table (issue 289980043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/289980043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/289980043/diff/1/scm/define-markup-commands.scm#newcode4724 scm/define-markup-commands.scm:4724: The amount of columns is specifies by

Re: Introduce markup-list-command table (issue 289980043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/289980043/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/289980043/diff/40001/scm/define-markup-commands.scm#newcode4724 scm/define-markup-commands.scm:4724: The number of columns is specifies

Re: Introduce markup-list-command table (issue 289980043 by thomasmorle...@gmail.com)

On 2016/01/31 14:56:37, dak wrote: https://codereview.appspot.com/289980043/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/289980043/diff/40001/scm/define-markup-commands.scm#newcode4724

Introduce markup-list-command table (issue 289980043 by thomasmorle...@gmail.com)

Reviewers: , Description: Introduce markup-list-command table Please review this at https://codereview.appspot.com/289980043/ Affected files (+152, -0 lines): M Documentation/changes.tely M scm/define-markup-commands.scm ___ lilypond-devel

Allow Scheme functions to be called inside of markup (issue 285070043 by d...@gnu.org)

After some testings I'm quite happy with it, apart from one use case: fooII = #(define-scheme-function (arg)(markup-list?) #{ \markup \column $arg #}) %% doesn't work: \markup \line { "xy" \fooII { "does" "not" "work"} } %% works \markup \line { "xy" \fooII \markuplist { "whatever" "else" } }

Re: Allow Scheme functions to be called inside of markup (issue 285070043 by d...@gnu.org)

On 2016/01/16 20:37:23, dak wrote: On 2016/01/16 19:54:54, thomasmorley651 wrote: > After some testings I'm quite happy with it, apart from one use case: > > fooII = > #(define-scheme-function (arg)(markup-list?) > #{ > \markup \column $arg > #}) > > %% doesn't work: > \markup \line { "xy"

Re: Introduce new markup-command draw-squiggle-line. (issue 281210043 by thomasmorle...@gmail.com)

On 2016/01/06 13:35:15, pkx166h wrote: Don't forget this will (eventually) also need 1. An entry in Changes.tely (preferably with an example) Done. 2. An entry in the appropriate NR location Appendix (if that is the right place). As Simon already pointed out this will be generate

Re: Introduce new markup-command draw-squiggle-line. (issue 281210043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/281210043/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/281210043/diff/40001/scm/define-markup-commands.scm#newcode314 scm/define-markup-commands.scm:314: (height 0.5) On 2016/01/07 00:04:26,

apply sign on orientation in make-bow-stencil (issue 285770043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: apply sign on orientation in make-bow-stencil This avoids ambiguity with bow-height and thickness Please review this at https://codereview.appspot.com/285770043/ Affected files (+2, -4 lines): M scm/stencil.scm Index: scm/stencil.scm diff

Re: Introduce new markup-command draw-squiggle-line. (issue 281210043 by thomasmorle...@gmail.com)

Too late for a follow-up, but: https://codereview.appspot.com/281210043/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/281210043/diff/40001/scm/define-markup-commands.scm#newcode309 scm/define-markup-commands.scm:309:

Introduce new markup-command draw-squiggle-line. (issue 281210043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: Introduce new markup-command draw-squiggle-line. Change regtest /input/regression/markup-line-styles.ly accordingly Please review this at https://codereview.appspot.com/281210043/ Affected files (+140, -3 lines): M

Re: Introduce new markup-command draw-squiggle-line. (issue 281210043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/281210043/diff/1/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/281210043/diff/1/scm/define-markup-commands.scm#newcode326 scm/define-markup-commands.scm:326: @code{angularity], @code{height} and

Re: Improve note-by-number to deal better with flag-styles (issue 284000043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/28443/diff/40001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right): https://codereview.appspot.com/28443/diff/40001/scm/define-markup-commands.scm#newcode3550 scm/define-markup-commands.scm:3550: @code{neomensural}. The latter two

Re: Improve note-by-number to deal better with flag-styles (issue 284000043 by thomasmorle...@gmail.com)

please review https://codereview.appspot.com/28443/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Improve note-by-number to deal better with flag-styles (issue 284000043 by thomasmorle...@gmail.com)

On 2015/12/27 22:22:56, simon.albrecht wrote: LGTM, except for one doc nitpick. https://codereview.appspot.com/28443/diff/20001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right):

Changes minimum-space to extra-space in BarLine.space-alist.clef (issue 277320043 by thomasmorle...@gmail.com)

Reviewers: , Description: Changes minimum-space to extra-space in BarLine.space-alist.clef Prevents bad spacing, if Clef is forced to be displayed after BarLine via changed BreakAlignment.break-align-orders Please review this at https://codereview.appspot.com/277320043/ Affected files (+1, -1

Don't hardwire usable size of StrokeFinger.digit-names vector (issue 282750043 by d...@gnu.org)

LGTM https://codereview.appspot.com/282750043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Improve markup->string (issue 282740043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review nb there are some TODO's Description: Improve markup->string Search and filter lily-module for all relevant markup-(list)-commands to prevent error-prone manual selecting. Special-casing put-adjacent and fill-with-pattern Please review this at

Re: Doc: CG - Updated the Meister's section (issue 276980044 by pkx1...@gmail.com)

LGTM https://codereview.appspot.com/276980044/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Use make-bow-stencil to simplify make-parenthesis-stencil (issue 280750043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review I'm not sure if the final interval-widen in make-parenthesis-stencil is really necassary. It was in before, so I did it as well. My local regtests don't show a difference, though. Description: Use make-bow-stencil to simplify make-parenthesis-stencil

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/19 21:29:41, thomasmorley651 wrote: On 2015/11/18 23:01:20, thomasmorley651 wrote: > On 2015/11/16 15:57:49, dak wrote: > > If we are sure we'll never need to change the direction based on the > > markup direction (like, say, over/under actual note glyphs?), I'd just >

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/18 23:01:20, thomasmorley651 wrote: On 2015/11/16 15:57:49, dak wrote: > If we are sure we'll never need to change the direction based on the > markup direction (like, say, over/under actual note glyphs?), I'd just implement > commands undertie/overtie that call some internal

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/16 15:57:49, dak wrote: On 2015/11/14 21:25:11, thomasmorley651 wrote: > On 2015/11/13 21:51:19, dak wrote: > > Sorry for yet finding more stuff that, after all, could likely be improved. > At > > least I did so pretty quickly this time. > > > > >

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/13 21:51:19, dak wrote: Sorry for yet finding more stuff that, after all, could likely be improved. At least I did so pretty quickly this time. https://codereview.appspot.com/270640043/diff/60001/scm/define-markup-commands.scm File scm/define-markup-commands.scm (right):

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/13 23:15:22, thomasmorley651 wrote: On 2015/11/13 23:01:39, dak wrote: > Aaand another one. > > https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm > File scm/stencil.scm (right): > > https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm#newcode66 >

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/13 23:01:39, dak wrote: Aaand another one. https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/60001/scm/stencil.scm#newcode66 scm/stencil.scm:66: (if (equal? start stop) I think that's

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/13 21:51:19, dak wrote: Sorry for yet finding more stuff that, after all, could likely be improved. At least I did so pretty quickly this time. No problem! The code became so much better during revision! I have to work too much in my regular job to upload more than one patch-set

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/13 22:38:02, thomasmorley651 wrote: On 2015/11/13 21:51:19, dak wrote: > Sorry for yet finding more stuff that, after all, could likely be improved. At > least I did so pretty quickly this time. No problem! The code became so much better during revision! I have to work too much

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/12 15:20:51, dak wrote: On 2015/11/11 09:56:16, thomasmorley651 wrote: > Well, outer/inner-control rely on the user-settable variables bow-height and > thickness. Ok, didn't notice that. I'm not sure it's the best interface to have those in semi-absolute dimensions but at

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/10 20:52:18, dak wrote: https://codereview.appspot.com/270640043/diff/40001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/40001/scm/stencil.scm#newcode73 scm/stencil.scm:73: (width (- (car stop) (car start))) I'd not use `width' (and

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

On 2015/11/08 23:54:37, dak wrote: On 2015/11/08 23:22:51, thomasmorley651 wrote: > https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm > File scm/stencil.scm (right): > > https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode88 > scm/stencil.scm:88: (sqrt

Re: quarter tones in tablature (issue 272320043 by thomasmorle...@gmail.com)

On 2015/11/08 14:22:26, dak wrote: I'm currently trying to get tax declarations finished with a very very looming deadline, so I am worse at doing reviews properly than I am anyway. This one hit me in the face though and would warrant changing before people start relying on it. Ok.

Re: quarter tones in tablature (issue 272320043 by thomasmorle...@gmail.com)

On 2015/11/08 21:51:27, dak wrote: On 2015/11/08 20:19:16, thomasmorley651 wrote: > On 2015/11/08 14:22:26, dak wrote: > > > https://codereview.appspot.com/272320043/diff/1/scm/translation-functions.scm > > File scm/translation-functions.scm (right): > > > > >

make supportNonIntegerFret a context-property (issue 277860043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review this is a follow up to issue 4643 https://sourceforge.net/p/testlilyissues/issues/4643/ see discussion: https://codereview.appspot.com/272320043/ Description: make supportNonIntegerFret a context-property restores the arguments of determine-frets (changed

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/20001/scm/stencil.scm#newcode88 scm/stencil.scm:88: (sqrt (+ (* width width) (* height height On 2015/11/08 21:22:04, dak wrote: Is there a reason

Issue 4654: offset-fret modifies its definition (issue 276810043 by d...@gnu.org)

LGTM https://codereview.appspot.com/276810043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

thanks for review https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm File scm/stencil.scm (right): https://codereview.appspot.com/270640043/diff/1/scm/stencil.scm#newcode50 scm/stencil.scm:50: @var{bow-height} determines the heigth of the bow. On 2015/11/04 00:28:27,

Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie (issue 270640043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review Description: Implement make-bow-stencil, make-tie-stencil for use in markup-commands undertie and overtie issue 3088 In a follow up it is planned to replace make-parenthesis-stencil with an appropiate setting of make-bow-stencil and to partially rework the

quarter tones in tablature (issue 272320043 by thomasmorle...@gmail.com)

Reviewers: , Message: Please review Description: quarter tones in tablature issue 4643 micro-tones in TabStaff are now printable. Unless the chosen string-tuning will allow it, this feature is disabled for FretBoards. - changing determine-frets (adding an optional argument) and

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

On 2015/10/30 21:46:55, benko.pal wrote: > And PostScript (and PDF and METAFONT) _do_ represent angles in degrees. > So it's sort of silly that we cannot get an angle of 180 degrees > straight into PostScript without change. now that convinced me. if we want to output angles in degrees, we

fix unwanted capo indication in fret diagrams (issue 272150043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review Description: fix unwanted capo indication in fret diagrams issue 4644 Adding a condition to do 1+ for capo-fret only if open strings are absent and capo-fret is not zero Please review this at https://codereview.appspot.com/272150043/ Affected files (+3,

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

On 2015/10/21 09:32:07, dak wrote: https://codereview.appspot.com/269530043/diff/40001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/269530043/diff/40001/scm/lily-library.scm#newcode721 scm/lily-library.scm:721: (moved-angle (- angle (/ (* quadrant

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

This oe is about radians vs degrees On 2015/10/20 14:25:21, dak wrote: Fundamentally, we cannot fix this properly at the Scheme layer: even in GUILE-2.0, we get scheme@(guile-user)> (sin (atan 0 -1)) $1 = 1.2246467991473532e-16 I think what we should be aiming for is grounding

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

Let me split my reply into two. This one about the current patch and how to proceed. On 2015/10/20 14:25:21, dak wrote: I'm not really enthused about this approach even though it originates from a proposal of mine. It works basically by moving around problematic angles, exactly leading

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

On 2015/10/20 22:54:17, thomasmorley651 wrote: no need for code-duplications, increasing readability of cyclic-base-value patch set 2 does some clean up, but not adressing comment #2 https://codereview.appspot.com/269530043/ ___ lilypond-devel

Re: modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

https://codereview.appspot.com/269530043/diff/40001/scm/lily-library.scm File scm/lily-library.scm (right): https://codereview.appspot.com/269530043/diff/40001/scm/lily-library.scm#newcode751 scm/lily-library.scm:751: (cyclic-base-value (+ value cycle) cycle)) what are those red dots?? Never

modify coord-rotate to get exact values for (sin PI) etc (issue 269530043 by thomasmorle...@gmail.com)

Reviewers: , Message: please review Description: modify coord-rotate to get exact values for (sin PI) etc issue 4640 Done by switching to appropiate values for the angle and/or switching sin to cos and vice versa Please review this at https://codereview.appspot.com/269530043/ Affected files

Re: Simplify coord-rotate (issue 263690043 by d...@gnu.org)

Please disregard my code from comment #1, it's fishy. More appropiate would be (dropping the idea to rotate around other ponts than zero): #(define (get-PI/4-rotated-quadrants radians) (cond ((>= radians TWO-PI) (get-PI/4-rotated-quadrants (- radians TWO-PI))) ((< radians 0)

<    1   2   3   4   5   >