Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread david . nalesnik
Reviewers: , Message: Please review. Description: Add Scheme function to return column associated with Item. The C++ function PaperColumn::get_column is used frequently, and it makes sense to have a Scheme function which performs the same task. An example of a practical application is the

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread Urs Liska
Can't judge the code but the idea looks great :-) Urs Am 15. Februar 2015 08:27:20 EST, schrieb david.nales...@gmail.com: Reviewers: , Message: Please review. Description: Add Scheme function to return column associated with Item. The C++ function PaperColumn::get_column is used frequently,

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread David Nalesnik
On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska u...@openlilylib.org wrote: Can't judge the code but the idea looks great :-) Thanks--I'm noticing that bits of code get reused on the lists, so there's a need. This will help tuck away some of the code gobbledygook that is so off-putting.. It

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread David Nalesnik
On Sun, Feb 15, 2015 at 12:34 PM, Thomas Morley thomasmorle...@gmail.com wrote: 2015-02-15 19:28 GMT+01:00 Thomas Morley thomasmorle...@gmail.com: Oops, definition for 'grob-name' is missing: #(define grob-name (lambda (x) (if (ly:grob? x) (assq-ref (ly:grob-property x

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread Thomas Morley
2015-02-15 18:50 GMT+01:00 David Nalesnik david.nales...@gmail.com: On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska u...@openlilylib.org wrote: Can't judge the code but the idea looks great :-) Thanks--I'm noticing that bits of code get reused on the lists, so there's a need. This will help

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread Thomas Morley
2015-02-15 19:28 GMT+01:00 Thomas Morley thomasmorle...@gmail.com: 2015-02-15 18:50 GMT+01:00 David Nalesnik david.nales...@gmail.com: On Sun, Feb 15, 2015 at 7:58 AM, Urs Liska u...@openlilylib.org wrote: Can't judge the code but the idea looks great :-) Thanks--I'm noticing that bits of

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread David Nalesnik
Hi Harm, On Sun, Feb 15, 2015 at 12:28 PM, Thomas Morley thomasmorle...@gmail.com wrote: Some time ago I wrote a more generic code: #(define (look-up-for-parent name-symbol axis grob) Return the parent of @var{grob}, specified by it's @var{name-symbol} in axis @var{axis}. If not

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread David Nalesnik
On Sun, Feb 15, 2015 at 1:14 PM, David Nalesnik david.nales...@gmail.com wrote: Now, a function to get a grob's name would certainly be useful. I'm sick to death of constantly recreating it or looking it up (as I bet you are)! If there's a question of usefulness, I think we've established

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread Thomas Morley
2015-02-15 20:14 GMT+01:00 David Nalesnik david.nales...@gmail.com: On Sun, Feb 15, 2015 at 12:34 PM, Thomas Morley thomasmorle...@gmail.com wrote: 2015-02-15 19:28 GMT+01:00 Thomas Morley thomasmorle...@gmail.com: Oops, definition for 'grob-name' is missing: #(define grob-name

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread Thomas Morley
2015-02-15 20:56 GMT+01:00 David Nalesnik david.nales...@gmail.com: On Sun, Feb 15, 2015 at 1:14 PM, David Nalesnik david.nales...@gmail.com wrote: Now, a function to get a grob's name would certainly be useful. I'm sick to death of constantly recreating it or looking it up (as I bet you

Re: Add Scheme function to return column associated with Item. (issue 203910043 by david.nales...@gmail.com)

2015-02-15 Thread David Nalesnik
Harm, On Sun, Feb 15, 2015 at 2:42 PM, Thomas Morley thomasmorle...@gmail.com wrote: Can't review C++, so I'll not post there. There IS something you can help with, though. In the patch as it stands, I'm simply making Grob::name available through Scheme. It thus returns a string.