Update on http://code.google.com/p/lilypond/issues/detail?id=1517
http://codereview.appspot.com/4172047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2011/02/15 13:17:01, Bertrand Bordage wrote:
Update on http://code.google.com/p/lilypond/issues/detail?id=1517
I've added this to codereview.
Bertrand, could you upload it to codereview yourself, with a new
codereview issue number? I think the instructions in the Contributor's
Guide are
Yes, sorry...
I made a new codereview issue : http://codereview.appspot.com/4182056/
...(currently reading the Contributor's Guide again)...
http://codereview.appspot.com/4172047/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: ,
Message:
LGTM.
Description:
Add dots to tocItemMarkup
* New markup command fill-with-dots
* Add it to tocItemMarkup
Please review this at http://codereview.appspot.com/4172047/
Affected files:
M ly/toc-init.ly
M scm/define-markup-commands.scm
Index: ly/toc-init.ly
diff
I like the idea.
I think to become part of the distribution it needs to support both
postscript and svg.
Thanks,
Carl
http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm
File scm/define-markup-commands.scm (right):
http://codereview.appspot.com/4172047/diff/1/scm/define-markup-commands.scm#newcode1033
scm/define-markup-commands.scm:1033: #:with-dimensions (cons 0
middle-width) '(0 . 0)
