Re: Add harmonic by fret and by ratio to tablatures (issue3326042)

2010-12-03 Thread Carl . D . Sorensen
This code has now been integrated in the tab-tie-follow-engraver changes, due to my mistakes in git. Please see http://codereview.appspot.com/2723043/ Thanks, Carl http://codereview.appspot.com/3326042/ ___ lilypond-devel mailing list

Re: Add harmonic by fret and by ratio to tablatures (issue3326042)

2010-11-28 Thread Marc Hohl
Am 28.11.2010 05:23, schrieb carl.d.soren...@gmail.com: Reviewers: marc, p.l.schmidt_gmx.de, Message: I've taken Marc's harmonic.ly and moved the scheme functions into scm/tablature.scm, the music functions into ly/engraver-init.ly, and the test music into

Re: Add harmonic by fret and by ratio to tablatures (issue3326042)

2010-11-28 Thread Patrick Schmidt
Am 28.11.2010 um 10:22 schrieb Marc Hohl: Am 28.11.2010 05:23, schrieb carl.d.soren...@gmail.com: Reviewers: marc, p.l.schmidt_gmx.de, Message: I've taken Marc's harmonic.ly and moved the scheme functions into scm/tablature.scm, the music functions into ly/engraver-init.ly, and the test

Re: Add harmonic by fret and by ratio to tablatures (issue3326042)

2010-11-28 Thread Carl . D . Sorensen
I forgot to mention that this patch applies on top of http://codereview.appspot.com/2723043/ Thanks, Carl http://codereview.appspot.com/3326042/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Add harmonic by fret and by ratio to tablatures (issue3326042)

2010-11-27 Thread Carl . D . Sorensen
Reviewers: marc, p.l.schmidt_gmx.de, Message: I've taken Marc's harmonic.ly and moved the scheme functions into scm/tablature.scm, the music functions into ly/engraver-init.ly, and the test music into input/regression/tablature-harmonic-functions.ly. I've also added docstrings for the functions