Re: Add option to indicate frets by letters in tablature(issue164063)

Trevor Daniels Monday, December 21, 2009 1:07 AM , Sunday, December 20, 2009 9:48 PM On 2009/12/14 12:13:07, t.daniels_treda.co.uk wrote: So is http://codereview.appspot.com/164063 now ready to go? The indentation in translation-functions.scm is still a bit wrong, but apart from that, it

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/21/09 1:55 AM, "Trevor Daniels" wrote: > > > Carl Sorensen wrote Monday, December 21, 2009 12:58 AM > >> I've never had anybody turn down a patch by me because I had the >> wrong >> number of indents, ore even call me on it, because the rules are >> not well >> enough understood by us

Re: Add option to indicate frets by letters in tablature (issue164063)

Carl Sorensen wrote Monday, December 21, 2009 12:58 AM I've never had anybody turn down a patch by me because I had the wrong number of indents, ore even call me on it, because the rules are not well enough understood by us mere mortals (it's all in the indenter code). I think if you always d

Re: Add option to indicate frets by letters in tablature (issue164063)

, Sunday, December 20, 2009 9:48 PM On 2009/12/14 12:13:07, t.daniels_treda.co.uk wrote: I think I've corrected the formatting errors as you suggested. Could you please explain when I should use a 1-space indent and when 2-space, please, otherwise this seems just arbitrary. I do find a 1-

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/20/09 2:48 PM, "n.putt...@gmail.com" wrote: > On 2009/12/14 12:13:07, t.daniels_treda.co.uk wrote: > >> I think I've corrected the formatting errors as you suggested. >> Could you please >> explain when I should use a 1-space indent and when 2-space, please, >> otherwise >> this seems j

Re: Add option to indicate frets by letters in tablature (issue164063)

On 2009/12/14 12:13:07, t.daniels_treda.co.uk wrote: I think I've corrected the formatting errors as you suggested. Could you please explain when I should use a 1-space indent and when 2-space, please, otherwise this seems just arbitrary. I do find a 1-space indent makes it more difficult to se

Re: Add option to indicate frets by letters in tablature(issue164063)

Trevor Daniels wrote Monday, December 14, 2009 12:12 PM Sorry about the trailing spaces. I was used to my Windows editor removing them automatically; gedit can't, AFAICS. However, I've just discovered that git rebase --warning=fix will remove them, --whitespace=fix of course! Trevor

Re: Add option to indicate frets by letters in tablature (issue164063)

rt. So is http://codereview.appspot.com/164063 now ready to go? I'll amend the docs after pushing. Trevor - Original Message - From: To: ; Cc: ; Sent: Sunday, December 13, 2009 7:54 PM Subject: Re: Add option to indicate frets by letters in tablature (issue164063) Hi Trevor, Here a

Re: Add option to indicate frets by letters in tablature (issue164063)

Hi Trevor, Here are a few comments as promised earlier. Cheers, Neil http://codereview.appspot.com/164063/diff/5001/5002 File Documentation/changes.tely (right): http://codereview.appspot.com/164063/diff/5001/5002#newcode73 Documentation/changes.tely:73: \new TabStaff trailing space http://c

Re: Add option to indicate frets by letters in tablature (issue164063)

> Check out > http://en.wikipedia.org/wiki/File:Calligraphy.malmesbury.bible.arp.jpg>, > first letter in the next to last line. "cognationum" starts with a "c". > You'll see where the confusion about blackletter "c" being either r or > gamma arises. the line above that has a better exemplar, at

Re: Add option to indicate frets by letters in tablature (issue164063)

dem...@suffolk.lib.ny.us writes: > 'c' marks fret 2 in French tab. > > Correct is to think of it as 'c', employ that concept internally, and in > any documentation. Draw it as a gamma-like glyph in fonts emulating those > hands and fonts which do so historically; but encode it in those fonts as >

Re: Add option to indicate frets by letters in tablature (issue164063)

> Thanks for this, Dana. We're some way off implementing > fonts, or whatever means we select for rendering specific > lettering I realize that, what i was concerned with is that the technology for flexibility be in place. When the time comes, you will want to have done some surveying of origin

Re: Add option to indicate frets by letters in tablature (issue164063)

hanisms of LilyPond and implementing some rather basic facilities. Trevor - Original Message - From: To: "Carl Sorensen" Cc: "Ian Hulin" ; "Trevor Daniels" ; ; ; ; Sent: Tuesday, December 08, 2009 12:23 AM Subject: Re: Add option to indicate frets by lette

Re: Add option to indicate frets by letters in tablature (issue164063)

>> Fret 3 was lettered as ɣ, which was rendered in some contemporary >> engravings >> to look a bit like a fancy r, so some modern transcriptions of the >> tablature >> turn it into an r.  If we're going to re-render ɣ, why not do it as c, >> and >> keep the logical letter sequence.  > > My p

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/7/09 9:30 AM, "dem...@suffolk.lib.ny.us" wrote: > > >> Dana suggests "course", which I guess speaks well to lute players. But >> not >> to guitar players. > > 12 course guitar anyone? In my experience we call it a 12-string guitar (but as you correctly point out, there are only 6-co

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/7/09 11:00 AM, "Ian Hulin" wrote: > Hi Carl, > > Carl Sorensen wrote: >> >> >> On Dec 6, 2009, at 7:18 PM, "Ian Hulin" >> wrote: >> >> >> >>> >>> Carl, Trevor, >>> >>> You've discussed the overloading of 'string' in Scheme and what >>> variable >

Re: Add option to indicate frets by letters in tablature (issue164063)

Hi Carl, Carl Sorensen wrote: On Dec 6, 2009, at 7:18 PM, "Ian Hulin" wrote: Carl, Trevor, You've discussed the overloading of 'string' in Scheme and what variable name to use, and looked at Dana's suggestion of using 'course' but did you consider the other important point Dana made?

Re: Add option to indicate frets by letters in tablature (issue164063)

What I am trying to say comes from my own experiences writing a gui program to do tab typesetting on macintosh. My software records {course,fret} data for each note in the score, and pitch information for each course on the instrument (simplifying courses with octaves as split play is very rare)

Re: Add option to indicate frets by letters in tablature (issue164063)

Carl Sorensen wrote Monday, December 07, 2009 4:20 PM On 12/6/09 5:18 PM, "Trevor Daniels" wrote: I prefer str to course and string, but if no other ideas are forthcoming I'll use string_number. In Scheme files, the variable name should be string-number. In c++ files it would be string_nu

Re: Add option to indicate frets by letters in tablature (issue164063)

> Dana suggests "course", which I guess speaks well to lute players. But > not > to guitar players. 12 course guitar anyone? maybe ts a classical guitar hing, but I also remember tutorials discussing 6-course instruments. > I had envisioned that a full set of fretLetters would be given At le

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/6/09 5:18 PM, "Trevor Daniels" wrote: > > I prefer str to course and string, but if no other ideas > are forthcoming I'll use string_number. > In Scheme files, the variable name should be string-number. In c++ files it would be string_number. Thanks, Carl ___

Re: Add option to indicate frets by letters in tablature (issue164063)

Carl Sorensen wrote Monday, December 07, 2009 1:51 AM On Dec 6, 2009, at 5:18 PM, "Trevor Daniels" wrote: Carl Sorensen wrote Sunday, December 06, 2009 9:59 PM . The fretLabels list wouldn't need to be characters; they could be markups or stencils, so users could define whatever is ne

Re: Add option to indicate frets by letters in tablature (issue164063)

Dana Emery wrote Sunday, December 06, 2009 9:37 PM Let the choice of font display a glyph in the proper shape. Provide the user with a way to display arbitrary glyphs and ligatures for each encoded 'stop'. This will be useful for bass stops (/a /b /c... //a //b //c, ///a) and essential f

Re: Add option to indicate frets by letters in tablature (issue164063)

On Dec 6, 2009, at 7:18 PM, "Ian Hulin" wrote: > Carl, Trevor, > > You've discussed the overloading of 'string' in Scheme and what > variable > name to use, and looked at Dana's suggestion of using 'course' but did > you consider the other important point Dana made? I think so. That's why I

Re: Add option to indicate frets by letters in tablature (issue164063)

Carl, Trevor, You've discussed the overloading of 'string' in Scheme and what variable name to use, and looked at Dana's suggestion of using 'course' but did you consider the other important point Dana made? dem...@suffolk.lib.ny.us wrote: Hhm, I'm not so sure about this. I had envisaged

Re: Add option to indicate frets by letters in tablature (issue164063)

On Dec 6, 2009, at 5:18 PM, "Trevor Daniels" wrote: > > Carl Sorensen wrote Sunday, December 06, 2009 9:59 PM >> >> On 12/6/09 9:50 AM, "Trevor Daniels" >> wrote: >>> >>> I changed it because "string" is a keyword in Scheme. >>> It is even used as such in the same few lines of code. >>> Alt

Re: Add option to indicate frets by letters in tablature (issue164063)

Carl Sorensen wrote Sunday, December 06, 2009 9:59 PM On 12/6/09 9:50 AM, "Trevor Daniels" wrote: I changed it because "string" is a keyword in Scheme. It is even used as such in the same few lines of code. Although "string" can be used as a variable name I don't think it should be - it see

Re: Add option to indicate frets by letters in tablature (issue164063)

On 12/6/09 9:50 AM, "Trevor Daniels" wrote: > Hi Carl > > Thanks for taking a look at this. > > You wrote Sunday, December 06, 2009 3:23 PM> >> >> http://codereview.appspot.com/164063/diff/2001/3008 >> File scm/translation-functions.scm (right): >> >> http://codereview.appspot.com/164063/d

Re: Add option to indicate frets by letters in tablature (issue164063)

> I fully agree with your point in general, but we need > to think of a variable name other than "string" for the > string on an instrument. I tried, and failed :(, hence > str. String is only completely correct for instruments like violins that have a single string per course. 'course' is the

Re: Add option to indicate frets by letters in tablature (issue164063)

Hi Carl Thanks for taking a look at this. You wrote Sunday, December 06, 2009 3:23 PM> http://codereview.appspot.com/164063/diff/2001/3008 File scm/translation-functions.scm (right): http://codereview.appspot.com/164063/diff/2001/3008#newcode393 scm/translation-functions.scm:393: (define-publ

Re: Add option to indicate frets by letters in tablature (issue164063)

Looks great to me. I have a couple of comments. Thanks for doing this! Carl http://codereview.appspot.com/164063/diff/2001/3008 File scm/translation-functions.scm (right): http://codereview.appspot.com/164063/diff/2001/3008#newcode393 scm/translation-functions.scm:393: (define-public (fret-l

Re: Add option to indicate frets by letters in tablature (issue164063)

--- Original Message - From: To: Cc: ; Sent: Wednesday, December 02, 2009 10:19 PM Subject: Add option to indicate frets by letters in tablature (issue164063) Hi Trevor, This looks OK apart from a few minor details (I've mentioned the interface/doc issues in the main thread). I

Add option to indicate frets by letters in tablature (issue164063)

Hi Trevor, This looks OK apart from a few minor details (I've mentioned the interface/doc issues in the main thread). I look forward to the next instalment. Cheers, Neil http://codereview.appspot.com/164063/diff/1/2 File input/regression/tablature-letter.ly (right): http://codereview.appspot