https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm#newcode2118
scm/music-functions.scm:2118: (let* ((immutable
(ly:grob-basic-properties grob))
I just noticed
On 2013/10/20 15:51:57, david.nalesnik wrote:
https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm#newcode2118
scm/music-functions.scm:2118: (let* ((immutable
On 2013/10/20 16:15:56, dak wrote:
On 2013/10/20 15:51:57, david.nalesnik wrote:
https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/48001/scm/music-functions.scm#newcode2118
On 2013/10/20 20:35:20, david.nalesnik wrote:
OK, that makes sense. I've rewritten offset according to these
guidelines. A
side benefit
is that it was no trouble to allow directed tweaks, so the following
is
possible:
{
c'' e'' \offset AccidentalPlacement.right-padding #2 ges''!4
Hi,
an afterthought.
On 2013/10/06 01:15:12, david.nalesnik wrote:
The examples below represent my efforts to test the effects of
multiple
applications of \offset. You can see that some accumulation is
possible.
[...]
\relative c' {
%% TESTS FOR ACCUMULATION %%
% default
On 2013/10/15 18:04:43, janek wrote:
Hi,
an afterthought.
On 2013/10/06 01:15:12, david.nalesnik wrote:
The examples below represent my efforts to test the effects of
multiple
applications of \offset. You can see that some accumulation is
possible.
[...]
\relative c' {
%%
2013/10/15 d...@gnu.org:
On 2013/10/15 18:04:43, janek wrote:
Well, that's the slightly icky thing. The \offset is with respect to
the situation you'll get when doing \revert Arpeggio.positions
afterwards. So if you want to make a _relative_ offset to the first
setting, you have to do
On 2013/10/06 06:06:40, lemzwerg wrote:
LGTM.
Maybe you can somewhere add a sentence like
Note that \tweak and friends provide absolute positioning, not
relative.
to the documentation. It took me a while to recognize the difference.
OK--will do. (I just made some changes to the
On 2013/10/06 01:15:12, david.nalesnik wrote:
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5
input/regression/offsets.ly:5: the
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly#newcode31
input/regression/offsets.ly:31:
Spurious space in otherwise empty line.
https://codereview.appspot.com/8647044/diff/35001/scm/c++.scm
File scm/c++.scm (right):
https://codereview.appspot.com/8647044/diff/35001/scm/c++.scm#newcode30
scm/c++.scm:30: (not (null? x))
Why not null? An empty list is also a list, so this makes the predicate
a bit of a misnomer.
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/35001/input/regression/offsets.ly#newcode31
input/regression/offsets.ly:31:
On 2013/10/07 14:10:32, dak wrote:
Spurious space in
On 2013/10/07 14:10:09, dak wrote:
On 2013/10/06 01:15:12, david.nalesnik wrote:
There is a major problem with this patch set which I don't know how
to
address.
The examples below represent my efforts to test the effects of
multiple
applications of \offset. You can see that some
https://codereview.appspot.com/8647044/diff/48001/ly/music-functions-init.ly
File ly/music-functions-init.ly (right):
https://codereview.appspot.com/8647044/diff/48001/ly/music-functions-init.ly#newcode705
ly/music-functions-init.ly:705: (if (ly:music? item)
Ok, I am annoyed at the necessity
LGTM.
Maybe you can somewhere add a sentence like
Note that \tweak and friends provide absolute positioning, not
relative.
to the documentation. It took me a while to recognize the difference.
https://codereview.appspot.com/8647044/
___
Just before I forget: this is not a real comment on this issue.
David N posted some update on this issue maybe a week ago (details are
not all that important) after it lay dormant for months. I replied to
that issue, and then figured I apparently didn't properly reply since
Rietveld flagged
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5
input/regression/offsets.ly:5: the @code{\\offset} command. These
properties are limited
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm
File scm/c++.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm#newcode30
scm/c++.scm:30: (every number-pair? x)))
On 2013/04/23 20:24:57, dak wrote:
Isn't it dangerous to call every on something that is not
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103
scm/music-functions.scm:2103: ; head of the alist. We reverse the alist
so our search will return
On 2013/10/04 01:17:08, david.nalesnik wrote:
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm
File scm/c++.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/c++.scm#newcode30
scm/c++.scm:30: (every number-pair? x)))
On 2013/04/23 20:24:57, dak wrote:
Isn't it
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103
scm/music-functions.scm:2103: ; head of the alist. We reverse the alist
so our search will return
David,
Thank you for your reviews. It will take me some time to make the
changes you propose, so I've changed the status of the patch to needs
work.
https://codereview.appspot.com/8647044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
anyway, this patch LTGM.
https://codereview.appspot.com/8647044/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2013/04/23 13:14:23, janek wrote:
anyway, this patch LTGM.
Thanks, Janek!
The patch has passed countdown, but in view of the fact that a stable
release is on the horizon, it may not be appropriate to push it at this
time.
On the other hand, an argument for pushing it right away might be
On 2013/04/23 19:03:18, david.nalesnik wrote:
On 2013/04/23 13:14:23, janek wrote:
anyway, this patch LTGM.
Thanks, Janek!
The patch has passed countdown, but in view of the fact that a stable
release is
on the horizon, it may not be appropriate to push it at this time.
On the other
On 2013/04/23 19:38:09, dak wrote:
On 2013/04/23 19:03:18, david.nalesnik wrote:
On 2013/04/23 13:14:23, janek wrote:
anyway, this patch LTGM.
Thanks, Janek!
The patch has passed countdown, but in view of the fact that a
stable release
is
on the horizon, it may not be appropriate to
Sorry for the late review.
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly
File input/regression/offsets.ly (right):
https://codereview.appspot.com/8647044/diff/5001/input/regression/offsets.ly#newcode5
input/regression/offsets.ly:5: the @code{\\offset} command.
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm
File scm/music-functions.scm (right):
https://codereview.appspot.com/8647044/diff/5001/scm/music-functions.scm#newcode2103
scm/music-functions.scm:2103: ; head of the alist. We reverse the alist
so our search will return
Sorry for the delay, got little lilypond-time recently...
2013/4/16 d...@gnu.org:
On 2013/04/16 14:33:50, janek wrote:
2013/4/16 d...@gnu.org:
nothing-or-music in the last position only works if nothing is
_explicitly_ specified with \default
There is no way that the last argument of
Janek Warchoł janek.lilyp...@gmail.com writes:
Sorry for the delay, got little lilypond-time recently...
2013/4/16 d...@gnu.org:
On 2013/04/16 14:33:50, janek wrote:
2013/4/16 d...@gnu.org:
nothing-or-music in the last position only works if nothing is
_explicitly_ specified with
I've considerably shortened the regtests, removing redundancies and
unnecessary line breaks. Thanks for the comments!
https://codereview.appspot.com/8647044/diff/1/input/regression/offsets.ly
File input/regression/offsets.ly (right):
On 2013/04/13 21:39:40, janek wrote:
There's one thing that puzzles me. Current syntax is
\offset property offset-value grob-name
I understand that grob-name is at the end because it's optional, and
we want to
omit it when we're using \offset as a tweak.
However, i find this syntax
On 2013/04/16 12:50:47, david.nalesnik wrote:
On 2013/04/13 21:39:40, janek wrote:
There's one thing that puzzles me. Current syntax is
\offset property offset-value grob-name
I understand that grob-name is at the end because it's optional, and
we want
to
omit it when we're using
On 2013/04/16 13:03:25, dak wrote:
On 2013/04/16 12:50:47, david.nalesnik wrote:
Here I kept the same pattern as \alterBroken and \shape,
as they have been revised by David Kastrup. I agree that
the syntax is a little awkward, and that
it would be nice if the pattern you give were workable.
and there's too many or-nothings there (i suppose
that the biggest problem is an optional argument
followed by non-optional one (value)). However,
in case of \offset, we can have either a \shape-like
syntax
\offset property value grobname-or-music
or
\offset grobwithproperty-or-property
On 2013/04/16 14:33:50, janek wrote:
2013/4/16 d...@gnu.org:
nothing-or-music in the last position only works if nothing is
_explicitly_ specified with \default
There is no way that the last argument of a music function can be
nothing silently.
pity. would it possible (and
2013/4/16 d...@gnu.org:
and there's too many or-nothings there (i suppose
that the biggest problem is an optional argument
followed by non-optional one (value)). However,
in case of \offset, we can have either a \shape-like
syntax
\offset property value grobname-or-music
or
\offset
Reviewers: ,
Message:
Please review.
Thanks,
David
Description:
Add the command \offset to LilyPond
The ability to offset default values of various properties would be a
useful enhancement of LilyPond. Currently, this is possible for the
property 'control-points using the \shape command.
There's one thing that puzzles me. Current syntax is
\offset property offset-value grob-name
I understand that grob-name is at the end because it's optional, and we
want to omit it when we're using \offset as a tweak.
However, i find this syntax awkward. Since David K's change that allowed
to
39 matches
Mail list logo
