Reviewers: Bertrand Bordage, Neil Puttock, dak,
Message:
Hey all,
I've made all of the requested changes save Spring::equal_p, as I can't
see a clear consensus about what changes need to be made here. As this
problem is outside the purview of this patch, it may be worth it to
propose another pa
On 21 October 2011 12:39, wrote:
> For me, this function is totally useless. If we want to check whether
> they are equal, we use scm_equal_p, if we want to see whether they are
> the same object, we use scm_eqv_p.
>
> Besides, I can't find any use for this function with git grep.
I think Guil
On 2011/10/21 11:39:41, Bertrand Bordage wrote:
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
O
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:27:35, dak wrote:
scm_is_true (scm
On 2011/10/21 11:27:34, dak wrote:
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc
File lily/spring-smob.cc (left):
http://codereview.appspot.com/5306050/diff/2001/lily/spring-smob.cc#oldcode42
lily/spring-smob.cc:42: return a == b ? SCM_BOOL_T : SCM_BOOL_F;
On 2011/10/21 11:18:06, Neil Puttock wrote:
Not sur
http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc
File lily/spring-smob.cc (right):
http://codereview.appspot.com/5306050/diff/1/lily/spring-smob.cc#newcode48
lily/spring-smob.cc:48: "spring, and @code{min-dist} is the minimum
distance.")
@var{min-dist}
http://codereview.appspot.
LGTM.
http://codereview.appspot.com/5306050/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
