Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread dak
Reviewers: david.nalesnik, janek, Message: On 2012/10/03 05:04:11, janek wrote: i've skimmed over the discussion in http://code.google.com/p/lilypond/issues/detail?id=2858 and i'm confused. Do we want to change \shape GrobName #'offsets into \shape #'offsets GrobName or \shape #'offsets

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread dak
On 2012/10/02 23:39:05, david.nalesnik wrote: LGTM [...] I wonder if it would be helpful to alter one or two of the following applications of the function as override to the tweak form. [...] What about adding a demonstration here of the ability to modify curves beginning at the same

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread david . nalesnik
On 2012/10/03 13:57:25, dak wrote: [...] To those suggestions let me answer with the famous answer to the question Mr Gandhi, what do you think of Western civilization?, namely with I would consider it a good idea. Oh, for just one zinger like that... So the best I think I can do at

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread dak
On 2012/10/03 15:08:30, david.nalesnik wrote: On 2012/10/03 13:57:25, dak wrote: [...] To those suggestions let me answer with the famous answer to the question Mr Gandhi, what do you think of Western civilization?, namely with I would consider it a good idea. Oh, for just one

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread david . nalesnik
On 2012/10/03 15:17:26, dak wrote: [...] and I am currently immersed in parser work to make the Context.GrobName thing fly. Thank you very much for working on this! I am looking forward to being able to fix the mess at the beginning of \alterBroken (and a general offsetting function I

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread Janek Warchoł
On Wed, Oct 3, 2012 at 3:46 PM, d...@gnu.org wrote: On 2012/10/03 05:04:11, janek wrote: i've skimmed over the discussion in http://code.google.com/p/lilypond/issues/detail?id=2858 and i'm confused. Do we want to change \shape GrobName #'offsets into \shape #'offsets GrobName or \shape

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread Trevor Daniels
david.nales...@gmail.com OK, I think I'll wait till this patch and the Trevor's documentation patch is through, and then I'll create a new issue for the regtests. I may simply leave these two as they are, and add a short test along the lines of, \shape works independently on curves

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread dak
On 2012/10/03 16:38:45, janek wrote: On Wed, Oct 3, 2012 at 3:46 PM, mailto:d...@gnu.org wrote: On 2012/10/03 05:04:11, janek wrote: i've skimmed over the discussion in http://code.google.com/p/lilypond/issues/detail?id=2858 and i'm confused. Do we want to change \shape GrobName #'offsets

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-03 Thread Janek Warchoł
On Wed, Oct 3, 2012 at 7:36 PM, d...@gnu.org wrote: ...but from this sentence i deduce that we're trying to do the second thing, i.e. \shape will have one #'offsets argument and no argument specifying grob name, which will be deduced from the music that follows the command. Right? Either

Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-02 Thread david . nalesnik
LGTM https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly File input/regression/shape-other-curves.ly (right): https://codereview.appspot.com/6585052/diff/1/input/regression/shape-other-curves.ly#newcode18 input/regression/shape-other-curves.ly:18: \override

Re: Allow \shape to tweak music, swap its arguments (issue 6585052)

2012-10-02 Thread janek . lilypond
i've skimmed over the discussion in http://code.google.com/p/lilypond/issues/detail?id=2858 and i'm confused. Do we want to change \shape GrobName #'offsets into \shape #'offsets GrobName or \shape #'offsets (used as a tweak, with GrobName being guessed)? Janek