Re: Allow left-handed fret-markups (issue 339270043 by thomasmorle...@gmail.com)

2018-01-23 Thread thomasmorley65
On 2018/01/23 09:55:04, dak wrote: mailto:thomasmorle...@gmail.com writes: > Yep, the difference between left- and right-handed are certain negative > instead of a positive values. > I'd love to use a multiplier retrieved from left-handed. > Though, how to code properly and user-friendly. >

Re: Allow left-handed fret-markups (issue 339270043 by thomasmorle...@gmail.com)

2018-01-23 Thread David Kastrup
thomasmorle...@gmail.com writes: > Yep, the difference between left- and right-handed are certain negative > instead of a positive values. > I'd love to use a multiplier retrieved from left-handed. > Though, how to code properly and user-friendly. > One could do > (1) separate conditions (that's

Re: Allow left-handed fret-markups (issue 339270043 by thomasmorle...@gmail.com)

2018-01-23 Thread thomasmorley65
On 2018/01/22 23:52:29, Carl wrote: Looks good to me, but I have one suggestion. Thanks, Carl https://codereview.appspot.com/339270043/diff/1/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): https://codereview.appspot.com/339270043/diff/1/scm/fret-diagrams.scm#newcode365

Re: Allow left-handed fret-markups (issue 339270043 by thomasmorle...@gmail.com)

2018-01-22 Thread Carl . D . Sorensen
Looks good to me, but I have one suggestion. Thanks, Carl https://codereview.appspot.com/339270043/diff/1/scm/fret-diagrams.scm File scm/fret-diagrams.scm (right): https://codereview.appspot.com/339270043/diff/1/scm/fret-diagrams.scm#newcode365 scm/fret-diagrams.scm:365: ((and (eq?

Allow left-handed fret-markups (issue 339270043 by thomasmorle...@gmail.com)

2018-01-22 Thread thomasmorley65
Reviewers: , Message: please review Description: Allow left-handed fret-markups By adding a new boolean subproperty: left-handed. - Extends Documentation/notation/fretted-strings.itely - Extends Documentation/changes.tely - Extenss scm/define-grob-properties.scm - Adds regtest