On 2013/03/26 04:10:38, mike7 wrote:
On 25 mars 2013, at 07:10, mailto:k-ohara5...@oco.net wrote:
Please do just one manual review of the regression suite between
versions before adding another test of this length.
I wanted to exhaust as many possibilities as I could think of (broken
slurs
On 9 avr. 2013, at 20:31, k-ohara5...@oco.net wrote:
On 2013/03/26 04:10:38, mike7 wrote:
On 25 mars 2013, at 07:10, mailto:k-ohara5...@oco.net wrote:
Please do just one manual review of the regression suite between
versions before adding another test of this length.
I wanted to
Hi Keith,
On 2013/04/04 06:48:22, Keith wrote:
I'll write a commit message, just so Janek can review the patch:
Break slurs between alternative endings in repeats; issue 1698.
Create new event-types BreakPhrasingSlurEvent BreakSlurEvent,
and a music-function \free \( so that users can
Hi,
please update the Rietveld issue description with current version of
commit message.
thanks,
Janek
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Looks good.
Gotta love monogamy.
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote:
Thanks for taking the time to do this. No-one else knows enough of the
various stages of processing to bring all the pieces together.
It looks like you try to use a common UP/DOWN direction for the portions
of a broken slur, and the
m...@mikesolomon.org wrote Monday, March 25, 2013 7:29 AM
On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote:
Conceptually, of course, there *are* two pieces. The other piece is
probably at the other end of the repeat. The automatic behavior is quite
good, so fortunately we will rarely
On Mon, 25 Mar 2013 00:29:35 -0700, m...@mikesolomon.org m...@mikesolomon.org
wrote:
On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote:
It looks like you try to use a common UP/DOWN direction for the portions
of a broken slur, and the image you posted to the bug-tracker showed a
common
On 26 mars 2013, at 05:58, Keith OHara k-ohara5...@oco.net wrote:
On Mon, 25 Mar 2013 00:29:35 -0700, m...@mikesolomon.org
m...@mikesolomon.org wrote:
On 25 mars 2013, at 07:10, k-ohara5...@oco.net wrote:
It looks like you try to use a common UP/DOWN direction for the portions
of a
Thanks for taking the time to do this. No-one else knows enough of the
various stages of processing to bring all the pieces together.
It looks like you try to use a common UP/DOWN direction for the portions
of a broken slur, and the image you posted to the bug-tracker showed a
common direction
At the start of the second alternative, we have an extra slur
start, the slur ends on beat 2, a phrasing slur starts on beat 3 and
at the end of the alternative, there is an extra slur end. Huh.
Works better with detached.
In this sentence, \phantom works quite nicely :-) This is still my
Since \partial is already taken, what about \cut? The
spanner gets cut a bit, right?
I can even imagine to use to commands, \start and \end to get, say,
`\start(' or `\end\'. Who knows, maybe this destinction is
advantageous sometime in the future.
Werner
I can even imagine to use to commands, \start and \end to get, say,
`\start(' or `\end\'. Who knows, maybe this destinction is
advantageous sometime in the future.
Maybe even better \startOf and \endOf.
Werner
___
lilypond-devel mailing list
On 20 mars 2013, at 07:25, Werner LEMBERG w...@gnu.org wrote:
I can even imagine to use to commands, \start and \end to get, say,
`\start(' or `\end\'. Who knows, maybe this destinction is
advantageous sometime in the future.
Maybe even better \startOf and \endOf.
Werner
The
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 06:07, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
Trying to put myself in the shoes of the average user, \fake would
not mean a function that uses a fake post event, but rather a
On 20 mars 2013, at 07:50, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 06:07, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
Trying to put myself in the shoes of the average user, \fake
m...@mikesolomon.org
I completely agree. It's just that fake in English means false or
counterfeit. It needs another word, just don't know what yet. unchained?
free?
At the risk of prolonging the bike-shedding, here's my take. For me, the key
consideration is to provide an easily
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 07:50, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
The word fake still doesn't sit right with me... There is nothing
fake about the slur:
{ a \fake ( b c d ) }
Mike, that
\fake and \broken are concise but feel wrong, implying something's
wrong with something else but the name doesn't describe it.
I think a function name where we've got to resort to being clever maybe
indicate we're trying to solve the wrong problem: we're trying to make
the name short at the
On 20 March 2013 12:35, ianhuli...@gmail.com wrote:
\fake and \broken are concise but feel wrong, implying something's
wrong with something else but the name doesn't describe it.
I think a function name where we've got to resort to being clever maybe
indicate we're trying to solve the wrong
On 2013/03/20 12:35:37, Ian Hulin (gmail) wrote:
\fake and \broken are concise but feel wrong, implying something's
wrong with something else but the name doesn't describe it.
Without pointing out what makes you think they feel wrong, that's not
helpful.
I think a function name where we've
Yet another possibility would be \inner but that implies a hierarchy.
More accurate would be \continued.
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
If the design needs it at both ends of the repeated block you could
consider a single keyword parameter for the function,
o \slurInRepeat #'begin - to appear at the end of the block and
indicate you're starting a new, partial slur and
o \slurInRepeat #'complete - to appear at the
And yet another would be \silent as a sort of negative variant of
\visual.
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
More accurate would be \continued.
https://codereview.appspot.com/7424049/
I like \interrupted
I can live with both \continued and \interrupted.
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hello
On 20 March 2013 13:40, Werner LEMBERG w...@gnu.org wrote:
More accurate would be \continued.
https://codereview.appspot.com/7424049/
I like \interrupted
I can live with both \continued and \interrupted.
Is that with two 'r's or two 'p's or both?
...
are you sure?
James
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 14:26, d...@gnu.org wrote:
Yet another possibility would be \inner but that implies a hierarchy.
More accurate would be \continued.
https://codereview.appspot.com/7424049/
I like \interrupted
I considered that but
Werner LEMBERG w...@gnu.org writes:
If the design needs it at both ends of the repeated block you could
consider a single keyword parameter for the function,
o \slurInRepeat #'begin - to appear at the end of the block and
indicate you're starting a new, partial slur and
o \slurInRepeat
James pkx1...@gmail.com writes:
Hello
On 20 March 2013 13:40, Werner LEMBERG w...@gnu.org wrote:
More accurate would be \continued.
https://codereview.appspot.com/7424049/
I like \interrupted
I can live with both \continued and \interrupted.
Is that
On 20 mars 2013, at 14:52, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 14:26, d...@gnu.org wrote:
Yet another possibility would be \inner but that implies a hierarchy.
More accurate would be \continued.
I think any further proposals should _definitely_ explain how to write
the given example
g f e d(
\repeat { c d) e f ( }
\alternatives {
{ g) a b( a \fake) }
{ \fake( e) d c( d \fake) }
{ \fake( d) c d( e }
}
d c) d c
Hmm. It's not clear to me why lilypond can't handle this
On 20 March 2013 15:01, m...@mikesolomon.org m...@mikesolomon.org wrote:
I don't completely follow what you're saying above - could you say it
another way?
I don't follow this whole developers discussion about choosing the best
command name for the users.
Please correct me if I'm wrong.
1.
Werner LEMBERG w...@gnu.org writes:
I think any further proposals should _definitely_ explain how to write
the given example
g f e d(
\repeat { c d) e f ( }
\alternatives {
{ g) a b( a \fake) }
{ \fake( e) d c( d \fake) }
{ \fake( d) c d( e }
}
d c) d c
Hmm. It's not clear
On 20 mars 2013, at 14:26, d...@gnu.org wrote:
Yet another possibility would be \inner but that implies a hierarchy.
More accurate would be \continued.
https://codereview.appspot.com/7424049/
I like \interrupted
Cheers,
MS
___
lilypond-devel
Sent from my iPhone
On 20 mars 2013, at 16:38, David Kastrup d...@gnu.org wrote:
Werner LEMBERG w...@gnu.org writes:
I think any further proposals should _definitely_ explain how to write
the given example
g f e d(
\repeat { c d) e f ( }
\alternatives {
{ g) a b( a \fake) }
{
On 20 mars 2013, at 18:25, m...@mikesolomon.org m...@mikesolomon.org wrote:
Sent from my iPhone
On 20 mars 2013, at 16:38, David Kastrup d...@gnu.org wrote:
Werner LEMBERG w...@gnu.org writes:
I think any further proposals should _definitely_ explain how to write
the given example
g
But TeX is separate enough from LilyPond that I actually like
\phantom rather well for this purpose.
Anything like phantom, fake and co doesn't sit right in
English. [...]
But there are millions of TeX users who are used to \phantom. And I
believe that a lot of Lilypond users are TeX
m...@mikesolomon.org m...@mikesolomon.org writes:
Even better, how about:
\anderston
The Anderston pedestrian bridge is a real life example of what we're
talking about.
http://en.m.wikipedia.org/wiki/M8_Bridge_to_Nowhere#section_3
I'm totally for this - it would be fantastic if people
Am 20.03.2013 19:10, schrieb Werner LEMBERG:
But there are millions of TeX users who are used to \phantom. And I
believe that a lot of Lilypond users are TeX users also. This means
that those users are already acquainted with this command and can
easily deduce what it does.
I think knowing
On 20 mars 2013, at 09:26, Trevor Daniels t.dani...@treda.co.uk wrote:
m...@mikesolomon.org
I completely agree. It's just that fake in English means false or
counterfeit. It needs another word, just don't know what yet. unchained?
free?
At the risk of prolonging the
Even better, how about:
\anderston
Uhmm, no. :-)
Werner
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 09:26, Trevor Daniels t.dani...@treda.co.uk wrote:
m...@mikesolomon.org
I completely agree. It's just that fake in English means false
or counterfeit. It needs another word, just don't know what yet.
unchained?
David Kastrup wrote Wednesday, March 20, 2013 10:38 PM
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 09:26, Trevor Daniels t.dani...@treda.co.uk wrote:
At the risk of prolonging the bike-shedding, here's my take. For
me, the key consideration is to provide an
Trevor Daniels t.dani...@treda.co.uk writes:
David Kastrup wrote Wednesday, March 20, 2013 10:38 PM
m...@mikesolomon.org m...@mikesolomon.org writes:
On 20 mars 2013, at 09:26, Trevor Daniels t.dani...@treda.co.uk wrote:
At the risk of prolonging the bike-shedding, here's my take. For
David Kastrup d...@gnu.org writes:
Trevor Daniels t.dani...@treda.co.uk writes:
What kind of word would people pick when describing a score on the
phone? For a single occurence, interrupted is likely a good
candidate, but five times in a row something catchier would likely
win. Probably
The most recent patch set copies direction from SlurEvents and
PhrasingSlurEvents, but this doesn't seem to work as intended (it fails
silently). Everything else is operational.
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
LGTM. I can't help with the problem you are mentioning, but I have the
feeling that the overall code has improved (and probably become simpler
also) w.r.t. previous versions of the patch. Congrats!
https://codereview.appspot.com/7424049/diff/53001/input/regression/repeat-slur.ly
File
https://codereview.appspot.com/7424049/diff/62001/input/regression/repeat-slur.ly
File input/regression/repeat-slur.ly (right):
https://codereview.appspot.com/7424049/diff/62001/input/regression/repeat-slur.ly#newcode9
input/regression/repeat-slur.ly:9: broken slur at a bar, use
@code{\broken}
On 2013/03/19 15:22:41, MikeSol wrote:
Two backslashes
After some consideration, I consider the name \broken suboptimal since
it implies two pieces. Two other possibilities would be \detached and
\fake.
https://codereview.appspot.com/7424049/
___
On 19 mars 2013, at 22:26, d...@gnu.org wrote:
On 2013/03/19 15:22:41, MikeSol wrote:
Two backslashes
After some consideration, I consider the name \broken suboptimal since
it implies two pieces. Two other possibilities would be \detached and
\fake.
After some consideration, I consider the name \broken suboptimal since
it implies two pieces. Two other possibilities would be \detached and
\fake.
I vote for detached.
I vote for \broken. For me, it doesn't imply two pieces. This was
David's first, quick suggestion, and I think it's
On 19 mars 2013, at 23:37, Werner LEMBERG w...@gnu.org wrote:
After some consideration, I consider the name \broken suboptimal since
it implies two pieces. Two other possibilities would be \detached and
\fake.
I vote for detached.
I vote for \broken. For me, it doesn't imply two
On 2013/03/19 22:37:14, wl_gnu.org wrote:
After some consideration, I consider the name \broken suboptimal
since
it implies two pieces. Two other possibilities would be \detached
and
\fake.
I vote for detached.
I vote for \broken. For me, it doesn't imply two pieces. This was
On 20 mars 2013, at 03:24, d...@gnu.org wrote:
On 2013/03/19 22:37:14, wl_gnu.org wrote:
After some consideration, I consider the name \broken suboptimal
since
it implies two pieces. Two other possibilities would be \detached
and
\fake.
I vote for detached.
I vote for \broken.
m...@mikesolomon.org m...@mikesolomon.org writes:
Trying to put myself in the shoes of the average user, \fake would not
mean a function that uses a fake post event, but rather a function
that produces a \fake something. I would think this makes a fake
slur, which is not the case.
It makes
On 20 mars 2013, at 06:07, David Kastrup d...@gnu.org wrote:
m...@mikesolomon.org m...@mikesolomon.org writes:
Trying to put myself in the shoes of the average user, \fake would not
mean a function that uses a fake post event, but rather a function
that produces a \fake something. I would
https://codereview.appspot.com/7424049/diff/41001/input/regression/repeat-slur.ly
File input/regression/repeat-slur.ly (right):
https://codereview.appspot.com/7424049/diff/41001/input/regression/repeat-slur.ly#newcode10
input/regression/repeat-slur.ly:10:
This should be rather
On 8 mars 2013, at 13:54, d...@gnu.org wrote:
https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly
File ly/spanners-init.ly (right):
https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly#newcode114
ly/spanners-init.ly:114: breakSlur = #(make-music
https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly
File ly/spanners-init.ly (right):
https://codereview.appspot.com/7424049/diff/19022/ly/spanners-init.ly#newcode114
ly/spanners-init.ly:114: breakSlur = #(make-music 'BreakSlurEvent)
I am not happy with a new event type here.
On 2013/03/01 10:56:57, MikeSol wrote:
Implements inheritence in slur engravers to avoid code dups
Mike, can you make that a separate review placed on issue 2689? Things
become too tangled up to review on their respective merits otherwise.
https://codereview.appspot.com/7424049/
https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly
File input/regression/repeat-slur.ly (right):
https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly#newcode14
input/regression/repeat-slur.ly:14: \alternative { { a' ) b' \set
On 28 févr. 2013, at 21:30, n.putt...@gmail.com wrote:
https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly
File input/regression/repeat-slur.ly (right):
https://codereview.appspot.com/7424049/diff/1/input/regression/repeat-slur.ly#newcode14
On Feb 28, 2013 8:37 PM, m...@mikesolomon.org m...@mikesolomon.org
wrote:
You're right, but I've opted for the breaking behavior in the most recent
patch-set (\breakSlurHere). Otherwise, slurs wouldn't be able to span only
one musical moment.
Ok, so how about using an event of class
On 28 févr. 2013, at 22:29, Neil Puttock n.putt...@gmail.com wrote:
On Feb 28, 2013 8:37 PM, m...@mikesolomon.org m...@mikesolomon.org wrote:
You're right, but I've opted for the breaking behavior in the most recent
patch-set (\breakSlurHere). Otherwise, slurs wouldn't be able to span
Very nice, and thanks a lot! From visual inspection only, LGTM.
Just curious: You apparently like the word `junk', however, I find it
not optimal. Can you replace this with `discard' or `cut' within the
command names?
Much better, thanks!
https://codereview.appspot.com/7424049/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
66 matches
Mail list logo
