Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-02 Thread Carl . D . Sorensen
Thanks for figuring this out. I'm now working on make check, and will post a new patch shortly (I hope). The new patch is up at https://codereview.appspot.com/568650043 https://codereview.appspot.com/337870043/ ___ lilypond-devel mailing

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-02 Thread Paul Morris
Hi Carl, On 4/2/19 12:14 AM, carl.d.soren...@gmail.com wrote: https://codereview.appspot.com/337870043/diff/40001/input/regression/chord-name-exceptions.ly#newcode29 input/regression/chord-name-exceptions.ly:29: chExceptions = #(append (chordmode->exception-entry chordVar markupVar)

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-01 Thread Carl . D . Sorensen
On 2018/11/10 05:44:23, pwm wrote: https://codereview.appspot.com/337870043/diff/40001/Documentation/notation/chords.itely#newcode679 Documentation/notation/chords.itely:679: represent the structure of the chord. When entered in node mode, typo: "note mode" Done.

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2019-04-01 Thread Carl . D . Sorensen
On 2018/11/10 19:44:47, pwm wrote: Hi Charles, Today I built and ran 'make check' with your patch applied to current master. I was able to get it to pass 'make check' by making the following two changes. 1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`. 2. In that

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2018-11-10 Thread paulwmorris
Hi Charles, Today I built and ran 'make check' with your patch applied to current master. I was able to get it to pass 'make check' by making the following two changes. 1. In `chord-entry.scm` line 267, remove `(write-me "base3: " bass)`. 2. In that same file, line 100, remove the parens to

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2018-11-09 Thread paulwmorris
Hi Charles, I was thinking about working on MusicXML export for chord symbols, and wondered about the status of your GSOC project. (It would, of course, make exporting chord symbols much simpler and more robust.) I was really glad to find your code up on Reitveld, and was curious, so I gave it

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2018-08-12 Thread chazwins6
On 2018/08/12 13:54:08, lilypond-pkx wrote: On 2018/08/11 14:59:10, chazwins6 wrote: > Fixing errors in make doc. Fails make check input/regression/chord-names-languages.ly' ~~~ Parsing... Renaming input to: `/home/james/lilypond-git/input/regression/chord-names-languages.ly' warning:

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2017-12-30 Thread pkx166h
Hello Charles, Thanks for your patch however, this fails make check. It fails on a number of different reg tests but all with the same basic error. Example: ~~~ /home/james/lilypond-git/input/regression/chord-names-lower-case-minor.ly' warning: cannot find property type-check for

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2017-12-29 Thread chazwins6
On 2017/12/29 22:38:54, chazwins6 wrote: Fixing errors with chord-semantics This should be working now. Sorry for the delay, I was very busy with school! https://codereview.appspot.com/337870043/ ___ lilypond-devel mailing list

Re: Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2017-11-23 Thread pkx166h
Charles, I just wanted to make sure you saw my last reply about your patch failing the regression tests. It would be shame to let all your hard work so far go to waste. Regards james https://codereview.appspot.com/337870043/ ___ lilypond-devel

Charles Winston's GSoC code: Chord Semantics (issue 337870043 by chazwi...@gmail.com)

2017-11-04 Thread pkx166h
Hello, This fails a make check Processing `./fd/lily-2f531b63.ly' Parsing... Renaming input to: `/home/james/lilypond-git/input/regression/predefined-fretboards.ly' warning: cannot find property type-check for `chord-semantics' (music-type?). perhaps a typing error? Writing timing to