Re: Current state of automatic footnotes. (issue4580041)

2011-07-29 Thread Neil Puttock
On 28 July 2011 15:57, wrote: > Many thanks to everyone for their help on this. > > Pushed as 233aad0ba9781e43424c4e77a859e42b660210e6. Hi Mike, can you look at my comments from a month ago please? I believe some of them are still relevant. Thanks, Neil ___

Re: Current state of automatic footnotes. (issue4580041)

2011-07-28 Thread mtsolo
Many thanks to everyone for their help on this. Pushed as 233aad0ba9781e43424c4e77a859e42b660210e6. Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypo

Re: Current state of automatic footnotes. (issue4580041)

2011-07-07 Thread mtsolo
On 2011/06/26 10:03:16, mike_apollinemike.com wrote: On Jun 26, 2011, at 11:26 AM, mailto:m...@apollinemike.com wrote: > On Jun 25, 2011, at 6:38 PM, mailto:percival.music...@gmail.com wrote: > >> On 2011/06/25 07:15:39, J_lowe wrote: >>> I get an error/seg fault when I try to make: >> >> I

Re: Current state of automatic footnotes. (issue4580041)

2011-06-26 Thread m...@apollinemike.com
On Jun 26, 2011, at 11:26 AM, m...@apollinemike.com wrote: > On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote: > >> On 2011/06/25 07:15:39, J_lowe wrote: >>> I get an error/seg fault when I try to make: >> >> I can confirm this. >> >> > > Fixed. I had accidentally kept "annotat

Re: Current state of automatic footnotes. (issue4580041)

2011-06-26 Thread m...@apollinemike.com
On Jun 25, 2011, at 6:38 PM, percival.music...@gmail.com wrote: > On 2011/06/25 07:15:39, J_lowe wrote: >> I get an error/seg fault when I try to make: > > I can confirm this. > > Fixed. I had accidentally kept "annotation-whiteout" in balloon.cc whereas I had scrubbed it in all the other fi

Re: Current state of automatic footnotes. (issue4580041)

2011-06-25 Thread percival . music . ca
On 2011/06/25 07:15:39, J_lowe wrote: I get an error/seg fault when I try to make: I can confirm this. http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-dev

Re: Current state of automatic footnotes. (issue4580041)

2011-06-25 Thread pkx166h
Hello, I get an error/seg fault when I try to make: (sorry of this a bit verbose) make runs 'for a bit' then I get --snip-- ezh --header=texidoc --header=texidoccs --header=texidocde --header=texidoces --header=texidocfr --header=texidochu --header=texidocit --header=texidocja --header=texidoc

Re: Current state of automatic footnotes. (issue4580041)

2011-06-22 Thread n . puttock
Hi Mike, I'll take a closer look at this at the weekend. Cheers, Neil http://codereview.appspot.com/4580041/diff/10001/input/regression/footnote-auto-numbering-page-reset.ly File input/regression/footnote-auto-numbering-page-reset.ly (right): http://codereview.appspot.com/4580041/diff/10001/i

Re: Current state of automatic footnotes. (issue4580041)

2011-06-22 Thread mtsolo
On 2011/06/21 09:17:25, Graham Percival wrote: I can confirm the "cannot compile with this patch applied". Should apply cleanly - please confirm & leave your comments! Cheers, MS http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing lis

Re: Current state of automatic footnotes. (issue4580041)

2011-06-21 Thread percival . music . ca
I can confirm the "cannot compile with this patch applied". http://codereview.appspot.com/4580041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Current state of automatic footnotes. (issue4580041)

2011-06-18 Thread bordage . bertrand
Hi Mike! There is a problem with your patch, I can not compile until the end, even after "git clean -fxd." This crashes when building internals.texi And there is still the same spacing issues with "number_raise" and notes higher than 9... Thanks, Bertrand http://codereview.appspot.com/4580041/d

Current state of automatic footnotes. (issue4580041)

2011-06-06 Thread mtsolo
Reviewers: , Message: Hey all, Here is the current state of automatic footnotes. Some things to note: (1) It nixes the two-pass algorithm to account for annotation width but provides enough information to create a two (or many) pass algorithm entirely from Scheme. Said algorithm can go in th