Re: Doc: Corrected doc string for ly:dimension? (issue 547470049 by davidgrant...@gmail.com)

2020-01-26 Thread dak
On 2020/01/26 10:45:11, thomasmorley651 wrote: > I don't see any difference to checking for a number either. Thus "distinguish" > feels strange. There was a time when music function predicates determined syntactic decisions based on what function they pointed to rather than what they evaluated

Re: Doc: Corrected doc string for ly:dimension? (issue 547470049 by davidgrant...@gmail.com)

2020-01-26 Thread thomasmorley65
I don't see any difference to checking for a number either. Thus "distinguish" feels strange. Ofcourse it's a predicate, thus LGTM Thanks! You can't be motivated to go through the other doc-strings listed in IR 4. Scheme functions ? :) https://codereview.appspot.com/547470049/

Doc: Corrected doc string for ly:dimension? (issue 547470049 by davidgrant...@gmail.com)

2020-01-25 Thread davidgrant . no
Reviewers: , Message: It isn't clear to me how a dimension is different from a normal number, but the current doc string seems to be incorrect all the same. Description: Doc: Corrected doc string for ly:dimension? ly:dimension? is a predicate - it does not return a number. Please review this