Wow, this is almost done. New patch set uploaded. I've
responded to some comments individually, and made a lot of
small changes requested, but I want to call everyone's
attention to the TODO on l.1504, regarding this clause:
the reference point of a non-staff line is its highest
point.
Keith
LGTM; just a minor typo and a suggestion to remove inadvisable code.
http://codereview.appspot.com/2642043/diff/14001/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
Pushed with some final changes:
http://git.sv.gnu.org/gitweb/?p=lilypond.git;a=commitdiff;h=a3f254b
Closing this issue now. Thanks everyone!
- Mark
http://codereview.appspot.com/2642043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Here's the next patch set for the
Vertical spacing inside a system doc stuff. I
tried to address everything you guys mentioned; let me know
what you think. One significant thing I did here was
to remove the entire @subsection called
Vertical spacing between systems, since I don't think it
was
Hi Mark,
It's the first time I read your NR4 patches, so I may certainly have
missed a few things.
Your patch looks good, but I was a bit surprised by the overall writing
style of NR4.
This chapter looks odd to me, and somehow not on par NR1 and 2. It's
obviously a whole chapter that hasn't
I've limited my comments to just one :) I think we need to push this
now and move on - we still have to change all the names, and a further
review of the wording after that might suggest a few more tweaks. I'm
sure more clarification will be necessary after users try to understand
and use this,
LGTM.
Thanks, Mark.
Carl
http://codereview.appspot.com/2642043/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/2642043/diff/14001/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/14001/Documentation/notation/spacing.itely#newcode256
Documentation/notation/spacing.itely:256: a system is the
Mark,
Too long, but hard to say what will be useful without getting away for a
while. Looks good to me, whether you either take or leave my
suggestions.
http://codereview.appspot.com/2642043/diff/14001/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1501
Documentation/notation/spacing.itely:1501: @item @emph{staff-like
On 29/10/10 05:12, k-ohara5...@oco.net wrote:
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1509
On Fri, 29 Oct 2010 01:17:00 -0700, Ian Hulin i...@hulin.org.uk wrote:
On 29/10/10 05:12, Keith wrote:
Documentation/notation/spacing.itely:1513: * Inter-system spacing
properties::
Within-system
You said: inter = between, intra = within [...]
or do you mean the original Inter-system
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1509
Documentation/notation/spacing.itely:1509: available. Then, the
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1662
Documentation/notation/spacing.itely:1662:
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1624
Documentation/notation/spacing.itely:1624: size) will always reset
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1624
Documentation/notation/spacing.itely:1624: size) will always reset
Looks pretty good, Mark. I've suggested a couple of changes near the
top.
Trevor
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
Reviewers: ,
Message:
Here's a completely rewritten version of
NR 4.4.1 Vertical spacing inside a system
Comments?
Thanks.
- Mark
Description:
Doc: NR 4.4.1: Rewrite.
Please review this at http://codereview.appspot.com/2642043/
Affected files:
M Documentation/notation/spacing.itely
Mark,
I think this is a great start, and will greatly help.
The major issues I see are (1) repeating information (i.e. the meanings
of space, minimum-distance, padding, and stretchability), and (2)
introducing exhaustive lists into the NR.
Repeating information is prohibited by policy because
On 2010/10/23 00:51:31, Carl wrote:
Mark,
I think this is a great start, and will greatly help.
The major issues I see are (1) repeating information
(i.e. the meanings of space, minimum-distance, padding,
and stretchability), and (2) introducing exhaustive lists
into the NR.
Carl,
(1)
More comments inlined.
Thanks,
Carl
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely
File Documentation/notation/spacing.itely (right):
http://codereview.appspot.com/2642043/diff/1/Documentation/notation/spacing.itely#newcode1501
21 matches
Mail list logo
