Re: Doc: Removed [fragment] from @lilypond examples NR (issue2810041)

2010-11-02 Thread percival . music . ca
On 2010/11/01 18:35:14, Trevor Daniels wrote: I'm happy with the changes to vocal.itely, although ragged-right could also be removed in many (maybe all) of the @lilyponds. Aye, [ragged-right] should be removed from (almost?) all @lilypond. But this patch is too big already. Thanks, pushed.

Re: Doc: Removed [fragment] from @lilypond examples NR (issue2810041)

2010-11-01 Thread tdanielsmusic
I'm happy with the changes to vocal.itely, although ragged-right could also be removed in many (maybe all) of the @lilyponds. Trevor http://codereview.appspot.com/2810041/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Doc: Removed [fragment] from @lilypond examples NR (issue2810041)

2010-10-31 Thread percival . music . ca
Reviewers: , Message: Docs look ok, but I'm not 100% certain about the changes to chords, or whether Trevor wants us changing vocal.itely. (this is a git-cl-merge of James Lowe's initial doc patch, and a few fixes I applied to that one; I don't think it's worth separating this into two separate

Re: Doc: Removed [fragment] from @lilypond examples NR (issue2810041)

2010-10-31 Thread Carl . D . Sorensen
I've only reviewed the chords section, since Graham was unsure about it. I think that it most cases, there should be no \relative in these sections. Thanks, Carl http://codereview.appspot.com/2810041/diff/1/Documentation/notation/chords.itely File Documentation/notation/chords.itely (right):

Re: Doc: Removed [fragment] from @lilypond examples NR (issue2810041)

2010-10-31 Thread percival . music . ca
On 2010/10/31 13:54:01, Carl wrote: I think the relative should only be included with figures: 1. When there are notes, and 2. When we want the notes in relative mode. Ok, I've removed all [relative=?] unless there's a combination of notes with \chordmode or \figures. Will upload once