Re: Draws a line above footnotes (issue4167063)

2011-02-23 Thread David Kastrup
Joe Neeman joenee...@gmail.com writes: On Wed, Feb 23, 2011 at 3:14 PM, Mike Solomon mike...@ufl.edu wrote: You're right - it takes a long time :( Perhaps it'd be wise to make a footnote switch that allows users to opt-out of this slowness. Better just to make

Re: Draws a line above footnotes (issue4167063)

2011-02-23 Thread bordage . bertrand
New patch here : http://codereview.appspot.com/4213042 http://codereview.appspot.com/4167063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread mtsolo
Reviewers: Bertrand Bordage, mikesol_ufl.edu, joeneeman, Message: Thanks Joe! http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc#newcode189 lily/note-head.cc:189: footnote On

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread bordage . bertrand
I meant : we can't use this to do a footnote when in a markup or markuplines. Something like : \markuplines { bla bla bla \footnote { Oh yes ? } bla bla bla } I know lilypond-book is the best solution for this issue. But it would be easier if LilyPond had a native support of these features.

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread Mike Solomon
I cooked up something that more or less does the job. It's up on Rietveld. Cheers, MS foo.ly Description: Binary data foo.pdf Description: Adobe PDF document On Feb 22, 2011, at 12:24 PM, bordage.bertr...@gmail.com wrote: I meant : we can't use this to do a footnote when in a markup or

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread bordage . bertrand
:p Great job ! There's no word to thank you enough ! Thanks thanks thanks, Bertrand http://codereview.appspot.com/4167063/ ___ lilypond-devel mailing list lilypond-devel@gnu.org http://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread joeneeman
On 2011/02/22 15:23:00, MikeSol wrote: On 2011/02/22 01:05:49, joeneeman wrote: Why not make the separator a (stencil-valued) property of the paper-book? I could, but currently, this patch employs its current stencil kludge for the following (perhaps-unfounded) reason. Please let me know

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread Mike Solomon
On Feb 22, 2011, at 7:17 PM, joenee...@gmail.com wrote: On 2011/02/22 15:23:00, MikeSol wrote: On 2011/02/22 01:05:49, joeneeman wrote: Why not make the separator a (stencil-valued) property of the paper-book? I could, but currently, this patch employs its current stencil kludge for the

Re: Draws a line above footnotes (issue4167063)

2011-02-22 Thread Joe Neeman
On Wed, Feb 23, 2011 at 3:14 PM, Mike Solomon mike...@ufl.edu wrote: On Feb 22, 2011, at 7:17 PM, joenee...@gmail.com wrote: On 2011/02/22 15:23:00, MikeSol wrote: On 2011/02/22 01:05:49, joeneeman wrote: Have you checked the performance of this? This part is linear and so it makes

Draws a line above footnotes (issue4167063)

2011-02-21 Thread bordage . bertrand
Wow, nice job Mike ! I am also currently trying to solve this issue. With Scheme only I managed to do a good solution for endnotes. I have some suggestions for your work : * There should be more space between separator line and footnotes. * Maybe a smaller separator, like LaTeX does. line-width

Re: Draws a line above footnotes (issue4167063)

2011-02-21 Thread joeneeman
http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc File lily/note-head.cc (right): http://codereview.appspot.com/4167063/diff/3018/lily/note-head.cc#newcode189 lily/note-head.cc:189: footnote Any particular reason this belongs to note-head-interface (rather than, say,