On 2010/12/07 03:43:01, Carl wrote:
LGTM.
Do you think it's ready to go now?
Sure.
Cheers,
Neil
http://codereview.appspot.com/3319041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM.
Do you think it's ready to go now?
http://codereview.appspot.com/3319041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
On 2010/11/25 00:32:58, Neil Puttock wrote:
OK, regtest's on hold while I work out why the following doesn't work:
The regtest runs with my proposed patch for issue 1428.
Thanks,
Carl
http://codereview.appspot.com/3319041/
___
lilypond-devel
I can't comment on the code itself (from a first look it makes sense,
but I haven't dug too deep). What is missing, though, is a regtest...
http://codereview.appspot.com/3319041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Reviewers: Reinhold,
Message:
On 2010/11/25 00:16:22, Reinhold wrote:
I can't comment on the code itself (from a first look it makes sense,
but I
haven't dug too deep). What is missing, though, is a regtest...
I've held off doing a regtest until somebody can confirm this is the
right course
On 2010/11/25 00:21:21, Neil Puttock wrote:
I've held off doing a regtest until somebody can confirm this is the
right
course of action, though if you insist... :)
OK, regtest's on hold while I work out why the following doesn't work:
mypart = \bookpart {
\relative c' { c1 }
}
\book {