Re: Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-18 Thread v . villenave
On 2019/03/13 08:51:52, Valentin Villenave wrote: Further simplification; add CHANGES item. Pushed as https://git.savannah.gnu.org/cgit/lilypond.git/commit/?id=464cf0d8111976c63fe778f358ddbe28bce532a8 Thanks! https://codereview.appspot.com/572520044/

Re: Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-13 Thread v . villenave
On 2019/03/12 22:15:48, dak wrote: https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely#newcode246 Documentation/notation/input.itely:246: \paper @{ @dots{} @} I don't understand these diff lines. Any idea where they are from? I thought they were because

Re: Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-12 Thread dak
https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely File Documentation/notation/input.itely (right): https://codereview.appspot.com/572520044/diff/544550044/Documentation/notation/input.itely#newcode246 Documentation/notation/input.itely:246: \paper @{

Re: Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-10 Thread v . villenave
Reviewers: thomasmorley651, Message: Thanks! I actually hadn’t reviewed Johannes’ code in detail, but you make good points. https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly File ly/swing.ly (right):

Fix #687: Include MIDI swing script in default distribution (issue 572520044 by v.villen...@gmail.com)

2019-03-10 Thread thomasmorley65
Hi Valentin, up to now I didn't test, but read the code only. Several small suggestions: https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly File ly/swing.ly (right): https://codereview.appspot.com/572520044/diff/574520044/ly/swing.ly#newcode99 ly/swing.ly:99: (fold (lambda (x