On 2011/02/02 23:55:59, Neil Puttock wrote:
LGTM.
Just needs rebasing (I assume you don't want to delete
tablature-dot-placement.ly)
Done
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
LGTM.
Just needs rebasing (I assume you don't want to delete
tablature-dot-placement.ly)
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
LGTM, and passes regtests.
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond-devel
Hi Carl,
Is moving `determine-frets-and-strings' required for the patch to work?
It makes reviewing the changes difficult.
Cheers,
Neil
http://codereview.appspot.com/4056041/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
Hi Carl,
LGTM - I don't think that many users will ever
change handleNegativeFrets, but your solution
is encompassing and leaves nothing to be desired ;-)
Regards,
Marc
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm
File scm/translation-functions.scm (right):
Thanks, Marc. Good suggestion.
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm
File scm/translation-functions.scm (right):
http://codereview.appspot.com/4056041/diff/1/scm/translation-functions.scm#newcode394
scm/translation-functions.scm:394: ((eq? handle-negative
Reviewers: marc,
Message:
I've posted a patch for fixing issue 1035, by giving the user control
over
what to do with negative fret numbers demanded by an assigned string.
The default behavior is to recalculate the note and put it in the
tablature or fretboard as if it had not had a string
