LGTM, with Neil's comments implemented.
http://codereview.appspot.com/4449061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
LTGM, please push now.
http://codereview.appspot.com/4449061/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
http://codereview.appspot.com/4449061/diff/4001/lily/pdf-scheme.cc
File lily/pdf-scheme.cc (right):
http://codereview.appspot.com/4449061/diff/4001/lily/pdf-scheme.cc#newcode30
lily/pdf-scheme.cc:30: Encode the given string to either Latin1 (which
is a subset of
move space to start of next
LGTM
Some nitpicks, see below
http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc
File lily/pdf-scheme.cc (left):
http://codereview.appspot.com/4449061/diff/1/lily/pdf-scheme.cc#oldcode41
lily/pdf-scheme.cc:41: if (!g) {
Please use gnu coding standards for brace placement
Reviewers: jan.nieuwenhuizen,
Message:
On 2011/04/26 13:19:01, jan.nieuwenhuizen wrote:
LGTM
Some nitpicks, see below
New patch is up, which includes all of Jan's nitpicks (in particular,
GNU coding standard for braces, char const*, BOM comment and definition
as \xFE\xFF). I also fixed a
