Re: Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-25 Thread dak
On 2020/04/25 08:36:02, hahnjo wrote: > On 2020/04/24 20:14:36, hahnjo wrote: > > On 2020/04/24 18:25:33, lemzwerg wrote: > > > LGTM, thanks a lot! > > > > > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > > > File po/GNUmakefile (right): > > > > > > > > >

Re: Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-25 Thread jonas . hahnfeld
On 2020/04/24 20:14:36, hahnjo wrote: > On 2020/04/24 18:25:33, lemzwerg wrote: > > LGTM, thanks a lot! > > > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > > File po/GNUmakefile (right): > > > > >

Re: Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-24 Thread jonas . hahnfeld
Reviewers: lemzwerg, Message: On 2020/04/24 18:25:33, lemzwerg wrote: > LGTM, thanks a lot! > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile > File po/GNUmakefile (right): > > https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode14 >

Fix warnings related to po (issue 551830043 by jonas.hahnf...@gmail.com)

2020-04-24 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks a lot! https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile File po/GNUmakefile (right): https://codereview.appspot.com/551830043/diff/573740043/po/GNUmakefile#newcode14 po/GNUmakefile:14: sed-makestuff = -e 's/[a-zA-Z_/]*make\[[0-9]*\].*//' shouldn't this be