Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread m...@apollinemike.com
On Jul 19, 2011, at 6:11 PM, Neil Puttock wrote: On 19 July 2011 09:10, m...@apollinemike.com m...@apollinemike.com wrote: After making several round-trips around the source this morning, I can't put off composition any longer, but I fear that all I will compose today are songs about the

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread Neil Puttock
On 11 August 2011 12:34, m...@apollinemike.com m...@apollinemike.com wrote: I figured out why it works - I figured I'd post this to the list in case anyone else ever wants to mess around with pure properties. The StemTremolo is added to the paper column's element grob array via the

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-08-11 Thread m...@apollinemike.com
On Aug 11, 2011, at 7:03 PM, Neil Puttock wrote: On 11 August 2011 12:34, m...@apollinemike.com m...@apollinemike.com wrote: I figured out why it works - I figured I'd post this to the list in case anyone else ever wants to mess around with pure properties. The StemTremolo is added to

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-19 Thread m...@apollinemike.com
On Jul 18, 2011, at 9:53 PM, n.putt...@gmail.com wrote: Even simpler: remove the Y-extent default, add Stem_tremolo::pure_height and an entry in pure-print-to-height-conversions (since ly:grob::stencil-height is the same as getting the non-pure extent from the translated stencil).

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-19 Thread Neil Puttock
On 19 July 2011 09:10, m...@apollinemike.com m...@apollinemike.com wrote: After making several round-trips around the source this morning, I can't put off composition any longer, but I fear that all I will compose today are songs about the Axis_group_interface if I don't understand how this

Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread mtsolo
Reviewers: , Message: This fixes issue 1768. Description: Fixes note column skylines by adding stem tremolo to axis group. Please review this at http://codereview.appspot.com/4754054/ Affected files: A input/regression/stem-tremolo-note-column.ly M lily/include/note-column.hh M

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread n . puttock
Hi Mike, I think this is too complicated; you can probably achieve the same result via a Stem_tremolo::pure_height function. Cheers, Neil http://codereview.appspot.com/4754054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread mtsolo
On 2011/07/18 19:24:26, Neil Puttock wrote: Hi Mike, I think this is too complicated; you can probably achieve the same result via a Stem_tremolo::pure_height function. Cheers, Neil Thanks for the feedback! How would pure height affect the calculation of horizontal skylines? The issue

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread n . puttock
On 2011/07/18 19:28:51, MikeSol wrote: How would pure height affect the calculation of horizontal skylines? It should ensure the skylines are correct, assuming there's an entry for Stem_tremolo::height in pure-conversions-alist. It looks like the existing height function is pure since it

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread n . puttock
On 2011/07/18 19:47:53, Neil Puttock wrote: On 2011/07/18 19:28:51, MikeSol wrote: How would pure height affect the calculation of horizontal skylines? It should ensure the skylines are correct, assuming there's an entry for Stem_tremolo::height in pure-conversions-alist. It looks

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread pkx166h
Make works fine but I get a seg fault when I do a make check after a test-baseline for the reg test comparison. http://codereview.appspot.com/4754054/ ___ lilypond-devel mailing list lilypond-devel@gnu.org

Re: Fixes note column skylines by adding stem tremolo to axis group. (issue4754054)

2011-07-18 Thread n . puttock
On 2011/07/18 20:01:00, J_lowe wrote: Make works fine but I get a seg fault when I do a make check after a test-baseline for the reg test comparison. Same here. stem-tremolo.ly segfaults inside rhythmic-column.cc; the acknowledged StemTremolo doesn't have an X-parent.