Re: Implement framework for post-fix text (de)cresc spanners

2009-08-29 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Sonntag, 23. August 2009 19:57:26 schrieb Reinhold Kainhofer: So,for now I would simply apply that patch so that the properties get interpreted, but don't add a new command, which will be changed in the next version again. Anyone who whats to

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-28 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Samstag, 22. August 2009 19:19:18 schrieb Han-Wen Nienhuys: brief comments: - get_property_setting() should take SCMs rather than const char* , so you save runtime lookups. I don't exactly understand what you mean by this... The two parameters

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-28 Thread Han-Wen Nienhuys
On Fri, Aug 28, 2009 at 7:29 AM, Reinhold Kainhoferreinh...@kainhofer.com wrote: - get_property_setting() should take SCMs rather than const char* , so you save runtime lookups. I don't exactly understand what you mean by this... The two parameters of get_property_setting are passed on the

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-23 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Sunday 23 August 2009 02:16:15 Carl Sorensen wrote: On 8/22/09 5:13 PM, Graham Percival gra...@percival-music.ca wrote: If this change uses \newcr or \crnew or whatever, then fine. If it redefines the behavior of \cresc, then I recommend

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-23 Thread Graham Percival
On Sun, Aug 23, 2009 at 07:57:26PM +0200, Reinhold Kainhofer wrote: On Sunday 23 August 2009 02:16:15 Carl Sorensen wrote: Yes, we should call it \newcresc, and indicate in the documentation that \cresc is deprecated. ... So,for now I would simply apply that patch so that the properties get

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-22 Thread Han-Wen Nienhuys
brief comments: - can you include the front-end work in the patch too? It makes it easier to see what is going on - get_porperty_setting() should take SCMs rather than const char* , so you save runtime lookups. On Sat, Apr 11, 2009 at 7:28 PM, Reinhold Kainhoferreinh...@kainhofer.com wrote:

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-22 Thread Carl Sorensen
On 8/22/09 11:34 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: -BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Samstag, 22. August 2009 19:19:18 schrieb Han-Wen Nienhuys: brief comments: - can you include the front-end work in the patch too? It makes it easier to see what is

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-22 Thread Graham Percival
On Sat, Aug 22, 2009 at 02:24:22PM -0600, Carl Sorensen wrote: On 8/22/09 11:34 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: Graham does not want any syntax changes prior to 2.14, so this won't go into spanner-init.ly. But these three definitions is all that is to be said about

Re: Implement framework for post-fix text (de)cresc spanners

2009-08-22 Thread Carl Sorensen
On 8/22/09 5:13 PM, Graham Percival gra...@percival-music.ca wrote: On Sat, Aug 22, 2009 at 02:24:22PM -0600, Carl Sorensen wrote: On 8/22/09 11:34 AM, Reinhold Kainhofer reinh...@kainhofer.com wrote: Graham does not want any syntax changes prior to 2.14, so this won't go into

Implement framework for post-fix text (de)cresc spanners (backend only)

2009-08-21 Thread n . puttock
LGTM. Don't forget to add 'span-text to all-music-properties. http://codereview.appspot.com/109072/diff/1/2 File input/regression/dynamics-custom-text-spanner-postfix.ly (right): http://codereview.appspot.com/109072/diff/1/2#newcode1 Line 1: \version 2.13.1 2.13.4

Re: Implement framework for post-fix text (de)cresc spanners

2009-07-17 Thread Valentin Villenave
2009/5/9 Neil Puttock n.putt...@gmail.com: I favour this version since its the least ambiguous; there's no risk of a user trying to make e.g. a 'CrescendoEvent with 'descrescendo-text. Just for the record (and the mailing list archive): this feature has now been added to our tracker as

Re: Implement framework for post-fix text (de)cresc spanners

2009-07-17 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 Am Freitag, 17. Juli 2009 10:59:35 schrieb Valentin Villenave: 2009/5/9 Neil Puttock n.putt...@gmail.com: I favour this version since its the least ambiguous; there's no risk of a user trying to make e.g. a 'CrescendoEvent with

Re: Implement framework for post-fix text (de)cresc spanners

2009-05-07 Thread Reinhold Kainhofer
Am Sonntag, 12. April 2009 01:57:02 schrieb Neil Puttock: 2009/4/12 Patrick McCarty pnor...@gmail.com: The music properties generally follow a specific naming convention: all lowercase, except the multiple-word properties, which contain hyphens between words. I think this is what Neil

Re: Implement framework for post-fix text (de)cresc spanners

2009-04-11 Thread Neil Puttock
2009/4/12 Patrick McCarty pnor...@gmail.com: On Sun, Apr 12, 2009 at 12:28:06AM +0200, Reinhold Kainhofer wrote: On Samstag, 11. April 2009 20:33:47 n.putt...@gmail.com wrote: You'd need a method which does the reverse of camel_case_to_lisp_identifier () so that the events would be

Implement framework for post-fix text (de)cresc spanners

2009-04-11 Thread n . puttock
I never realized this would be so simple, but it strikes me as a bit of a hack. In your sample text dynamic spanners, there seems to be an element of redundancy in the event properties; you could easily junk '(de)crescendoSpanner and '(de)crescendoText, using 'text only to trigger the change,

Re: Implement framework for post-fix text (de)cresc spanners

2009-04-11 Thread Reinhold Kainhofer
-BEGIN PGP SIGNED MESSAGE- Hash: SHA1 On Samstag, 11. April 2009 20:33:47 n.putt...@gmail.com wrote: I never realized this would be so simple, but it strikes me as a bit of a hack. In your sample text dynamic spanners, there seems to be an element of redundancy in the event

Re: Implement framework for post-fix text (de)cresc spanners

2009-04-11 Thread Patrick McCarty
On Sun, Apr 12, 2009 at 12:28:06AM +0200, Reinhold Kainhofer wrote: On Samstag, 11. April 2009 20:33:47 n.putt...@gmail.com wrote: You'd need a method which does the reverse of camel_case_to_lisp_identifier () so that the events would be converted from e.g. crescendo-spanner -