https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm#newcode1170
scm/output-lib.scm:1170: Returns a line connecting @var{pts}, using
@code{ly:line-interface::line}, gets
On
LGTM.
(Aside from docstring change which you could make when pushing.)
https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm
File scm/output-lib.scm (right):
https://codereview.appspot.com/324800043/diff/20001/scm/output-lib.scm#newcode1170
scm/output-lib.scm:1170: Returns a
On 2017/04/24 14:42:18, david.nalesnik wrote:
LGTM.
I've pointed out two minor issues, but I don't believe they should
hold up the
review process.
By the way, applying
\override Hairpin.style = #'dashed-line to the regtest
input/regression/ferneyhough-hairpins.ly looks great!
LGTM.
I've pointed out two minor issues, but I don't believe they should hold
up the review process.
By the way, applying
\override Hairpin.style = #'dashed-line to the regtest
input/regression/ferneyhough-hairpins.ly looks great!
Reviewers: ,
Message:
Please review.
Description:
Improve elbowed-hairpin
Let the lines be printed by the new make-connected-line-procedure,
using ly:line-interface::line. The new stencil now reacts on
overrides for style and dash-period/fraction.
Not closing Hairpins created by
