http://codereview.appspot.com/6441058/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/6441058/diff/1/lily/parser.yy#newcode993
lily/parser.yy:993: /* Copy the new header fields, i.e. overwrite
existing, but preserve unchanged ones */
The problem with this
Reviewers: dak,
Message:
On 2012/07/27 05:10:50, dak wrote:
I think this is the wrong way to do things since you can't refer to
old header
values when defining the new one. Instead, you should start with
the
definition
you are adding things to, like LAYOUT and similar do. So that
http://codereview.appspot.com/6441058/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/6441058/diff/1/lily/parser.yy#newcode932
lily/parser.yy:932: /* Copy the new header fields, i.e. overwrite
existing, but preserve unchanged ones */
I think this is the wrong
On 2012/07/27 05:09:22, dak wrote:
http://codereview.appspot.com/6441058/diff/1/lily/parser.yy
File lily/parser.yy (right):
http://codereview.appspot.com/6441058/diff/1/lily/parser.yy#newcode932
lily/parser.yy:932: /* Copy the new header fields, i.e. overwrite
existing, but
preserve