On 2012/10/24 10:07:25, dak wrote:
On 2012/10/24 09:58:12, janek wrote:
> LGTM
>
> shall the tracker issues "write doc for this"
It is not as much "write doc for this" as the function itself has its
docs
updated. It is more "update the existing docs in the manual to
reflect the
change".
On 2012/10/24 09:58:12, janek wrote:
LGTM
shall the tracker issues "write doc for this"
It is not as much "write doc for this" as the function itself has its
docs updated. It is more "update the existing docs in the manual to
reflect the change".
and "add a regtest for this" be
added now
LGTM
shall the tracker issues "write doc for this" and "add a regtest for
this" be added now or after this patch is pushed?
(my concern is to make sure that we won't forget)
cheers,
Janek
http://codereview.appspot.com/6744070/
___
lilypond-devel mail
On 2012/10/23 19:45:15, dak wrote:
On 2012/10/23 19:05:09, marc wrote:
> Hey, that was quick! Thanks for solving this issue - LGTM!
Well, there is no regtest and no documentation, so it is not like
there is
nothing left to do.
That's right – we had this discussion before concerning new
fea
On 2012/10/23 19:05:09, marc wrote:
Hey, that was quick! Thanks for solving this issue - LGTM!
Well, there is no regtest and no documentation, so it is not like there
is nothing left to do. And to be honest, the usual "to check this
feature, you have used some code and could equally well turn
Hey, that was quick! Thanks for solving this issue - LGTM!
http://codereview.appspot.com/6744070/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
Reviewers: lemzwerg,
Message:
On 2012/10/23 11:19:59, lemzwerg wrote:
LGTM. Any convert rules necessary?
Well, I abolish list-or-symbol? here on the assumption that nobody used
this peculiar and mostly ill-advised predicate. That is somewhat
optimistic. Converting list-or-symbol? automatica
LGTM. Any convert rules necessary?
http://codereview.appspot.com/6744070/
___
lilypond-devel mailing list
lilypond-devel@gnu.org
https://lists.gnu.org/mailman/listinfo/lilypond-devel
