Re: Issue 4048: Improve crescendo performance with unspecified dynamics (issue 302910043 by nine.fierce.ball...@gmail.com)

2016-07-12 Thread ht . lilypond . development
In short: LGTM. The rest of this comment is just continuing discussion on some of the points in your previous response. On 2016/07/12 05:01:16, Dan Eble wrote: > What are the main user-level justifications for increasing the > complexity of the Dynamic_performer It also improves an example

Re: Issue 4048: Improve crescendo performance with unspecified dynamics (issue 302910043 by nine.fierce.ball...@gmail.com)

2016-07-11 Thread nine . fierce . ballads
Heikki, thanks for taking the time to review this patch. What are the main user-level justifications for increasing the complexity of the Dynamic_performer in this way (in terms of the amount of code)? It addresses the original request in the ticket and other cases noted in response. It

Re: Issue 4048: Improve crescendo performance with unspecified dynamics (issue 302910043 by nine.fierce.ball...@gmail.com)

2016-07-04 Thread nine . fierce . ballads
https://codereview.appspot.com/302910043/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel