Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-18 Thread Richard Shann
On Sat, 2014-10-18 at 17:19 +, d...@gnu.org wrote: > On 2014/10/09 12:02:16, richard_rshann.plus.com wrote: > > > Well, that depends what I meant by the existing code - the specific > file > > I was modifying calls chordRootNamer which is initialized to > > note-name->markup which is in chord-

Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-18 Thread dak
On 2014/10/09 12:02:16, richard_rshann.plus.com wrote: Well, that depends what I meant by the existing code - the specific file I was modifying calls chordRootNamer which is initialized to note-name->markup which is in chord-names.scm:62, and that is where the quoted construct exists in the

Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-09 Thread Richard Shann
On Thu, 2014-10-09 at 11:36 +, d...@gnu.org wrote: > On 2014/10/09 11:08:16, richard_rshann.plus.com wrote: > > On Wed, 2014-10-08 at 17:41 +, mailto:d...@gnu.org wrote: > > > Reviewers: , > > > > > > > > > > https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm > > >

Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-09 Thread dak
On 2014/10/09 11:08:16, richard_rshann.plus.com wrote: On Wed, 2014-10-08 at 17:41 +, mailto:d...@gnu.org wrote: > Reviewers: , > > > https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm > File scm/chord-ignatzek-names.scm (right): > > https://codereview.appspot.co

Re: Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-09 Thread Richard Shann
On Wed, 2014-10-08 at 17:41 +, d...@gnu.org wrote: > Reviewers: , > > > https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm > File scm/chord-ignatzek-names.scm (right): > > https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm#newcode98 > scm/c

Issue 4154: Compact Chord Symbols Patch (issue 153160043 by d...@gnu.org)

2014-10-08 Thread dak
Reviewers: , https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm File scm/chord-ignatzek-names.scm (right): https://codereview.appspot.com/153160043/diff/1/scm/chord-ignatzek-names.scm#newcode98 scm/chord-ignatzek-names.scm:98: (vector-ref #("C" "D" "E" "F" "G" "A" "B")