Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-29 Thread Dan Eble
On Jan 29, 2015, at 00:07 , Keith OHara wrote: > > Shucks. > The similar issue with Accidentals (issue 3646) was not so bad. > There we could look up the stencil one, put it in the 'stencil property like > usual for purposes of line spacing, and then just after line-breaking remove > the accide

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-28 Thread Keith OHara
On Wed, 28 Jan 2015 17:40:33 -0800, wrote: Yes, the ledgered rest stuff is a big tangle. See https://codereview.appspot.com/200860043/ for the best I've been able to do without changing Rest_collision. Shucks. The similar issue with Accidentals (issue 3646) was not so bad. There we could loo

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-28 Thread nine . fierce . ballads
Yes, the ledgered rest stuff is a big tangle. See https://codereview.appspot.com/200860043/ for the best I've been able to do without changing Rest_collision. https://codereview.appspot.com/193590043/ ___ lilypond-devel mailing list lilypond-devel@gnu

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-27 Thread Keith OHara
On Tue, 27 Jan 2015 05:09:58 -0800, wrote: On 2015/01/27 05:21:47, Keith wrote: I discovered this when I tried to use get_property("stencil") from Rest::height while trying to fix issue 4245. It looks like some rests (whole and half rests) have two glyphs, with and without the ledger line,

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-27 Thread nine . fierce . ballads
On 2015/01/27 05:21:47, Keith wrote: Are you sure there is a cycle? Rest_collision does use the height of the rests to determine the height of the rests, but I do not see where calling the Rest::height() function can call Rest_collision() cyclically. Is there some LilyPond input that ca

Re: Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-26 Thread k-ohara5a5a
Are you sure there is a cycle? Rest_collision::calc_positioning_done now uses the pure height of rests because the height of certain rests depends on their position on the staff, which Rest_collision is responsible for adjusting. Rest_collision does use the height of the rests to determine the

Issue 4274: Fix a cyclic dependency in Rest_collision (issue 193590043 by nine.fierce.ball...@gmail.com)

2015-01-26 Thread nine . fierce . ballads
Reviewers: , Description: Rest_collision::calc_positioning_done now uses the pure height of rests because the height of certain rests depends on their position on the staff, which Rest_collision is responsible for adjusting. There are differences in regression test output that I can not yet expl