Re: Issue 5217: Fix sorting order without outside-staff-priority (issue 554960043 by jonas.hahnf...@gmail.com)

2019-11-06 Thread jonas . hahnfeld
Reviewers: Dan Eble, carl.d.sorensen_gmail.com, lilypond-pkx, Message: On 2019/11/06 09:33:45, lilypond-pkx wrote: Interestingly (or not) I did 3 patch runs on this patch and 2 out of 3 times I still got the reg test showing. I have some time today so I'll see if I can spot anything and up

Re: Issue 5217: Fix sorting order without outside-staff-priority (issue 554960043 by jonas.hahnf...@gmail.com)

2019-11-06 Thread pkxgnugitcl
Interestingly (or not) I did 3 patch runs on this patch and 2 out of 3 times I still got the reg test showing. I have some time today so I'll see if I can spot anything and update accordingly. Jams https://codereview.appspot.com/554960043/

Re: Issue 5217: Fix sorting order without outside-staff-priority (issue 554960043 by jonas.hahnf...@gmail.com)

2019-11-05 Thread Carl . D . Sorensen
LGTM. Nice work! Carl https://codereview.appspot.com/554960043/

Issue 5217: Fix sorting order without outside-staff-priority (issue 554960043 by jonas.hahnf...@gmail.com)

2019-11-05 Thread nine . fierce . ballads
THANK YOU I applied this on top of master, ran `make test-baseline` and then `make check` and there were no differences other than the expected test-output-distance case. LGTM https://codereview.appspot.com/554960043/