Re: Issue 5590: Remove dead code from Dot_formatting_problem (issue 583100043 by nine.fierce.ball...@gmail.com)

2019-11-01 Thread Carl . D . Sorensen
On 2019/11/01 17:18:34, Dan Eble wrote: On 2019/10/29 19:38:23, Carl wrote: > My bottom line is that the current system is definitely broken. Yes, and the thing that bugs me most is that it reallocates memory per candidate, for no benefit. > I will look into my code tonight when I get home

Re: Issue 5590: Remove dead code from Dot_formatting_problem (issue 583100043 by nine.fierce.ball...@gmail.com)

2019-11-01 Thread nine . fierce . ballads
On 2019/10/29 19:38:23, Carl wrote: My bottom line is that the current system is definitely broken. Yes, and the thing that bugs me most is that it reallocates memory per candidate, for no benefit. I will look into my code tonight when I get home and see how I handled the "best" issue. If

Re: Issue 5590: Remove dead code from Dot_formatting_problem (issue 583100043 by nine.fierce.ball...@gmail.com)

2019-10-29 Thread Carl . D . Sorensen
I'm torn on this patch. Obviously, the current case is not good. We shouldn't have dead code around. But it is possible that we should in fact use a "best" for the dot formatting problem, and the failure to do so may lead to some of the random formatting issues we see in our regtests. It's

Issue 5590: Remove dead code from Dot_formatting_problem (issue 583100043 by nine.fierce.ball...@gmail.com)

2019-10-29 Thread nine . fierce . ballads
Reviewers: , Description: https://sourceforge.net/p/testlilyissues/issues/5590/ Nothing was using Dot_formatting_problem::best(), which was good because the function that was apparently intended to find the best configuration was not keeping track of the associated best score. Please review