Re: Issue 5656: Warn about accessing the Global context explicitly (issue 567050043 by nine.fierce.ball...@gmail.com)

2020-01-14 Thread thomasmorley65
On 2020/01/14 17:43:19, Dan Eble wrote: On 2020/01/14 13:12:54, Dan Eble wrote: > Harm, > Do you want more time to consider this change, or are you now comfortable with > my pushing it? Since your primary concern was that modifying Global in a \layout block should still work, and my testin

Re: Issue 5656: Warn about accessing the Global context explicitly (issue 567050043 by nine.fierce.ball...@gmail.com)

2020-01-14 Thread nine . fierce . ballads
On 2020/01/14 13:12:54, Dan Eble wrote: Harm, Do you want more time to consider this change, or are you now comfortable with my pushing it? Since your primary concern was that modifying Global in a \layout block should still work, and my testing shows that it does, I'm going to push this. h

Re: Issue 5656: Warn about accessing the Global context explicitly (issue 567050043 by nine.fierce.ball...@gmail.com)

2020-01-14 Thread nine . fierce . ballads
Harm, Do you want more time to consider this change, or are you now comfortable with my pushing it? -- Dan https://codereview.appspot.com/567050043/

Re: Issue 5656: Warn about accessing the Global context explicitly (issue 567050043 by nine.fierce.ball...@gmail.com)

2020-01-08 Thread nine . fierce . ballads
Reviewers: thomasmorley651, Message: On 2020/01/09 00:33:35, thomasmorley651 wrote: I know several custom codings (defining a new grob, thus the need to reintroduce all-grob-descriptions at Global level) using \layout { \context { \Global \grobdescriptions #all-grob-description

Issue 5656: Warn about accessing the Global context explicitly (issue 567050043 by nine.fierce.ball...@gmail.com)

2020-01-08 Thread thomasmorley65
I know several custom codings (defining a new grob, thus the need to reintroduce all-grob-descriptions at Global level) using \layout { \context { \Global \grobdescriptions #all-grob-descriptions } } will this be disallowed with this patch? Then I'd object. If it stays allowed, why