Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-03-02 Thread lemzwerg--- via Discussions on LilyPond development
LGTM, thanks! https://codereview.appspot.com/571780043/

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-03-02 Thread torsten . haemmerle
OK, now I got it. Suppose I've erroneously treated these cases as broken line + 8-char indent. Now it should be the way you want it to be. Cheers, Torsten https://codereview.appspot.com/571780043/

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-03-01 Thread lemzwerg--- via Discussions on LilyPond development
not happy with indentation yet... https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf File mf/feta-scripts.mf (left): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-scripts.mf#oldcode999 mf/feta-scripts.mf:999: .. z2l > Nevertheless, I've changed the

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-03-01 Thread torsten . haemmerle
I think I forgot go mention that I now added Patch set 2: Indentation and separating spaces Formatting changes as proposed by Werner. https://codereview.appspot.com/571780043/

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread torsten . haemmerle
Re-formatted: spaces inserted and strictly 8 char indentations. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5

Re: Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread lemzwerg--- via Discussions on LilyPond development
Very nice, thanks! LGTM. https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf File mf/feta-arrowheads.mf (right): https://codereview.appspot.com/571780043/diff/549620043/mf/feta-arrowheads.mf#newcode58 mf/feta-arrowheads.mf:58: y5 = 0; Please use an indentation of 8

Issue 5806: Tweak mf files to avoid FontForge internal overlap error (issue 571780043 by torsten.haemme...@web.de)

2020-02-29 Thread torsten . haemmerle
Reviewers: , Message: Please review. Description: Issue 5806: Tweak mf files to avoid FontForge internal overlap error When compiling LilyPond, there were 352 error messages caused by FontForge trying to resolve overlapping path problems: >>> Internal Error (overlap) in [...] Fortunately, the