Re: Issue 5919 Make InstrumentName.X-offset more robust (issue 553930044 by thomasmorle...@gmail.com)

2020-04-18 Thread Dan Eble
On Apr 18, 2020, at 14:38, nine.fierce.ball...@gmail.com wrote: > > On 2020/04/18 18:14:33, thomasmorley651 wrote: > > I ran make check and didn't see any differences. Without test coverage, > someone could easily break this again without knowing it. Oops. *I* wrote that; I just neglected to

Re: Issue 5919 Make InstrumentName.X-offset more robust (issue 553930044 by thomasmorle...@gmail.com)

2020-04-18 Thread nine . fierce . ballads
On 2020/04/18 18:14:33, thomasmorley651 wrote: I ran make check and didn't see any differences. Without test coverage, someone could easily break this again without knowing it. https://codereview.appspot.com/553930044/

Issue 5919 Make InstrumentName.X-offset more robust (issue 553930044 by thomasmorle...@gmail.com)

2020-04-18 Thread thomasmorley65
Reviewers: , Description: Issue 5919 Make InstrumentName.X-offset more robust Currently system-start-text::calc-y-offset takes right end of system-start-grobs into account, which may lead to bad results, if one of them is omitted (collapse-height) or moved to the right. Instead we always use the