Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

t; To: "Phil Holmes" > Cc: ; ; ; < > lilypond-devel@gnu.org> > Sent: Friday, April 27, 2012 5:58 PM > > Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue > 6109046) > > > You then need to tick a box more or two to enable that stuff in VBox >>

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

- Original Message - From: "James" To: "Phil Holmes" Cc: ; ; ; Sent: Friday, April 27, 2012 5:58 PM Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046) You then need to tick a box more or two to enable that stuff in VBox or KVM.

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Hello, On 27 April 2012 15:56, Phil Holmes wrote: > > It may depend on your hardware whether this makes sense.  My Ubuntu build > box can multithread within the VM, whereas my (older) Windows box can't. Depends on the paravirtualization. eg. http://www.howtogeek.com/howto/linux/linux-tip-how-

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

- Original Message - From: To: "James" Cc: ; ; Sent: Friday, April 27, 2012 3:41 PM Subject: Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046) On 26 avr. 2012, at 11:43, James wrote: Mike, On 26 April 2012 08:51, m...@apollinemike.com wrote:

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 26 avr. 2012, at 11:43, James wrote: > Mike, > > On 26 April 2012 08:51, m...@apollinemike.com wrote: >> On 26 avr. 2012, at 09:05, James wrote: >> >>> Hello, >>> >>> On 26 April 2012 07:55, m...@apollinemike.com wrote: On 26 avr. 2012, at 07:28, Graham Percival wrote: >>>

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

LGTM http://codereview.appspot.com/6109046/ ___ lilypond-devel mailing list lilypond-devel@gnu.org https://lists.gnu.org/mailman/listinfo/lilypond-devel

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Mike, On 26 April 2012 08:51, m...@apollinemike.com wrote: > On 26 avr. 2012, at 09:05, James wrote: > >> Hello, >> >> On 26 April 2012 07:55, m...@apollinemike.com wrote: >>> >>> On 26 avr. 2012, at 07:28, Graham Percival wrote: >>> Well, right now we have nobody running the automated

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Graham Percival writes: > On Thu, Apr 26, 2012 at 08:05:53AM +0100, James wrote: >> Hello, >> >> On 26 April 2012 07:55, m...@apollinemike.com wrote: >> > I have a meeting in mid-May w/ the University of Paris >> > VIII.  They're donating a computer to LilyPond and I'll set patchy >> > up on it

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

"m...@apollinemike.com" writes: > On 26 avr. 2012, at 09:05, James wrote: > >> Hello, >> >> On 26 April 2012 07:55, m...@apollinemike.com wrote: >>> >>> On 26 avr. 2012, at 07:28, Graham Percival wrote: >>> Well, right now we have nobody running the automated tests to check th

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On Thu, Apr 26, 2012 at 08:05:53AM +0100, James wrote: > Hello, > > On 26 April 2012 07:55, m...@apollinemike.com wrote: > > I have a meeting in mid-May w/ the University of Paris VIII.  They're > > donating a computer to LilyPond and I'll set patchy up on it. > > While you can set up and cron

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 26 avr. 2012, at 09:05, James wrote: > Hello, > > On 26 April 2012 07:55, m...@apollinemike.com wrote: >> >> On 26 avr. 2012, at 07:28, Graham Percival wrote: >> >>> >>> Well, right now we have nobody running the automated tests to >>> check that new patches are ok. So there will be no pa

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Hello, On 26 April 2012 07:55, m...@apollinemike.com wrote: > > On 26 avr. 2012, at 07:28, Graham Percival wrote: > >> >> Well, right now we have nobody running the automated tests to >> check that new patches are ok.  So there will be no patches >> accepted to lilypond. >> > > I have a meeting i

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 26 avr. 2012, at 07:28, Graham Percival wrote: > > Well, right now we have nobody running the automated tests to > check that new patches are ok. So there will be no patches > accepted to lilypond. > I have a meeting in mid-May w/ the University of Paris VIII. They're donating a computer

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On Wed, Apr 25, 2012 at 03:14:33PM +0200, Łukasz Czerwiński wrote: > I know that this is not a very positive message, but I am trying > to save you yet more anguish. Â The lilypond project currently does > not even function smoothly between senior developers with more > than 100

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Almost there, if the regtests run clean, but the added 'for' loops are still not in GNU style - they need a space after 'for'. This must be corrected before pushing. See http://permalink.gmane.org/gmane.comp.gnu.lilypond.devel/46312 where Keith explained this earlier. http://codereview.appspot.

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 25 April 2012 17:06, David Kastrup wrote: > Łukasz Czerwiński writes: > > > I have never ever get an email from Google Code. I have just checked > > that triple. That's the reason for ignoring your comments. I'm sorry > > that my new patch made you run your tests twice to give me the same > >

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Łukasz Czerwiński writes: > I have never ever get an email from Google Code. I have just checked > that triple. That's the reason for ignoring your comments. I'm sorry > that my new patch made you run your tests twice to give me the same > list of errors... >   > Do you run tests for each patch u

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 25 April 2012 14:52, David Kastrup wrote: > (...) > To me, that does not look like you particularly value getting a review. > You have not fixed a single thing I pointed out. You have not checked > your submission yourself for the problems. > > I didn't notice that comment. I'm not used yet t

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

> > I know that this is not a very positive message, but I am trying to save you yet more anguish. The lilypond project currently does > not even function smoothly between senior developers with more > than 100 commits each; there is very little chance for a new > contributor to have a smooth an

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On Wed, Apr 25, 2012 at 01:44:14PM +0200, Łukasz Czerwiński wrote: >As I understand, fixxcc.py will correct that automatically, so I don't >have to bother about that? Nevertheless I'll remember that for my >future patches. fixcc.py can correct those, but this adds "noise" to the git co

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Łukasz Czerwiński writes: > On 25 April 2012 11:57, wrote: > > It would appear that you ignored > , > , > > > No - just look at dates - the comments are newer tha

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc File lily/ledger-line-spanner.cc (left): http://codereview.appspot.com/6109046/diff/9001/lily/ledger-line-spanner.cc#oldcode68 lily/ledger-line-spanner.cc:68: while (flip (&d) != DOWN); On 2012/04/25 11:47:07, Milimetr88

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On 25 April 2012 11:57, wrote: > It would appear that you ignored > > >, >

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

It would appear that you ignored , , the end of and

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

On Tue, 24 Apr 2012 09:21:17 -0700, wrote: If you replace *all* the while(flip()) loops, you can remove the flip function, Well, there will be one more place: spacing-spanner.cc:291 There is: while (flip (&d) != LEFT && rb); By now I can't tell what the whole code is for. Could you give m

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Reviewers: Keith, Graham Percival, http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode63 flower/include/direction.hh:63: // huh? On 2012/04/24 03:32:28

Re: Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

LGTM http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh#newcode78 flower/include/direction.hh:78: #define DOWN_and_UP(d) \ I see that our code uses both versi

Macro for(UP_and_DOWN) and 3 similar. (issue 2491) (issue 6109046)

Looks good to me, but I suggest you also solve the bug you found (issue 2493) in this patch but preferably as a separate commit. Then you can convert all the loops. http://codereview.appspot.com/6109046/diff/1/flower/include/direction.hh File flower/include/direction.hh (right): http://coderevi