2009/7/24 Carl Sorensen :
>> type check also for settings?
>
> Settings needs a list? type check, and I haven't seen one available
> in c++. It shouldn't segfault, because we do a pair check before we
> use it.
ly_is_list (which is a wrapper for scm_list_p) (but see below)
>
> I can't use a pai
On 7/22/09 4:15 PM, "joenee...@gmail.com" wrote:
> I think this is pretty much ready to commit
>
>
> http://codereview.appspot.com/88155/diff/3101/4032
> File lily/beam-scheme.cc (right):
>
> http://codereview.appspot.com/88155/diff/3101/4032#newcode2
> Line 2: beam-scheme.cc -- Retrieving
http://codereview.appspot.com/88155/diff/3101/4027
File input/new/grouping-beats.ly (right):
http://codereview.appspot.com/88155/diff/3101/4027#newcode7
Line 7: Beaming patterns may be altered with the @code{beatGrouping}
property:
new texidoc using \overrideBeamSettings
http://codereview.appsp
I think this is pretty much ready to commit
http://codereview.appspot.com/88155/diff/3101/4032
File lily/beam-scheme.cc (right):
http://codereview.appspot.com/88155/diff/3101/4032#newcode2
Line 2: beam-scheme.cc -- Retrieving beam settings
could you call this beam-grouping-scheme.cc or somethin
Thanks for the catch -- removed
Description:
New format for autobeaming rules
Change autobeaming rules so they are all set in one place and they
remain if the time signature is changed.
Eliminates override-auto-beam-settings and revert-auto-beam-settings
autoBeamSettings property changed to beamS
very nice!
http://codereview.appspot.com/88155/diff/3092/2039
File ly/music-functions-init.ly (right):
http://codereview.appspot.com/88155/diff/3092/2039#newcode699
Line 699: (make-music 'SequentialMusic 'void #t))
I'd feel better if this were finished. At least add FIXME so it can be
easily gr
On Tue, Jul 21, 2009 at 11:06 AM, Patrick McCarty wrote:
> On Tue, Jul 21, 2009 at 11:03 AM, Carl Sorensen wrote:
>>
>>
>> I'm getting ready to push the new autobeaming code. Are there any more
>> comments before I do so?
>>
>> http://codereview.appspot.com/88155
>
> Did you address Neil's last co
On Tue, Jul 21, 2009 at 11:03 AM, Carl Sorensen wrote:
>
>
> I'm getting ready to push the new autobeaming code. Are there any more
> comments before I do so?
>
> http://codereview.appspot.com/88155
Did you address Neil's last comment on the patchset, from 5 days ago?
-Patrick
I'm getting ready to push the new autobeaming code. Are there any more
comments before I do so?
http://codereview.appspot.com/88155
Thanks,
Carl
___
lilypond-devel mailing list
lilypond-devel@gnu.org
http://lists.gnu.org/mailman/listinfo/lilypond
On Wed, Jul 15, 2009 at 07:43:56AM -0600, Carl Sorensen wrote:
>
> On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote:
>
> > http://codereview.appspot.com/88155/diff/95/1147#newcode69
> > Line 69: section 1.2.4 Beams, for more information.
> > Is it possible to use @ruser{} here?
>
> I'm not sure.
On 7/15/09 3:45 PM, "n.putt...@gmail.com" wrote:
>
>
> http://codereview.appspot.com/88155/diff/2005/3086
> File scm/music-functions.scm (right):
>
> http://codereview.appspot.com/88155/diff/2005/3086#newcode519
> Line 519: (make-simultaneous-music output)
> This breaks all the Festival reg
http://codereview.appspot.com/88155/diff/2005/3086
File scm/music-functions.scm (right):
http://codereview.appspot.com/88155/diff/2005/3086#newcode519
Line 519: (make-simultaneous-music output)
This breaks all the Festival regression tests which use \time
(song-associated-voice.ly, song-basic.ly
2009/7/15 Carl Sorensen :
> I'm not sure I understand why you think it should it be in input/new instead
> of just being in the docs. It doesn't use \set or \override. It explains
> the use of a LilyPond command. That's why I thought it should be an inline
> snippet.
It's positioned in the mid
On 7/15/09 9:30 AM, "John Mandereau" wrote:
> Le mercredi 15 juillet 2009 à 07:43 -0600, Carl Sorensen a écrit :
>> On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote:
>>> http://codereview.appspot.com/88155/diff/95/1147#newcode69
>>> Line 69: section 1.2.4 Beams, for more information.
>>> Is it
Le mercredi 15 juillet 2009 à 07:43 -0600, Carl Sorensen a écrit :
> On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote:
> > http://codereview.appspot.com/88155/diff/95/1147#newcode69
> > Line 69: section 1.2.4 Beams, for more information.
> > Is it possible to use @ruser{} here?
>
> I'm not sure.
On 7/14/09 3:57 PM, "n.putt...@gmail.com" wrote:
> Carl, I haven't commenting on them directly, but there are quite a few
> indentation errors in the .scm files.
Thanks for noticing. I went through and fixed them up.
>
>
> http://codereview.appspot.com/88155/diff/95/1147
> File Documentat
2009/7/14 Carl Sorensen :
> It has cleaned up all of the issues that Neil identified, with the exception
> of default autobeaming for 3/4 time. I never got any concurrence for
> setting it back to (3), so it's left at (1 1 1).
I think (3) is preferable, at least for quavers.
The Baerenreiter Ba
Carl, I haven't commenting on them directly, but there are quite a few
indentation errors in the .scm files.
http://codereview.appspot.com/88155/diff/95/1147
File Documentation/topdocs/NEWS.tely (right):
http://codereview.appspot.com/88155/diff/95/1147#newcode69
Line 69: section 1.2.4 Beams, fo
I've posted a new patch set on Rietveld which I think is a release
candidate.
It has changes in all the translated rhythms.itely files so that all of the
docs build properly.
It has the revised snippets in input/new added to the repository.
It has cleaned up all of the issues that Neil identifie
On 7/12/09 11:13 AM, "n.putt...@gmail.com" wrote:
>
> http://codereview.appspot.com/88155/diff/43/1045
> File
> input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly
> (right):
>
> http://codereview.appspot.com/88155/diff/43/1045#newcode1
> Line 1: %% Do not edit this file;
On 7/12/09 11:13 AM, "n.putt...@gmail.com" wrote:
>
> http://codereview.appspot.com/88155/diff/43/1045
> File
> input/lsr/automatic-beams-two-per-two-in-4-4-or-2-2-time-signature.ly
> (right):
>
> http://codereview.appspot.com/88155/diff/43/1045#newcode1
> Line 1: %% Do not edit this file;
On 7/12/09 11:13 AM, "n.putt...@gmail.com" wrote:
>
>
> http://codereview.appspot.com/88155/diff/43/1044
> File Documentation/user/rhythms.itely (right):
>
> http://codereview.appspot.com/88155/diff/43/1044#newcode1662
> Line 1662: of the beam, e.g. @code{#'(1 . 16)}, or @code{#'*} to
> ind
http://codereview.appspot.com/88155/diff/43/1044
File Documentation/user/rhythms.itely (right):
http://codereview.appspot.com/88155/diff/43/1044#newcode1662
Line 1662: of the beam, e.g. @code{#'(1 . 16)}, or @code{#'*} to
indicate a
This could be confusing to users unfamiliar with Scheme, since
23 matches
Mail list logo
