Pushed as
commit 59a842eba0f7ad78289a58a7dfa8fa786cdf11ed
Author: Janek Warchoł lemniskata.bernoull...@gmail.com
Date: Wed Mar 27 17:20:03 2013 +0100
Issue 2245: always align dynamics and lyrics on main notehead
Until now, LyricTexts and DynamicTexts had their X-parents set to
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm
File scm/define-grobs.scm (right):
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm#newcode87
scm/define-grobs.scm:87: (X-extent . ,ly:accidental-interface::width)
The old code is used as an example
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm
File scm/define-grobs.scm (right):
https://codereview.appspot.com/108270044/diff/40001/scm/define-grobs.scm#newcode87
scm/define-grobs.scm:87: (X-extent . ,ly:accidental-interface::width)
I opened a tracker item
Hi Mark,
do you have any objections against putting this patch on countdown?
As i wrote, this is a transitional phase: the patch improves the
situation, but i intend to make more changes when it becomes clear how
they should look like.
best,
Janek
PS i've fixed whitespace/ordering issues in the
On 2014/07/04 20:47:24, janek wrote:
Hi Mark,
do you have any objections against putting this patch on countdown?
No objections, but I'll leave it to someone else to give the green light
since I'm not qualified to evaluate the C++ code.
As i wrote, this is a transitional phase: the patch
2014-07-04 23:21 GMT+02:00 markpole...@gmail.com:
On 2014/07/04 20:47:24, janek wrote:
Hi Mark,
do you have any objections against putting this patch on countdown?
No objections, but I'll leave it to someone else to give the green light
since I'm not qualified to evaluate the C++ code.
ok,
Hi,
2014-07-01 21:35 GMT+02:00 markpole...@gmail.com:
This patch is problematic for me.
Firstly, when a lyric syllable extends to the next note (as with a slur
or tie), it is my understanding that the lyric text should be
left-aligned with the left-most note of the chord. See Issue 3521:
Janek Warchoł wrote:
While I think that it's better to always align lyrics to
the main notehead, I knew that some people would prefer
to do this otherwise, so the patch allows to choose how to
align LyricTexts (and DynamicTexts)
Okay, this is less problematic than I thought it was, and
I'm
Hi,
2014-07-02 20:58 GMT+02:00 markpole...@gmail.com:
Janek Warchoł wrote:
While I think that it's better to always align lyrics to
the main notehead, I knew that some people would prefer
to do this otherwise, so the patch allows to choose how to
align LyricTexts (and DynamicTexts)
PS
2014-07-02 20:58 GMT+02:00 markpole...@gmail.com:
Okay, this is less problematic than I thought it was, and
I'm slowly convincing myself that for LyricText,
main-notehead-alignment is better than NoteColumn-alignment.
However, for DynamicText, I think NoteColumn-alignment is
preferable,
This patch is problematic for me.
Firstly, when a lyric syllable extends to the next note (as with a slur
or tie), it is my understanding that the lyric text should be
left-aligned with the left-most note of the chord. See Issue 3521:
http://code.google.com/p/lilypond/issues/detail?id=3521
Hi folks,
please review.
@Han-Wen: in Script_engraver, you wrote (commit 286fcad779) that
aligning stuff like Scripts on NoteColumns is not correct (lines
256-261). However, to me it seems that using NoteColumns as X-parents
for Lyrics, Dynamics etc. is exactly the way to solve issue 2245
12 matches
Mail list logo
